8000 Polish reader loading, context menus, and Russian translations by FLASH911 · Pull Request #611 · hyprlab/hylki · GitHub
[go: up one dir, main page]
Skip to content

Polish reader loading, context menus, and Russian translations - #611

Closed
FLASH911 wants to merge 4 commits into
hyprlab:mainfrom
FLASH911:ui-polish-and-fixes
Closed

Polish reader loading, context menus, and Russian translations#611
FLASH911 wants to merge 4 commits into
hyprlab:mainfrom
FLASH911:ui-polish-and-fixes

Conversation

@FLASH911
@FLASH911 FLASH911 commented Nov 7, 2026
Copy link
Copy Markdown
Contributor

Summary

This PR groups the small UI fixes and polish changes into one focused patch.

Changes

  • Fix calendar event creation from mail when an invitation title contains multibyte UTF-8 characters.
  • Add a copy button beside the sender address, with visible confirmation.
  • Replace the abrupt full-message swap with a loading skeleton, spinner, and short crossfade.
  • Make right-click context menus more compact by reducing row height, padding, icon size, and group spacing.
  • Localize the WebKit editor actions Cut, Copy, Delete, Select All, and Insert Emoji.
  • Complete the Russian catalog, including new upstream OpenPGP strings added since the translation branch was created.

Compatibility

  • No preference or database migrations.
  • Changes are limited to presentation, loading behavior, and localization.
  • Existing context-menu actions and keyboard shortcuts are unchanged.

Validation

  • cargo test: 1423 passed, 0 failed, 49 ignored.
  • msgfmt --check po/ru.po passes.
  • Russian catalog has no untranslated or fuzzy message entries.
  • Documentation checks pass.

Review notes

This PR intentionally excludes composer workflows and theme additions so each behavior can be reviewed independently.

@FLASH911
fix(calendar): name invitations without splitting UTF-8
1ac42b5 
Truncate the exported iCalendar file name by characters. A long non-Latin title previously panicked when the byte slice fell inside a character.

(cherry picked from commit 5958753)
@FLASH911
feat(reader): smooth loading and copy sender addresses
56f35db 
Add a one-click copy action beside the sender, show a skeleton while full messages load, and crossfade the finished body into place. Enlarge context menus, tooltips and reader action icons for easier use.

(cherry picked from commit 9f6cd55)
@FLASH911
style(menus): make context menus more compact
09fc980
@FLASH911
fix(i18n): complete the Russian interface translation
20e2316 
Translate every active Russian catalog entry, correct stale fuzzy meanings, and preserve formatting placeholders. Localize WebKit context actions that bypass gettext.

(cherry picked from commit 707c839)
hyprlab added a commit that referenced this pull request Nov 7, 2026
@hyprlab @FLASH911
fix(calendar): cut an invitation's file name in characters (#611)
5e41457 
The 60-byte cut could fall inside a non-Latin character and crash Add to Calendar.

Co-Authored-By: FLASH911 <6452736+FLASH911@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Nov 7, 2026
@hyprlab @FLASH911
fix(composer): name the stock menu entries in hylki's language (#611)
d5c0236 
WebKit labels Cut, Copy, Delete, Select All and Insert Emoji in the process locale, which can differ from the language chosen in Hylki.

Co-Authored-By: FLASH911 <6452736+FLASH911@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Nov 7, 2026
@hyprlab @FLASH911
fix(i18n): complete the Russian translation (#611)
098cf96 
Translates the 408 untranslated strings and the 584 fuzzy guesses. Fixed at landing: eight plural messages lost the count in the form Russian uses for 21, 31 and so on, "Find bar position" read as the position of a bar, and учетн is spelled with ё as in the rest of the catalog. The 8 strings added to main since are still in English.

Co-Authored-By: FLASH911 <6452736+FLASH911@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Nov 8, 2026
@hyprlab
chore(release): 1.48.0-beta.3
ebf8334 
Cache encryption (#601), the security batch (#595 to #600), Esc in Undo Send (#607), Focus Mode's own page, the palettes removed, flowed plain text (#606), the remote cache folder (#614), the calendar crash and Russian (#611), Aster Mail drafts (#604) and theme colors (#593).
@hyprlab
hyprlab commented Nov 8, 2026
Copy link
Copy Markdown
Owner

Agentic reply:

The Add to Calendar crash fix, the composer menu labels and the Russian translation are in the 1.48.0-beta.3 release, landed by hand and credited to you. At landing, the Russian file was merged onto main's template, and eight plural forms without {n}, "Find bar position" and учетн (now учётн) were fixed. Please test it there and report anything that doesn't look right. It reaches the stable channel with the next stable release.

The loading skeleton, the copy button beside each sender address and the compact menus were left out. The skeleton undoes the one-step open from #570, the address menu already has Copy Address, and the menu change also resized the reader toolbar and the tooltips across the app.

Russian is at 2435 of 2474 strings. The rest were added on main after your update.

Not translated yet (26):

  • The signing key is not for {addr}, the address this message is from, so the signature does not show who sent it.
  • Open “{name}”?
  • This attachment is a program or a script. Opening it can run it with your permissions. Open it only if you expected it and trust where it came from.
  • Open Anyway
  • Mail stored on this computer is encrypted with a key stored in the keyring. Unlock the keyring if it asks.
  • This happens once and can take a few minutes. If you quit, your mail is left as it was.
  • Encrypting Stored Mail
  • Reset Cache…
  • Mail kept on this computer is encrypted with a key stored in the keyring, and the keyring is locked or did not answer. Unlock it, then try again.
  • Mail Cache Key Missing
  • Mail kept on this computer is encrypted, and the keyring no longer holds its key. If the keyring was replaced, restore the old one and try again. Otherwise reset the cache to download your mail again.
  • Mail Cache Cannot Be Unlocked
  • The key in the keyring does not open the mail kept on this computer. If the keyring was replaced, restore the old one and try again. Otherwise reset the cache to download your mail again.
  • Mail Cache Not Converted
  • The mail kept on this computer could not be converted, and was left as it was. Check that the disk has free space, then try again.
  • The mail kept on this computer could not be read. Try again, or reset the cache to download your mail again.
  • Mail that exists only on this computer is lost: a POP3 account's mail, and unsent mail in the Outbox.
  • Reset the Mail Cache?
  • Anyone who can read your files, or a backup of them, can then read the mail kept on this computer, including mail that is end-to-end encrypted on the server.
  • Encryption can be turned back on in Settings → Privacy.
  • The encrypted cache cannot be opened without the keyring, so it is deleted and your mail is downloaded again.
  • Store Mail Unencrypted?
  • Nothing confirms that the keys for {addresses} belong to them. If one is someone else's, that person can read this message and the recipient cannot. To check a key, compare its fingerprint with its owner and trust it under Settings, OpenPGP. Send Anyway does not ask about these keys again.
  • Accounts, preferences, filters, tags and layout, in one file. Passwords, OAuth client secrets and OpenPGP keys are not included.
  • Remove trackers from links
  • Mail stored on this computer will be encrypted at the next start which can take a few minutes. Earlier versions of the app cannot open it. Turn this setting off and restart before going back to an older version.

Marked fuzzy, to check (13):

  • Encrypted, and signed by {signer}, whose key is not for the sender's address {addr}
  • Waiting for the Keyring
  • Checking the copy
  • Decrypting Stored Mail
  • Store Unencrypted…
  • Keyring Unavailable
  • Mail Cache Unreadable
  • Mail kept on this computer is deleted and downloaded again from the server.
  • Store Unencrypted
  • Stored Mail
  • Encrypt stored mail
  • Encrypt Stored Mail?
  • Encrypt

The beta build is in the repo now. If you already have the beta installed, flatpak update picks it up. If not, download and install it first:

flatpak install --user --from https://hylki.hyprlab.co/flatpak/co.hyprlab.Hylki.Beta.flatpakref

RPM, Debian and AppImage betas: Beta channel.

@hyprlab hyprlab closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FLASH911 @hyprlab
0