Repository navigation
Conversation
hyprlab
added a commit
that referenced
this pull request
Nov 6, 2026
The toast overlay binds Escape, so one press closed the notice and the message still went. The key is now caught ahead of the overlay, which leaves the notice's close button hiding the notice only. Co-Authored-By: Fabio Rotondo <2844375+fsoft72@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While a message waits out its Undo Send delay, Esc now does the same as Undo.
Why
Esc is the natural key to back out of a send, but it did nothing for it. Pressing it once also closed the Undo toast without undoing, so the message still went out.
How
AdwToastOverlaycloses the toast on the first Esc before the window sees the key. The toast'sdismissedsignal now sendsAppMsg::UndoSend. This is a no-op once the message was dispatched or undone, because both take it off the held list before dismissing the toast.AppMsg::EscapeKeycovers the case where Esc reaches the window instead of the toast: it undoes the latest held send, else falls back toShortcut::BackToList. It is separate fromBackToListbecauseh,Leftandushare that shortcut and should not undo a send.docs/DOCUMENTATION.md(Undo Send) mentions the key.Testing
cargo checkpasses. Tried by hand: one Esc during the countdown brings the message back to the composer.🤖 Generated with Claude Code