Repository navigation
Conversation
Bcc recipients go to gpg as hidden recipients, so To and Cc cannot see whose keys were Bcc'd. A good signature from a key without the From address shows amber, not green. Encrypting to a key the keyring does not vouch for asks first in the composer, and each address is encrypted to the checked key by fingerprint, preferring a vouched one.
hyprlab
added a commit
that referenced
this pull request
Nov 6, 2026
Bcc recipients go to gpg as hidden recipients, so To and Cc cannot see whose keys were Bcc'd. A good signature from a key without the From address shows amber, not green. Encrypting to a key the keyring does not vouch for asks first in the composer, and each address is encrypted to the checked key by fingerprint, preferring a vouched one. Co-Authored-By: James Reilly <5840441+hanthor@users.noreply.github.com>
hyprlab
added a commit
that referenced
this pull request
Nov 6, 2026
gpg's trust line is the key's best validity, so an address added after a key was trusted passed as checked. Green now needs that address vouched for, and Trust covers it. The unchecked-key prompt came at every send and could not always be cleared: Send Anyway is remembered per address and fingerprint, Settings offers Trust for an added address, and trusting with an imported key of one's own now counts.
hyprlab
added a commit
that referenced
this pull request
Nov 6, 2026
Send Anyway was remembered with no way back short of editing a file. Settings → OpenPGP lists those keys while the answer still matters, and Ask Again takes it back. Removing a key forgets it too. The page reads again on each visit, since the composer changes the list while Settings sits hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three OpenPGP fixes:
--hidden-recipient, each resolved to the fingerprint of the checked key so gpg uses that key and not the first match for the address.PgpSignature::Goodgainsfrom_mismatch, serde-defaulted and skipped when false, so cache goldens don't change.--trust-model always, but the composer now asks before sending to a recipient whose key nothing vouches for (Send Anyway keeps it possible), andpublic_key_forprefers a vouched key when an address has several.Tests run against real throwaway gpg keyrings: the Bcc key id is zeroed in the packet and still decrypts, the From mismatch (case-insensitive), vouched-key choice per user id.