8000 fix(mfile): build the T26 test Layers with a Vec of loadouts · gominimal/minimal@113de2d · GitHub
[go: up one dir, main page]

Skip to content

fix(mfile): build the T26 test Layers with a Vec of loadouts

Minimal Arch / arch-review completed Nov 15, 2026

PASS_WITH_CONDITIONS

Baseline. This re-reviews 113de2d4 against the PASS_WITH_CONDITIONS on 65c4c4dc (this PR). The arch moves from 15b603e6 to 327e1b57. That arch change touches only the file-exports text (#180), so the governing lines did not change. Only their numbers moved: 1231–1234 became 1251–1253, and 1285–1286 became 1304. The checkout has no arch-map.md, so I found the sections by search, as the earlier rulings did.

Compare. since.diff is the merge 47112439 of main at 32b1f303 (T26 #3373, T27 #3439, T28 #3442, T46 #3436, and others) plus one PR commit, 113de2d4. That commit changes the T26 test's Layers to loadouts: Vec::new(). I compared the PR diff at 65c4c4dc (against bf655977) with pr.diff. They differ only in that fixture line. git show --cc 47112439 resolves expand(): the per-loadout layers stay after the entry and before the overrides, and check_project_declarers still runs before the fold. Main's new refuse_store_authorities now iterates the per-loadout origins, and layer_words names the loadout ``. The T26 projection does not read lifecycle_hooks, so `declared_by` does not reach the digest. The client does not yet compute a digest on create.

Governs. architecture.md line 1251 sets the order entry → selected loadouts → overrides. Line 1253 says project hooks run first, then each selected loadout's. Line 1304 makes the loadouts subject to loadout_mode. The change conforms.

Open. The two items the PR body names stay open, as C1 (#3302) and C2 (#3282, T129 #3409).

Observed, not ruled. crates/minimal/src/cmd/box_spec.rs calls expand() with no loadout layers, so min box spec shows declared_by on the project's hooks only. The task's diagnostics line expects more. That file is outside this diff and did not change since the baseline, so the baseline stands for it. C2 covers what min box spec shows.

Not checked. I did not build. The PR's verify run fails one test, otel_cli exec_run_attach_and_task_run_share_the_commands_trace. That test is outside the changed files, and I did not establish its cause.

Conditions

  • C1: crates/minimal/src/cmd/boxes/create.rs task_box_entry() passes the task's gated selected loadouts (the same set task_activation_inputs resolves) to box_entry() in place of SelectedLoadouts::default(), so an open task gets one loadout layer per loadout and the BOX-183 refusal before the create. Remove the Gap (BOX-183, issue #3302) comment when it lands. Tracked as #3302.
  • C2: The daemon stores the expanded spec that BoxEntryExpansion::spec carries, with declared_by on each hook, and min box spec shows it. Then remove the #[cfg_attr(not(test), allow(dead_code))] on BoxEntryExpansion::spec in crates/minimal/src/cmd/boxes/create.rs. Tracked as #3282 (T129, #3409).

Ruled at 113de2d against gominimal/arch@327e1b57d16b by claude-opus-5-5; arch_rulings 1311, job bafee834-86b4-48fe-8033-ed9b41101691.

0