8000 feat(mfile): T26 — Project the spec and digest it the same way in client and daemon by minimal-foundry[bot] · Pull Request #3373 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

feat(mfile): T26 — Project the spec and digest it the same way in client and daemon - #3373

Merged
mitodrummer merged 14 commits into
mainfrom
agent/2430-project-the-spec-and-digest-it-the-same-way-in-c
Nov 14, 2026
Merged

mitodrummer merged 14 commits into
mainfrom
agent/2430-project-the-spec-and-digest-it-the-same-way-in-c

Conversation

@minimal-foundry
@minimal-foundry minimal-foundry Bot commented Nov 13, 2026 •
Copy link
Copy Markdown
Contributor

T26 — Project the spec and digest it the same way in client and daemon

slice: S6
kind: task
covers: BOX-071, BOX-142
size: L
est: 460 code, 360 tests
executor: agent
difficulty: unknown ground
model: strongest
diagnostics: daemon log names both digests
observability: create span carries both digests
layers:
- projection:
- crates/mfile/src/projection.rs (new): projection and digest
- crates/mfile/src/lib.rs: mod line
- crates/mfile/src/expand.rs: secrets authorities; fills
- crates/mfile/Cargo.toml: digest dependencies
- Cargo.lock: new dependencies
test: cargo nextest run -p mfile projection_is_the_6_3_2_field_set
test: cargo nextest run -p mfile store_reference_upstream_and_inject_written_into_spec
test: cargo nextest run -p mfile expansion_fills_token_mode_quic443_steering_before_digest
test: cargo nextest run -p mfile enrolled_and_unenrolled_expansion_identical
- daemon:
- crates/minimald-rpc/src/lib.rs: carries client digest
- crates/minimald/src/box_manager.rs: stores both digests
- crates/minimald/src/box_manager/tests.rs: tests
test: cargo nextest run -p minimald projection_digests_stored_side_by_side
produces:
- crates/mfile/src/projection.rs
consumes:
- crates/mfile/src/expand.rs
proof: A created box's record holds both projection digests.
depends on:
- blocked by #2428
- blocked by #2410

Proof

When a box is created with a spec, its record attrs now hold two digests. projection_digest.client is the digest the client sent. projection_digest.daemon is the digest the daemon recomputed from the spec it received. Each is the base64url SHA-256 of the spec's §6.3.2 projection in JCS form. The box.create span and the daemon log name both. The test projection_digests_stored_side_by_side shows the two digests in the record for a matching client, a mismatched client and a client that sent none.

Notes from the agent: Design choices to review:

  1. The client digest travels in BoxConfig.attrs under minimald_rpc::CLIENT_PROJECTION_DIGEST_ATTR, with accessors on BoxConfig. A new struct field would break the struct literals in crates/minimald-rpc/src/tests.rs, and that file is outside the layers. The daemon stores its own digest under DAEMON_PROJECTION_DIGEST_ATTR, and drops that key when a client sends it.
  2. The fills (github grant mode from github_token_mode, else the root's built-in mode; quic443=auto; bep.steering=dns) happen in projection::project, and so in the client and in the daemon alike. They are not written into the expanded spec bytes. A first version wrote them into the spec, and minimal's tests::box_spec_renders_formats_secrets_as_refs failed, because it pins the min box spec output. That test is in crates/minimal/src/tests.rs, outside the layers. The design reasoning says "expansion fills". If the spec bytes must carry the filled values, a follow-up must change that test.
  3. Expansion now writes each source="store" reference's upstream ({hosts=[...]}) and inject from the new Layers::store_rules, keyed by the reference's id. A rule's optional store is not matched. A project-written upstream or inject is always dropped.
  4. My reading of §6.3.2, which I could not check against Gatehouse: v=1; ingress_ports is a list of {port, proto}, read from the box.toml list or from v0 port_mappings.internal_port; secret_grants is one object for each [secrets…[truncated]

Tests

line exit tail
cargo nextest run -p mfile projection_is_the_6_3_2_field_set 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile store_reference_upstream_and_inject_written_into_spec 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile expansion_fills_token_mode_quic443_steering_before_digest 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile enrolled_and_unenrolled_expansion_identical 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p minimald projection_digests_stored_side_by_side 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt

Verify

min task run agent-verify timed out after 1800s, so this PR is a draft.

HE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.737s] ( 767/1744) minimald env::tests::refresh_remaps_the_installed_set_onto_the_new_graph
        PASS [   0.779s] ( 768/1744) minimald env::tests::refresh_does_not_adopt_the_repos_top_levels
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1380.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1440.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

Residual: #3377, planned as T128 (#3387): crates/minimal/src/cmd/boxes/create.rs computes Expansion::projection(&resolved_type).digest() and calls BoxConfig::set_client_projection_digest on the create. Until it lands, a real create stores only the daemon digest.

Closes #2430

Add the Gatehouse §6.3.2 Box Spec projection and its digest: SHA-256
over the record's RFC 8785 JCS bytes, encoded base64url (BOX-071).

Expansion now writes each store reference's upstream and inject from
the client's [secret-store-rules], and fills the omitted github token
mode, network.quic443 and network.bep.steering before the projection.
Expansion takes no host enrollment input, so enrolled and un-enrolled
hosts expand to the same bytes and digest (BOX-142).
The create request carries the client's projection digest in its
attrs. The daemon recomputes the digest from the spec it received and
stores it beside the client's in the record (BOX-071). The create span
and the daemon log name both digests. A daemon digest that a client
sends is dropped.
Writing the filled quic443, steering and token mode into the expanded
spec changed the `min box spec` output that a minimal crate test pins.
The projection now fills them for the client and the daemon alike, so
the digest still binds the effective values and the spec bytes keep
only what a layer set.
@coderabbitai
coderabbitai Bot commented Nov 13, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: acbfbb7b-3739-4343-bf36-bb2581caaf5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 13, 2026 •
Copy link
Copy Markdown
Contributor Author

Reviewed: no findings; approval withheld, 12 threads unresolved at ea611e5dbebd.

APPROVE withheld: 12 unresolved threads — minimal-arch[bot] crates/mfile/src/projection.rs, minimal-arch[bot] crates/mfile/src/expand.rs, minimal-arch[bot] crates/mfile/src/expand.rs, minimal-arch[bot] crates/mfile/src/projection.rs:377, minimal-arch[bot] crates/mfile/src/projection.rs, …. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none found.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/mfile/src/expand.rs Resolved
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings: the coder changed nothing. Revise round 1: I made no code change, so this round has no commit. The one thread is invalid for this task. Its first claim describes behaviour that the spec requires. Its second claim is true, but the fix is outside the task's layers. Production clients do not fill Layers.store_rules from the client's [secret-store-rules], and they do not call set_client_projection_digest. That wiring is in crates/minimal/src/cmd/box_spec.rs and crates/minimal/src/cmd/boxes/create.rs. It needs a follow-up task with those files in its layers. Until it lands, the daemon stores only its own digest for boxes that min creates. I did not run the test: lines this round, because nothing changed.

Review threads the coder judged:

  • 👎 invalid — crates/mfile/src/expand.rs:387: The drop is what the spec requires. Its key table says a store reference's upstream and inject are written by expansion from the client's [secret-store-rules], never by the project (BOX-071). So expansion removes the values that the project file sets. The other half holds: no client fills store_rule

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 6 conditions · the full ruling

The daemon side conforms. It recomputes the digest, stores both digests in the record, and names them in the span and the log. The projection record does not match Gatehouse §6.3.2. secret_grants copies each entry's own keys and adds name (C1), and upstream is a {hosts} table where the design has a list (C2). ingress_ports holds objects (C4), and nesting copies the whole table (C5). Expansion drops a project-written upstream/inject, but box.toml lines 200–202 make it an exit-3 error (C3). The client never computes or sends its digest, so file that work as a residual with an issue (C6).

Ruled at beeeae4 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

Comment thread crates/mfile/src/projection.rs Outdated
Json::Object(map) => map,
other => BTreeMap::from([("value".to_owned(), other)]),
};
grant.insert("name".to_owned 10000 (), Json::Str(name.clone()));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · Section 6.3.2 lines 664-668 name the grant field env, not name. They also give a fixed key set for each kind of grant. Build each grant from those keys only. Do not copy the entry's own keys.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7eec2ca508d8: secret_grants() now builds each grant from its kind's §6.3.2 key set with the entry name as env: store refs carry env/source/store/id/upstream/inject, brokered grants env/scopes/mode, no source.

Comment thread crates/mfile/src/expand.rs Outdated
grant.insert(
"upstream".to_owned(),
toml::Value::Table(toml::Table::from_iter([(
"hosts".to_owned(),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C2 · The design writes upstream as a list of authorities (box.toml line 208, section 6.3.2 line 667). Write upstream = [..] here, not { hosts = [..] }. Change the store_secret() fixture in box_manager/tests.rs to the same shape.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7eec2ca508d8: write_store_authorities() writes upstream = [..] as a list of authorities. The store_secret() fixture in box_manager/tests.rs uses the same shape, and the test asserts it.

Comment thread crates/mfile/src/expand.rs Outdated
if grant.get("source").and_then(toml::Value::as_str) != Some("store") {
continue;
}
grant.remove("upstream");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C3 · box.toml lines 200-202 say that an entry that sets upstream or inject is a validation error (exit 3). Refuse it in expand() before this function runs, and remove this silent drop.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7eec2ca508d8: expand() now refuses a store reference that a layer gives upstream or inject (InvalidSpecKey, exit 3, names secrets..) before write_store_authorities(). The silent drop is removed.

/// spec's order. It reads the `box.toml` list of `{ proto, port }` and
/// the `port_mappings` of a v0 spec, whose port in the box is
/// `internal_port`.
fn ingress_ports(spec: &toml::Table) -> Json {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C4 · Section 6.3.2 line 657 gives "ingress_ports": [8080]. Project each port as its number, not as a { port, proto } object.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7eec2ca508d8: ingress_ports() projects each admitted port as its number. projection_is_the_6_3_2_field_set asserts [8080].

Comment thread crates/mfile/src/projection.rs Outdated
)]);

let commit = at(spec, &["upstream", "commit"]).and_then(toml::Value::as_str);
let nesting = match spec.get("nesting") {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C5 · Section 6.3.2 line 663 gives nesting as five bounds: allowed, max_depth, types, providers and dynamic_providers. Project only those keys. Do not copy the whole [nesting] table.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7eec2ca508d8: project() now projects nesting as exactly allowed, max_depth, types, providers and dynamic_providers. A test case shows that an extra [nesting] key leaves the digest unchanged.

/// `box_type` (BOX-071). Its [`digest`](crate::projection::Projection::digest)
/// is the one the client sends with the spec.
#[must_use]
pub fn projection(&self, box_type: &ResolvedType) -> crate::projection::Projection {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C6 · No client code calls this function or set_client_projection_digest, and the client Layers never sets store_rules. Section 6.3.2 line 649 says the client computes the projection. File that client work as an issue, and name it as a residual in the PR body.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7eec2ca508d8: The client half is outside this task's layers and is filed as #3377. It is to be named in the PR body as a residual of T26. No code change in this round.

@agent-137
Copy link
Copy Markdown
Member

/revise

Arch conditions (arch_rulings 1230, ruled at beeeae4), in full:

  • C1: crates/mfile/src/projection.rs secret_grants() builds each grant from the §6.3.2 key set only, not from the entry's own keys. Write the [secrets] entry name as env, and do not write name or value. A brokered (github:* or audience) grant carries env, scopes and mode (when set or filled), and no source. A source = "store" reference carries env, source, store, id, upstream as a list of authorities, and inject. Update projection_is_the_6_3_2_field_set and expansion_fills_token_mode_quic443_steering_before_digest (which looks up grants by name) to assert this exact key set.
  • C2: crates/mfile/src/expand.rs write_store_authorities() writes upstream as an array of the rule's authorities (upstream = ["registry.npmjs.org"]), not as the table { hosts = [...] }. Change the fixture store_secret() in crates/minimald/src/box_manager/tests.rs to the same shape, and change store_reference_upstream_and_inject_written_into_spec to assert it.
  • C3: crates/mfile/src/expand.rs expand() refuses, with an Error that the client reports as exit 3 and that names the secret and the key, any source = "store" entry for which a layer sets upstream or inject. Run this check before write_store_authorities(), and remove the grant.remove("upstream") / grant.remove("inject") drop from write_store_authorities(). Change the STORE_FILE case in store_reference_upstream_and_inject_written_into_spec to expect the refusal.
  • C4: crates/mfile/src/projection.rs ingress_ports() projects each admitted port as its port number ([8080]), not as a { port, proto } object. Update projection_is_the_6_3_2_field_set to assert the list of integers.
  • C5: crates/mfile/src/projection.rs project() projects nesting as exactly the five bounds allowed, max_depth, types, providers and dynamic_providers from the spec's [nesting], and drops any other key of that table, in place of Json::of_toml of the whole table. Add a case to projection_is_the_6_3_2_field_set that shows an extra [nesting] key leaves the digest unchanged.
  • C6: Add a residual with a linked gominimal/minimal issue to the PR body for the client half of BOX-071, which this task's layers leave undone. crates/minimal/src/cmd/boxes/create.rs sends a v0 mfile::spec::BoxSpec and never calls Expansion::projection or BoxConfig::set_client_projection_digest. Its Layers never sets store_rules. The issue covers three edits: send the expanded spec, fill Layers::store_rules from read_client_config_and_store_rules, and set set_client_projection_digest(expansion.projection(&resolved).digest()) on the create.

C6 is filed as #3377. Name it in the PR body as a residual of T26.

Build each secret grant from its kind's key set, with the entry name as
env. Project ingress ports as numbers and nesting as its five bounds.
Write a store reference's upstream as a list of authorities, and refuse
a layer that sets a store reference's upstream or inject (exit 3).
The design writes a store reference's upstream as a list of
authorities, so the fixture uses the same shape.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 7eec2ca508d8.

line exit tail
cargo nextest run -p mfile projection_is_the_6_3_2_field_set 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile store_reference_upstream_and_inject_written_into_spec 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile expansion_fills_token_mode_quic443_steering_before_digest 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile enrolled_and_unenrolled_expansion_identical 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p minimald projection_digests_stored_side_by_side 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt

Verify min task run agent-verify timed out after 1800s.

{1f}SCCACHE_ENDPOINT=https://4103a6df4dd77276970745a22603bea9.r2.cloudflarestorage.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.285s] ( 773/1747) minimald env::tests::task_entrypoint_relays_the_task_exit_code
        PASS [   0.903s] ( 774/1747) minimald env::tests::task_run_ignores_an_undeclared_value_that_is_not_utf8
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1380.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/mfile/src/projection.rs: secret_grants() now builds each grant from its kind's §6.3.2 key set with the entry name as env: store refs carry env/source/store/id/upstream/inject, brokered grants env/scopes/mode, no source.
  • 👍 valid — crates/mfile/src/expand.rs: write_store_authorities() writes upstream = [..] as a list of authorities. The store_secret() fixture in box_manager/tests.rs uses the same shape, and the test asserts it.
  • 👍 valid — crates/mfile/src/expand.rs: expand() now refuses a store reference that a layer gives upstream or inject (InvalidSpecKey, exit 3, names secrets..) before write_store_authorities(). The silent drop is removed.
  • 👍 valid — crates/mfile/src/projection.rs:377: ingress_ports() projects each admitted port as its number. projection_is_the_6_3_2_field_set asserts [8080].
  • 👍 valid — crates/mfile/src/projection.rs: project() now projects nesting as exactly allowed, max_depth, types, providers and dynamic_providers. A test case shows that an extra [nesting] key leaves the digest unchanged.
  • 👍 valid — crates/mfile/src/expand.rs:340: The client half is outside this task's layers and is filed as minimal: send the client's projection digest and store rules on create (BOX-071 client half) #3377. It is to be named in the PR body as a residual of T26. No code change in this round.

A created box's record holds both projection digests. The digest now covers the §6.3.2 record: each secret grant uses its kind's key set with the entry name as env, ingress ports are port numbers, nesting is its five bounds, and a store reference's upstream is a list of authorities. A minimal.toml that sets a store reference's upstream or inject is refused with exit 3.

Notes from the agent: Revise round 2, conditions C1 to C5 done. C6 is a PR-body item, and I cannot edit the PR body. Please name #3377 there as a residual of T26: the client half of BOX-071 (crates/minimal/src/cmd/boxes/create.rs sends no expanded spec, sets no Layers::store_rules and no client projection digest). C1: the code has no audience field. So a source = "store" entry gets the store key set (env, source, store, id, upstream, inject), and every other grant gets the brokered set (env, scopes, and mode when it is set or filled). A grant with no scopes projects scopes: [], a store reference with no rule projects upstream: [] and inject: null, and a nesting bound the spec does not set projects as null. C3: error.rs is outside the layers, so the refusal reuses Error::InvalidSpecKey with SpecKeyProblem::Unknown and key secrets.<name>.upstream or secrets.<name>.inject, which exits 3. Its printed text is " sets secrets.NPM.upstream, which is not a box setting. Remove the key or correct its name." That names the secret, the key and the fix. But "not a box setting" does not say that only the client's [secret-store-rules] can set the key. A dedicated SpecKeyProblem variant in error.rs can say that. I also fixed a Layers literal in the enrolled_and_unenrolled_expansion_identical helper that was missing three fields that the merge from main added. Without it, the mfile test build did not compile at the branch head. The full mfile suite passes (169 tests), and so do the minimald tests that use the store_secret() fixture. I did not run just clippy-strict.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 05:07
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimald/src/box_manager.rs Resolved
Comment thread crates/mfile/src/projection.rs Resolved
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The compare closes the earlier deviations. ingress_ports, nesting and secret_grants now have the shape that Gatehouse §6.3.2 gives. One gap remains: min never sends the client digest. Gatehouse §6.3.2 line 649 says the client and the node each compute the projection. No code in crates/minimal calls set_client_projection_digest, so a real create stores the daemon's digest alone. That work is outside this task's layers. Name it as a residual with its issue in the PR body, as C1 says.

Ruled at 7eec2ca against gominimal/arch@15b603e6afb8 by claude-opus-5-5.


/// Sets the projection digest the client computed for the spec it
/// sends (BOX-071).
pub fn set_client_projection_digest(&mut self, digest: impl Into<String>) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · No code in crates/minimal calls this setter. put_spec in crates/minimal/src/cmd/boxes/create.rs sends the spec with no digest. Gatehouse §6.3.2 line 649 says the client computes the projection too. Add a residual to the PR body with its issue for the client wiring.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disputed — not addressed: The finding is true, but the fix is outside this task's layers. The client call to set_client_projection_digest belongs in crates/minimal/src/cmd/boxes/create.rs (put_spec), and this task does not name that file. Until then the record holds the daemon digest alone. The client wiring needs its own follow-up task and a residual in the PR body.

A client value that is not 43 base64url characters is dropped from
the record, the span and the log, with a warning. The mfile doc on
SpecDigestError now says a null reads as an absent key.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as 4a44bad1b3ba.

line exit tail
cargo nextest run -p mfile projection_is_the_6_3_2_field_set 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile store_reference_upstream_and_inject_written_into_spec 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile expansion_fills_token_mode_quic443_steering_before_digest 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile enrolled_and_unenrolled_expansion_identical 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p minimald projection_digests_stored_side_by_side 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt

Verify min task run agent-verify timed out after 1800s.

{1f}SCCACHE_ENDPOINT=https://4103a6df4dd77276970745a22603bea9.r2.cloudflarestorage.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.257s] ( 774/1748) minimald env::tests::task_entrypoint_relays_the_task_exit_code
        PASS [   0.866s] ( 775/1748) minimald env::tests::task_run_ignores_an_undeclared_value_that_is_not_utf8
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1380.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/box_manager.rs: projection_digests now accepts a client digest only as 43 base64url characters. Any other value is dropped from the record attrs, the span and the log, with a warning that gives only its length. The test checks four malformed values.
  • 👍 valid — crates/mfile/src/projection.rs: Fixed the doc on SpecDigestError::NotATable. It now says a null in the spec is not this error, because spec_digest reads a null as an absent key, as its own doc already said.

A created box's record holds both projection digests: the daemon's, recomputed from the spec, and the client's when the client sent one in digest form.

Notes from the agent: Revise round 3. The daemon now stores a client projection digest only when it is 43 base64url characters. Any other value is removed from the record attrs, left out of the span and the log, and logged as a warning with its length only. The side-by-side test now uses a well-formed differing digest and checks four malformed values. The SpecDigestError::NotATable doc now matches the code: a null reads as an absent key. The residual from C6 (no client code computes or sends the digest yet) still stands. just clippy-strict was not run.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a failed check suite: the coder changed nothing. Revise round 4: no code change. All five test: lines pass at the merged head 4a44bad. The failed test-kvm check: the excerpt shows only the job's script text and post-job cleanup, and it names no failed test. This box has no /dev/kvm, so I did not run the VM harnesses. No harness under crates/minvmd/tests reads record attrs, the projection digests or the new log lines. The daemon change only adds attrs and a log line, and it never refuses a create. So I found no link from this diff to the failure. A person must read the full test-kvm log, or re-run the job, to see if it is a flake. ci-linux-kvm-success failed only because test-kvm failed. Thread C1 (client wiring): the fix is in crates/minimal/src/cmd/boxes/create.rs, which is outside this task's layers. It needs a follow-up task. Add that residual to the PR body; the runner writes the body, not me.

Review threads the coder judged:

  • 👎 invalid — crates/minimald-rpc/src/lib.rs:665: The finding is true, but the fix is outside this task's layers. The client call to set_client_projection_digest belongs in crates/minimal/src/cmd/boxes/create.rs (put_spec), and this task does not name that file. Until then the record holds the daemon digest alone. The client wiring needs its own fo

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Revise round 4 ran against ci-linux-kvm-success, test-kvm and left it red; a coder round cannot clear it, a person should look. No round was started for the failed suite on 4a44bad1b3ba.

@agent-137
Copy link
Copy Markdown
Member

/revise

Merge main into this branch and change nothing else. The only red check on 4a44bad is test-kvm hostname_allowlist_toolchain_completes (crates/minvmd/tests/egress_allowlist_integration.rs:481), which failed twice here and also fails intermittently on main (CI (Linux KVM) on 767d9be, 2026-11-13T15:54Z). This PR does not touch minvmd. The branch is from 06:00Z and main has moved since.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a /revise note: the coder changed nothing. every commit this round put on the branch above 4a44bad is a merge of the base branch, so it carries no work of its own

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 9 unresolved threads — minimal-arch[bot] crates/mfile/src/projection.rs, minimal-arch[bot] crates/mfile/src/expand.rs, minimal-arch[bot] crates/mfile/src/expand.rs, minimal-arch[bot] crates/mfile/src/projection.rs:377, minimal-arch[bot] crates/mfile/src/projection.rs, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The digest form check in 3267edf4 conforms. It keeps an untrusted client string out of the record and the log. Now a malformed client digest reads as none on the span and in ProjectionDigests, the same as a client that sent no digest. Gatehouse §6.3 check 5 and §6.3.2 line 672 treat a client and node that disagree as a refusal. BOX-072 must therefore know that the client sent a value. C1 records that state as malformed. C1 can stay open until BOX-072 lands. The client-side create call stays on residual #3377.

Ruled at 4a44bad against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

Comment thread crates/minimald/src/box_manager.rs Outdated
spec: Option<&serde_json_lenient::Value>,
verb_type: &str,
) -> ProjectionDigests {
let client = config
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · This filter turns a malformed client value into None, the same state as a client that sent no digest. Gatehouse §6.3 line 624 refuses a digest that differs from the daemon's. Keep a distinct Malformed state in ProjectionDigests. Record client_projection_digest = "malformed" on the span and in the log, not "none". Then BOX-072 can refuse it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7ffedf837e00: projection_digests() now maps a malformed client value to ClientDigest::Malformed. The span and the info log record client_projection_digest = "malformed", not "none".

Comment thread crates/minimald/src/box_manager.rs Outdated
/// received.
#[derive(Debug, Clone, Default, PartialEq, Eq)]
struct ProjectionDigests {
/// The client's digest, `None` when the client sent none.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · This doc says None means that the client sent no digest. After 3267edf4, None also means that the client sent a malformed value. Change the type or the doc so that the two states stay distinct (C1).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7ffedf837e00: The client fi 10BC8 eld is now a ClientDigest enum with Absent, Malformed and Digest states. Its doc says that the client sends a digest, or it gives the reason that there is none.

@agent-137
Copy link
Copy Markdown
Member

/revise

Arch condition (arch_rulings 1260, ruled at 4a44bad), in full:

  • C1: crates/minimald/src/box_manager.rs: keep a client value that is not in digest form as its own state in ProjectionDigests, set in projection_digests() (for example a client_malformed: bool field, or an enum for client with Absent, Malformed and Digest(String)). ProjectionDigests::record() then writes client_projection_digest = "malformed" on the box.create span and in the info log, not "none". Correct the client field doc, which says None only when the client sent none. The raw value stays out of the record, the span and the log, as the compare intends. This lets BOX-072 refuse a malformed value as a differing digest and not accept it as a client that predates the key. It can merge open, because nothing refuses on the digest yet.

A client projection digest that is not in digest form is now its own state, so BOX-072 can refuse it as a differing digest. The raw value stays out of the record, the span and the log.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 6 of 10 on a /revise note, pushed as 7ffedf837e00.

line exit tail
cargo nextest run -p mfile projection_is_the_6_3_2_field_set 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile store_reference_upstream_and_inject_written_into_spec 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile expansion_fills_token_mode_quic443_steering_before_digest 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile enrolled_and_unenrolled_expansion_identical 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p minimald projection_digests_stored_side_by_side 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt

Verify min task run agent-verify timed out after 1800s.

WD=/tmp/.tmpsNA1SP/some dir\u{1f}RUSTC_WRAPPER=sccache\u{1f}SCCACHE_BUCKET=agent-runtime-sccache-gominimal-minimal\u{1f}SCCACHE_ENDPOINT=https://4103a6df4dd77276970745a22603bea9.r2.cloudflarestorage.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.019s] ( 774/1754) minimald env::tests::task_entrypoint_drops_ignored_vars
        PASS [   0.319s] ( 775/1754) minimald env::tests::task_entrypoint_relays_the_task_exit_code
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1320.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimald/src/box_manager.rs: projection_digests() now maps a malformed client value to ClientDigest::Malformed. The span and the info log record client_projection_digest = "malformed", not "none".
  • 👍 valid — crates/minimald/src/box_manager.rs: The client field is now a ClientDigest enum with Absent, Malformed and Digest states. Its doc says that the client sends a digest, or it gives the reason that there is none.

A created box's record holds the client's projection digest beside the daemon's. A client value that is not in digest form is kept out of the record, and the create span and the daemon log name it as "malformed", not "none".

Notes from the agent: Round 6 addresses arch condition C1. ProjectionDigests.client is now a ClientDigest enum with the values Absent, Malformed and Digest(String). record() writes "malformed" for a malformed value, and the raw value stays out of the record, the span and the log. The test now checks the "malformed" log line and checks that the raw value is not in the log. cargo clippy -p minimald --all-targets is clean. The client wiring is still a residual from earlier rounds: no code in crates/minimal sends the digest yet.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 13, 2026 19:36
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The projection matches the Gatehouse §6.3.2 field set and digest, and the new ClientDigest::Malformed state correctly fails closed. One deviation stays open from the earlier heads. Section 6.3.2 line 672 says expansion fills the grant mode, quic443 and steering. This change fills them only inside projection::project, so the expanded spec bytes do not carry them. C1 moves the fill into expand and updates the pinned min box spec test. You can merge with C1 open when its issue is filed and named in the PR body.

Ruled at 7ffedf8 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

// BOX-071: the store references carry the client's authorities, so
// the daemon projects the same `secret_grants` from the spec it
// receives. The omitted values the digest binds are filled by the
// projection itself (`projection::fill_effective`), in the client and
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · Section 6.3.2 line 672 says expansion fills the grant mode, quic443 and steering before canonicalization. Here the fill happens only in projection::project, so the spec bytes do not carry it. Call projection::fill_effective(&mut expansion.spec, root) after write_store_authorities, and replace this comment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disputed — not addressed: BOX-071 says to fill before the projection is canonicalised so that the digest binds the effective values. projection::project runs fill_effective in both the client and the daemon, and fill_effective is idempotent, so both digests bind auto/dns/the token mode. Writing the fill into the spec bytes changes the min box spec output that a crates/minimal test pins. That file is outside this task's layers, so commit cfbbf30 moved the fill into the projection.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/mfile/src/projection.rs Resolved
The daemon's admission check reads only box.type. A flat type string
made the digest name a type that admission never checked.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 7 of 10 on the runtime's review findings, pushed as 9e053ff7fafa.

line exit tail
cargo nextest run -p mfile projection_is_the_6_3_2_field_set 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile store_reference_upstream_and_inject_written_into_spec 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile expansion_fills_token_mode_quic443_steering_before_digest 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile enrolled_and_unenrolled_expansion_identical 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p minimald projection_digests_stored_side_by_side 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt

Verify min task run agent-verify exited 100.

bles::tests::entry_only_package_contributes_its_state_wiring
        PASS [   0.049s] ( 420/1754) minimald box_manager::create_stamp_tests::create_assigns_uuidv7_id_type_and_parent
        PASS [   0.468s] ( 421/1754) minimald box_manager::composables::tests::multi_component_state_wiring_prefix_errors
        PASS [   0.050s] ( 422/1754) minimald box_manager::create_stamp_tests::create_records_project_root
        PASS [   0.062s] ( 423/1754) minimald box_manager::create_stamp_tests::create_stores_the_spec_beside_the_record
        PASS [   0.053s] ( 424/1754) minimald box_manager::create_stamp_tests::get_box_spec_returns_stored_spec
        PASS [   0.056s] ( 425/1754) minimald box_manager::create_stamp_tests::legacy_create_path_records_type_from_creating_verb
        PASS [   0.026s] ( 426/1754) minimald box_manager::host_ip_mint_name_tests::host_ip_box_record_takes_the_registration_id_never_for_a_row_box
        PASS [   0.021s] ( 427/1754) minimald box_manager::host_ip_mint_name_tests::host_ip_box_record_takes_the_registration_id_of_a_grant_box
        PASS [   0.021s] ( 428/1754) minimald box_manager::host_ip_mint_name_tests::host_ip_box_record_takes_the_registration_id_only_with_a_grant
        PASS [   0.018s] ( 429/1754) minimald box_manager::host_ip_mint_name_tests::host_ip_box_record_takes_the_registration_key_only_for_its_own_fresh_base
        FAIL [   4.011s] ( 430/1754) minimald box_actor::tests::until_complete_timeout_terms_then_kills_box_and_execs_reason_timeout
  stdout ───

    running 1 test
    test box_actor::tests::until_complete_timeout_terms_then_kills_box_and_execs_reason_timeout ... FAILED

    failures:

    failures:
        box_actor::tests::until_complete_timeout_terms_then_kills_box_and_execs_reason_timeout

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 1476 filtered out; finished in 3.98s

  stderr ───

    thread 'box_actor::tests::until_complete_timeout_terms_then_kills_box_and_execs_reason_timeout' (7434) panicked at crates/minimald/src/box_actor/tests.rs:17721:5:
    assertion `left == right` failed: []
      left: 0
     right: 1
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.447s] ( 431/1754) minimald box_manager::composables::tests::state_wiring_composition_matches_setup_for_packages
        PASS [   0.529s] ( 432/1754) minimald box_manager::ended_box_tests::ended_box_refuses_a_box_whose_delete_has_started
        PASS [   0.895s] ( 433/1754) minimald box_manager::tests::a_cleanup_destroy_keeps_a_finished_session
────────────
     Summary [ 122.338s] 433/1754 tests run: 432 passed, 1 failed, 27 skipped
        FAIL [   4.011s] ( 430/1754) minimald box_actor::tests::until_complete_timeout_terms_then_kills_box_and_execs_reason_timeout
warning: 1321/1754 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👎 invalid — crates/mfile/src/expand.rs:396: BOX-071 says to fill before the projection is canonicalised so that the digest binds the effective values. projection::project runs fill_effective in both the client and the daemon, and fill_effective is idempotent, so both digests bind auto/dns/the token mode. Writing the fill into the spec bytes c
  • 👍 valid — crates/mfile/src/projection.rs:114: TypeFacts::of_spec now reads only box.type, else the default type, the same rule as spec_type_root. Added a test that a flat type string is ignored.

A created box's record holds both projection digests: the client's and the daemon's. The daemon now computes its digest for the same type that admission checks.

Notes from the agent: Round 7. The mfile test lines ran in one nextest invocation together with type_facts_of_spec_reads_box_type_and_root, and all passed. I did not run just ci or clippy-strict. The expand.rs fill thread is judged invalid. The fill stays in projection::fill_effective, which the client and the daemon both run before canonicalisation. A filled spec changes the min box spec output that a crates/minimal test pins, and that file is outside this task's layers (see commit cfbbf30). If the plan wants the filled values in the spec bytes too, a task that owns crates/minimal must update that test.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 8 of 10 on a failed check suite: the coder changed nothing. Round 8 changed nothing, so noop is true. Failed check 'tests': the job excerpt does not name the failing test. I ran the full mfile suite (169 passed) and the full minimal and minimald-rpc suites (1211 passed). I ran the full minimald suite: 1491 passed. One test failed (env::tests::task_entrypoint_carries_env_cwd_and_args) and two hung (env::tests::minenv_run_forwards_stdin_to_the_task, env::tests::task_run_pipes_stdin_through_the_in_box_helper). All three are in crates/minimald/src/env.rs, which this branch does not change. They pass when MINIMAL_OTEL is unset. This box sets MINIMAL_OTEL=off, and the test does not expect the otel prefix in the request. So the cause is the environment of this box, not the branch. I did not run a workspace-wide test, because no test: line names one. The CI failure can be a test outside these crates or a flaky test. A person must read the full job log to name it. Doctests: rustdoc is not on this box, so cargo test --doc did not run. Failed …[truncated]

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Revise round 8 ran against ci-linux-native-success, tests, commitlint and left it red; a coder round cannot clear it, a person should look. No round was started for the failed suite on 9e053ff7fafa.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The compare conforms. TypeFacts::of_spec now reads the type from box.type only. The Box Spec carries the type there (box.toml lines 12–27), and admission reads only that key. Thus the digest names the type that admission checked (§6.3.2 line 672). The rest of the projection holds as it did on 7ffedf83. The one open item is C1: the min create path must send the client digest. #3377 tracks C1, and the merge can go ahead with C1 open. The agent-verify leg timed out after a test failure. That leg is open, and a person must check it before merge.

Ruled at 9e053ff against gominimal/arch@15b603e6afb8 by claude-opus-5-5.


/// Sets the projection digest the client computed for the spec it
/// sends (BOX-071).
pub fn set_client_projection_digest(&mut self, digest: impl Into<String>) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · No caller in min uses this setter yet. A real create stores only projection_digest.daemon. Call it from crates/minimal/src/cmd/boxes/create.rs with the client projection digest (#3377, T128). Gatehouse §6.3.2 line 649 says the client and the node each compute the projection.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disputed — not addressed: The client call belongs in crates/minimal/src/cmd/boxes/create.rs, and this task's layers do not name that file. The client wiring is a residual for its own issue (#3377), as the earlier reply on this line says.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment on lines +4496 to +4501
let digests = projection_digests(&config, spec.as_ref(), verb_type);
// A client value that is not a digest in form is not stored.
if !matches!(digests.client, ClientDigest::Digest(_)) {
config
.attrs
.remove(minimald_rpc::CLIENT_PROJECTION_DIGEST_ATTR);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW · correctness · confidence 0.50 · in create_session

A client digest in form is stored even when the create carries no spec, or when the daemon computed no digest. The record then holds a client digest with no daemon digest to compare. Drop the client key in that case too, or record why it is kept.

What the reviewer checked

if !matches!(digests.client, ClientDigest::Digest(_)) { remove } -- no check on digests.daemon

Hand this to an agent
Act on a code-review finding.

File:       crates/minimald/src/box_manager.rs
Lines:      4496-4501
Category:   correctness
Severity:   low (reviewer confidence 0.50)

Finding:
A client digest in form is stored even when the create carries no spec, or when the daemon computed no digest. The record then holds a client digest with no daemon digest to compare. Drop the client key in that case too, or record why it is kept.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in ea611e5dbebd: create_session now removes the client key when the daemon has no digest. The test asserts that a create with no spec stores neither digest.

A create with no spec, or a spec the daemon cannot project, has no
daemon digest. The record then drops the client key too, so it never
holds a client digest with nothing to compare. The log still names it.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 9 of 10 on the runtime's review findings, pushed as ea611e5dbebd.

line exit tail
cargo nextest run -p mfile projection_is_the_6_3_2_field_set 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile store_reference_upstream_and_inject_written_into_spec 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile expansion_fills_token_mode_quic443_steering_before_digest 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p mfile enrolled_and_unenrolled_expansion_identical 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt
cargo nextest run -p minimald projection_digests_stored_side_by_side 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network warning: unknown fields in task runt

Verify min task run agent-verify timed out after 1800s.

_ROOT=/workbench\u{1f}PATH=/tmp/.tmphCRV6w/replybin:/usr/bin:/bin:/usr/sbin:/sbin:/home/.local/bin\u{1f}PWD=/tmp/.tmphCRV6w/some dir\u{1f}RUSTC_WRAPPER=sccache\u{1f}SCCACHE_BUCKET=agent-runtime-sccache-gominimal-minimal\u{1f}SCCACHE_ENDPOINT=https://4103a6df4dd77276970745a22603bea9.r2.cloudflarestorage.com\u{1f}SCCACHE_REGION=auto\u{1f}SCCACHE_S3_USE_SSL=true\u{1f}SHELL=/usr/bin/bash\u{1f}SHLVL=2\u{1f}SSL_CERT_DIR=/etc/ssl/certs\u{1f}SSL_CERT_FILE=/etc/ssl/cert.pem\u{1f}XDG_CACHE_HOME=/state/cache\u{1f}XDG_CONFIG_HOME=/home/.config\u{1f}XDG_DATA_HOME=/home/.local/share\u{1f}XDG_RUNTIME_DIR=/run\u{1f}XDG_STATE_HOME=/home/.local/state\u{1e}stdin\n"
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   0.819s] ( 774/1754) minimald env::tests::search_finds_known_package
        PASS [   0.451s] ( 775/1754) minimald env::tests::task_entrypoint_relays_the_task_exit_code
        SLOW [> 60.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>120.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>180.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>240.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>300.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>360.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>420.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>480.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>540.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>600.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>660.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>720.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>780.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>840.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>900.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>960.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1020.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1080.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1140.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1200.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task
        SLOW [>1260.000s] (─────────) minimald env::tests::minenv_run_forwards_stdin_to_the_task

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👎 invalid — crates/minimald-rpc/src/lib.rs:665: The client call belongs in crates/minimal/src/cmd/boxes/create.rs, and this task's layers do not name that file. The client wiring is a residual for its own issue (minimal: send the client's projection digest and store rules on create (BOX-071 client half) #3377), as the earlier reply on this line says.
  • 👍 valid — crates/minimald/src/box_manager.rs:4501: create_session now removes the client key when the daemon has no digest. The test asserts that a create with no spec stores neither digest.

A box created with a spec has a record that holds the daemon's recomputed projection digest beside the client's digest. The record stores the client's digest only when it is in digest form and a daemon digest is present.

Notes from the agent: This round adds one commit, ea611e5. A create that has no daemon digest (no spec, or a spec that the daemon cannot project) now drops the client key. The test covers the no-spec case. The client wiring in crates/minimal/src/cmd/boxes/create.rs is outside this task's layers and is still a residual for its own issue.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 14, 2026 00:11
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The new commit conforms. The record now stores a client digest only when the daemon also has a digest. Architecture line 21 binds the record's projection digest to its expanded spec. The span and the log still name both values. One item stays open: min does not send the client digest on a real create. Gatehouse §6.3.2 line 649 requires both sides to compute it. C1 keeps it as residual #3377.

Ruled at ea611e5 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 12 unresolved threads — minimal-arch[bot] crates/mfile/src/projection.rs, minimal-arch[bot] crates/mfile/src/expand.rs, minimal-arch[bot] crates/mfile/src/expand.rs, minimal-arch[bot] crates/mfile/src/projection.rs:377, minimal-arch[bot] crates/mfile/src/projection.rs, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@agent-137
agent-137 marked this pull request as ready for review November 14, 2026 02:37
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 396f001 Nov 14, 2026
38 of 39 checks passed
@mitodrummer
mitodrummer deleted the agent/2430-project-the-spec-and-digest-it-the-same-way-in-c branch November 14, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T26 — Project the spec and digest it the same way in client and daemon

2 participants

0