8000 T129 — The daemon stores the expanded spec with each hook's declarer, and composes from it · Issue #3409 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T129 — The daemon stores the expanded spec with each hook's declarer, and composes from it #3409

Open

Description

@agent-137

Task

slice size difficulty model who estimated lines
Projection and digest L needs care strongest an agent 620 (300 code, 320 tests)

The daemon stores the expanded spec that the client sends, with each lifecycle hook and its declared_by, and composes the box's project items from that stored spec. Then spec.json holds each hook with its declarer, and the daemon no longer reads [stack] and [session] from minimal.toml itself.

Covers: none. BOX-068 (T5) and BOX-179 (T127) own the behaviour. This task makes the stored spec carry it.

This task does the work #3282 and #3257 track:

Layers:

  • spec:
    • crates/mfile/src/spec.rs: the stored spec carries lifecycle_hooks, each with its declared_by table (kind, and name for a loadout)
  • daemon:
    • crates/minimald/src/box_manager.rs: the create stores the expanded spec it receives, hooks and declarers included, as spec.json
    • crates/minimald/src/box_manager/composables.rs: build_composables composes the project's items from the stored expanded spec, and stops reading [stack] and [session] from minimal.toml
    • crates/minimald/src/box_manager/tests.rs: tests
    • cargo nextest run -p minimald stored_spec_keeps_each_hook_with_its_declarer_in_spec_json
    • cargo nextest run -p minimald composes_from_stored_expanded_spec_not_minimal_toml
  • wire:
    • crates/boxes/src/wire/request.rs: remove WireContribution::entry and WireBoxEntry, which the expanded spec replaces
  • client:
    • crates/minimal/src/cmd/boxes/create.rs: send the expanded spec with each hook's declared_by, in place of the five-list entry
    • crates/minimal/src/tests.rs: tests
    • cargo nextest run -p minimal created_box_spec_json_names_each_hook_declarer

created_box_spec_json_names_each_hook_declarer creates a box whose entry declares one hook and whose loadout dev declares another. It reads the box's spec.json back through the in-process daemon, and checks one hook with { kind = "project" } and one with { kind = "loadout", name = "dev" }.

User-facing text. This task adds no message.

Observability. The daemon log names the box and the number of hooks it stored at creation.

Owner decisions this task follows:

Plan block
### T129 — The daemon stores the expanded spec with each hook's declarer, and composes from it
  slice: S6
  kind: integration
  covers: none
  size: L
  est: 300 code, 320 tests
  executor: agent
  difficulty: needs care
  model: strongest
  diagnostics: the daemon log names the box and how many hooks it stored
  observability: spec.json holds each hook with its declared_by
  layers:
    - spec:
      - crates/mfile/src/spec.rs: the stored spec carries lifecycle_hooks with declared_by
    - daemon:
      - 
8000
crates/minimald/src/box_manager.rs: store the received expanded spec as spec.json
      - crates/minimald/src/box_manager/composables.rs: compose from the stored spec, not minimal.toml
      - crates/minimald/src/box_manager/tests.rs: tests
      test: cargo nextest run -p minimald stored_spec_keeps_each_hook_with_its_declarer_in_spec_json
      test: cargo nextest run -p minimald composes_from_stored_expanded_spec_not_minimal_toml
    - wire:
      - crates/boxes/src/wire/request.rs: remove WireContribution::entry and WireBoxEntry
    - client:
      - crates/minimal/src/cmd/boxes/create.rs: send the expanded spec with each hook's declared_by
      - crates/minimal/src/tests.rs: tests
      test: cargo nextest run -p minimal created_box_spec_json_names_each_hook_declarer
  produces: none
  consumes:
    - crates/mfile/src/expand.rs
  proof: create a box with a project hook and a loadout hook, and read spec.json back with both declarers, while the daemon composes the box from that stored spec.
  depends on:
    - blocked by #3311
    - blocked by #3387

When this task merges, the work #3282 and #3257 track is done. Close both by hand.

Activity

  1. agent-137 commented on Nov 14, 2026

    @agent-137
    MemberAuthor

    Scope addition from arch_rulings 1302 C1 on #3441 (T128): the expanded spec this task sends and stores must include [secrets], with each source = "store" reference's upstream and inject written from the client's [secret-store-rules]. That needs crates/mfile/src/spec.rs (SpecDoc and BoxSpec accept [secrets]), the creation path in minimald, and session_box_entry/task_box_entry. Then the projection digest binds the secret grants. Until this lands, T128's client digest binds no secret grants.

  2. minimal-foundry commented on Nov 16, 2026

    @minimal-foundry
    Contributor

    Round 2 of 10 changed nothing: No-op. The directive asks for a merge of origin/main. That merge is already on the branch: merge commit 192c820 brought in f7b6e36 (#3433), and origin/main has no commits that HEAD does not have. A fresh fetch was not possible because the remote refused the connection, so I checked the local origin/main only. A new merge commit with no change is an empty commit, so I made none. The branch head stays 714cfc1. That head already differs from f594dab, the head where the arch review did not run, so a review of 714cfc1 can run without a new commit. All three test lines pass.. #3461 is still open.

    branch agent/3409-the-daemon-stores-the-expanded-spec-with-each-ho · epic #2236 · PR #3461

    round outcome job
    1 pushed b0fe3c09
    2 changed nothing: No-op. The directive asks for a merge of origin/main. That merge is already on the branch: merge commit 192c820 brought in f7b6e36 (#3433), and origin/main has no commits that HEAD does not have. A 0f7f22cc

    Updated 2026-11-16T07:34:24.812Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0