8000 docs(specs): read BOX's local0 and local-minvmd0 as hosts, per arch#45's ruling by mitodrummer · Pull Request #2662 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

docs(specs): read BOX's local0 and local-minvmd0 as hosts, per arch#45's ruling - #2662

Merged
mitodrummer merged 1 commit into
mainfrom
docs/box-local-provider-hosts
Oct 27, 2026
Merged

mitodrummer merged 1 commit into
mainfrom
docs/box-local-provider-hosts

Conversation

@mitodrummer
@mitodrummer mitodrummer commented Oct 27, 2026 •
Copy link
Copy Markdown
Member

gominimal/arch#45 ruled on 2026-10-27 (comment) that there is one local provider per deployment style, local, local-minvmd and local-box, and that the 0..N suffix names hosts.

BOX's requirements already say "on local0" and "on local-minvmd0" as hosts, so they stay. This changes the three places that read them as providers:

  • The design-reasoning heading "exercised on the two local providers" now names local0 and local-minvmd0 as the first hosts of local and local-minvmd.
  • The S16 non-goal: the daemons serve the local providers over their Unix sockets, and BPA, which the ruling moves into this repository, specifies them.
  • The moved-out paragraph: the obligations follow the ruling and belong to BPA.

Companion to #1991, whose BCLI-046 now names the providers and hosts. The prose lint adds no alerts on the changed lines, and the S16 non-goal line drops its two.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw

Summary by CodeRabbit

  • Documentation
    • Updated the local Box specification to reflect the Unix socket decision for provider daemons, identify the two test hosts, and note that the BPA requirements specification is now in this repository.

…5's ruling

gominimal/arch#45 ruled on 2026-10-27 that there is one local provider
per deployment style (local, local-minvmd, local-box) and that the 0..N
suffix names hosts. BOX's requirements already say "on local0" and "on
local-minvmd0" as hosts; the design-reasoning heading that called them
the two local providers now names them as the first hosts of local and
local-minvmd. The S16 non-goal and the moved-out paragraph record the
ruling: the daemons serve the providers over their sockets, and BPA,
moving into this repository, specifies them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw
@mitodrummer
mitodrummer requested a review from a team as a code owner October 27, 2026 03:40
@coderabbitai
coderabbitai Bot commented Oct 27, 2026 •
Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

< 8000 /picture> Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: d0790a97-2f8b-448d-91f8-fcb15b0c728c
Commits

Reviewing files that changed from the base of the PR and between dbba22b and c2d65e3.

Files selected for processing: 1
  • docs/specs/29-spec-box-local-first/29-spec-box-local-first.md

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The BOX local-first specification records the Unix socket decision for local providers and names local0 and local-minvmd0 as test hosts. The document’s updated date changes to 2026-10-27.

Changes: BOX local-first specification

Layer / File(s) Summary
Provider decisions and host model
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md
The specification records that daemons serve providers over Unix sockets, identifies the BPA requirements spec, and names local0 and local-minvmd0 as test hosts.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

  • gominimal/minimal issue 2236: The specification now identifies local0 and local-minvmd0 as hosts of local and local-minvmd.
  • gominimal/inbox issue 1153: The specification identifies local-minvmd0 as a VM host.

Suggested reviewers: norrietaylor

Merge Risk: Minimal · up to c2d65

The specification update aligns the provider and host terminology with the stated architecture ruling.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the documentation change and its alignment with arch#45’s ruling. It uses a suitable Conventional Commit format and remains concise.
Description check Passed The description clearly explains the change, rationale, affected specification sections, related work, and testing result. It omits the template’s explicit Summary, Testing, and Checklist headings, bu…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the change, rationale, affected specification sections, related work, and testing result. It omits the template’s explicit Summary, Testing, and Checklist headings, but the required information is mostly present.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Vale (3.24.0)

{
"Line": 13,
"Path": ".vale.ini",
"Text": "Style 'ste' isn't on the StylesPath (/styles). If it's a package, run vale sync.",
"Code": "E201",
"Span": 23
}

A rabbit reads the host names clear,
local0 hops into the spec,
local-minvmd0 joins the trail,
Unix sockets mark the way,
The dates turn softly to October,
And carrots celebrate the change.

Comment @coderabbitai help to get the list of available commands.

@github-actions
Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/29-spec-box-local-first/29-spec-box-local-first.md — 66 finding(s)

docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:62: P004 BOX-002 names test 'vm_host_mints_box_id_before_in_vm_create', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:72: P004 BOX-004 names test 'name_unique_among_running_on_host_reusable_after_stop', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:77: P004 BOX-163 names test 'create_names_box_from_box_name_else_entry', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:87: P004 BOX-005 names test 'unqualified_name_resolves_running_else_latest', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:98: P004 BOX-007 names test 'self_as_name_is_exit3', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:102: P004 BOX-010 names test 'rename_changes_only_alias_and_records_event', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:131: P004 BOX-154 names test 'restart_sets_orphaned_running_record_stopped_without_signal', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:135: P004 BOX-013 names test 'stop_sends_term_then_kill_and_records_exited_stopped_with_signal', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:142: P004 BOX-015 names test 'daemon_never_stops_for_idle_or_client_loss', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:146: P004 BOX-016 names test 'pty_client_loss_records_detach', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:150: P004 BOX-017 names test 'stopped_box_filesystem_served_by_cp', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:154: P004 BOX-018 names test 'stopped_box_record_readable_until_reaped', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:158: P004 BOX-019 names test 'rm_deletes_record_and_filesystem', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:168: P004 BOX-021 names test 'prune_selectors_reap_and_print', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:172: P004 BOX-024 names test 'no_automatic_reaper_runs', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:176: P004 BOX-025 names test 'resume_restarts_from_stored_spec_same_id_and_name', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:186: P004 BOX-027 names test 'resume_runs_only_on_attach_hook', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:190: P004 BOX-028 names test 'hooks_on_resume_reruns_on_activate', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:194: P004 BOX-030 names test 'pty_box_resumes_from_stopped_and_exited', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:201: P004 BOX-037 names test 'until_complete_timeout_terms_then_kills_box_and_execs_reason_timeout', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:205: P004 BOX-038 names test 'until_complete_ends_on_entrypoint_return_without_client', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:209: P004 BOX-155 names test 'box_output_logged_from_start_complete_after_disconnect', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:213: P004 BOX-040 names test 'events_written_outside_box_filesystem_with_box_parent_ts_type', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:217: P004 BOX-041 names test 'in_box_root_cannot_append_events', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:221: P004 BOX-164 names test 'in_box_root_cannot_write_record_or_log', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:225: P004 BOX-045 names test 'events_survive_stop_deleted_on_rm', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:229: P004 BOX-162 names test 'events_read_returns_full_retained_stream_in_order', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:236: P004 BOX-158 names test 'list_returns_every_retained_record_with_state', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:243: P004 BOX-159 names test 'show_returns_record_state_identity_and_live_execs', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:250: P004 BOX-046 names test 'type_noun_tables_are_boxes_sugar', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:257: P004 BOX-048 names test 'defaults_merge_lists_union_scalars_replace', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:262: P004 BOX-049 names test 'flat_per_entry_keys_and_legacy_keys_keep_meaning', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:266: P004 BOX-050 names test 'legacy_session_table_reads_as_defaults_session_with_hint', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:273: P004 BOX-165 names test 'no_session_entry_expands_implicit_default_session', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:280: P004 BOX-051 names test 'legacy_defaults_task_keys_with_hint', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:284: P004 BOX-052 names test 'legacy_params_reads_as_args_with_hint', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:288: P004 BOX-054 names test 'interactive_task_exit3_names_session', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:292: P004 BOX-059 names test 'box_type_resolves_to_builtin_root', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:301: P004 BOX-061 names test 'expanded_spec_violating_constraint_exit3_names_type_and_layer', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:306: P004 BOX-156 names test 'derived_type_loosening_constraint_exit3_names_type_key_parent', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:311: P004 BOX-160 names test 'admission_refuses_spec_breaching_builtin_root_constraint_exit3', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:315: P004 BOX-062 names test 'constraint_never_adds_package_port_or_egress', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:320: P004 BOX-063 names test 'session_and_task_entries_expand_and_validate', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:327: P004 BOX-064 names test 'expansion_order_and_merge_rules', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:332: P004 BOX-065 names test 'expansion_is_byte_identical_across_runs', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:337: P004 BOX-066 names test 'invalid_key_exit3_names_key_and_layer', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:341: P004 BOX-161 names test 'expansion_reports_layer_and_type_per_value_outside_spec_bytes', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:352: P004 BOX-071 names test 'projection_is_the_6_3_2_field_set', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:366: P004 BOX-072 names test 'projection_digest_mismatch_refuses_create', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:371: P004 BOX-073 names test 'unenrolled_evaluates_no_policy', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:375: P004 BOX-074 names test 'get_version_reports_expander_version', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:382: P004 BOX-145 names test 'example_expansion_matches_golden_vectors', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:386: P004 BOX-076 names test 'sections_follow_box_toml_with_nested_egress', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:408: P004 BOX-079 names test 'network_mode_legacy_spelling_hint_and_canonical_value', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:412: P004 BOX-157 names test 'flat_egress_keys_hint_and_canonical_nested_keys', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:416: P004 BOX-080 names test 'network_bep_secrets_passed_unchanged', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:423: P004 BOX-081 names test 'broker_secret_unenrolled_exit5', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:427: P004 BOX-085 names test 'params_accepted_and_rendered', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:439: P004 BOX-149 names test 'exec_runs_argv_unshelled_in_box_namespaces_and_cgroup', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:467: P004 BOX-151 names test 'stop_exec_ends_process_group', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:472: P004 BOX-152 names test 'exec_events_carry_principal_argv_pty_code', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:477: P004 BOX-153 names test 'exec_disabled_refuses_exit5', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:484: P004 BOX-140 names test 'unenrolled_operations_over_file_mode_trust', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:488: P004 BOX-141 names test 'store_secret_passed_through_unenrolled', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:492: P004 BOX-142 names test 'enrolled_and_unenrolled_expansion_identical', which was not found in the repository
docs/specs/29-spec-box-local-first/29-spec-box-local-first.md:497: P004 BOX-143 names test 'nothing_keys_on_box_name', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@fb5932b8, spec format: How Minimal Writes Specs.

@minimal-foundry
minimal-foundry Bot commented Oct 27, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at c2d65e312b2b.

Nothing to do.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 27, 2026
@bryan-minimal bryan-minimal left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads as the ruling says: hosts, not providers, and only the three places that read them the other way change. The S16 non-goal now points at the ruling instead of waiting on it.

@mitodrummer
mitodrummer added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit e924710 Oct 27, 2026
37 checks passed
@mitodrummer
mitodrummer deleted the docs/box-local-provider-hosts branch October 27, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0