Repository navigation
fix(deps): bump rustls-webpki and webpki-root-certs past the emSign advisories - #2466
Merged
Merged
Conversation
…dvisories RUSTSEC-2026-0382 (rustls-webpki 0.103.15) and RUSTSEC-2026-0383 (webpki-root-certs 1.0.9), both published 2026-10-20, red cargo-deny on every PR. rustls-webpki 0.103.16 rejects paths through the distrusted emSign intermediates, and webpki-root-certs 1.0.10 drops the emSign ECC Root CA - G3. Lockfile-only change.
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
|
Reviewed: 1 finding, none blocking at Address the comments on the diff. Clobber: none. |
bryan-minimal
approved these changes
Oct 20, 2026
| dependencies = [ | ||
| "fastrand", | ||
| "getrandom 0.4.3", | ||
| "getrandom 0.3.4", |
Contributor
There was a problem hiding this comment.
LOW · correctness · confidence 0.55 · in tempfile
The tempfile entry now depends on getrandom 0.3.4 instead of 0.4.3. The PR body says no other package moves. tempfile 3.27.0 is the same version, so a dependency edge change with no version change looks like an unintended lockfile re-resolution. Regenerate the lock with only cargo update -p rustls-webpki -p webpki-root-certs and drop this hunk, or explain it.
What the reviewer checked
- "getrandom 0.4.3",
- "getrandom 0.3.4", (in tempfile 3.27.0, unchanged version)
Hand this to an agent
Act on a code-review finding.
File: Cargo.lock
Lines: 7475-7475
Category: correctness
Severity: low (reviewer confidence 0.55)
Finding:
The `tempfile` entry now depends on `getrandom 0.3.4` instead of `0.4.3`. The PR body says no other package moves. `tempfile` 3.27.0 is the same version, so a dependency edge change with no version change looks like an unintended lockfile re-resolution. Regenerate the lock with only `cargo update -p rustls-webpki -p webpki-root-certs` and drop this hunk, or explain it.
First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.
<
8000
/pre>👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.
2 tasks done
norrietaylor
added a commit
that referenced
this pull request
Oct 21, 2026
…dvisories (#2466) RUSTSEC-2026-0382 (rustls-webpki 0.103.15) and RUSTSEC-2026-0383 (webpki-root-certs 1.0.9), both published 2026-10-20, red cargo-deny on every PR. rustls-webpki 0.103.16 rejects paths through the distrusted emSign intermediates, and webpki-root-certs 1.0.10 drops the emSign ECC Root CA - G3. Lockfile-only change. (cherry picked from commit c0ac8c5)
norrietaylor
added a commit
that referenced
this pull request
Oct 21, 2026
Hotfix release carrying the rustls-webpki and webpki-root-certs bumps from #2466 (RUSTSEC-2026-0382, RUSTSEC-2026-0383) onto 0.7.0. Claude-Session: https://claude.ai/code/session_01FnY4WzhrnmSEByMntmqsVF
norrietaylor
added a commit
that referenced
this pull request
Oct 21, 2026
…dvisories (#2466) RUSTSEC-2026-0382 (rustls-webpki 0.103.15) and RUSTSEC-2026-0383 (webpki-root-certs 1.0.9), both published 2026-10-20, red cargo-deny on every PR. rustls-webpki 0.103.16 rejects paths through the distrusted emSign intermediates, and webpki-root-certs 1.0.10 drops the emSign ECC Root CA - G3. Lockfile-only change. (cherry picked from commit c0ac8c5)
8000
norrietaylor
added a commit
that referenced
this pull request
Oct 21, 2026
Hotfix release carrying the rustls-webpki and webpki-root-certs bumps from #2466 (RUSTSEC-2026-0382, RUSTSEC-2026-0383) onto 0.7.0. Claude-Session: https://claude.ai/code/session_01FnY4WzhrnmSEByMntmqsVF
yermakoffivan
pushed a commit
to yermakoffivan/minimal
that referenced
this pull request
Oct 22, 2026
* fix(promote): find the draft release by listing and publish it under its tag (gominimal#2220) The publish job looked the release up with `gh release view v<semver>`. A draft has no tag yet, so the lookup answered 404 for exactly the release the job exists to publish, and the 0.7.0 promotion failed there. Publishing a draft without naming tag_name also tags it with the draft's untagged-<hex> placeholder rather than v<semver>. The job now finds the release by listing releases and matching tag_name, refuses when more than one carries the tag, and publishes by id with tag_name and target_commitish set. * fix(deps): bump rustls-webpki and webpki-root-certs past the emSign advisories (gominimal#2466) RUSTSEC-2026-0382 (rustls-webpki 0.103.15) and RUSTSEC-2026-0383 (webpki-root-certs 1.0.9), both published 2026-10-20, red cargo-deny on every PR. rustls-webpki 0.103.16 rejects paths through the distrusted emSign intermediates, and webpki-root-certs 1.0.10 drops the emSign ECC Root CA - G3. Lockfile-only change. (cherry picked from commit c0ac8c5) * chore(release): bump version to 0.7.1 Hotfix release carrying the rustls-webpki and webpki-root-certs bumps from gominimal#2466 (RUSTSEC-2026-0382, RUSTSEC-2026-0383) onto 0.7.0. Claude-Session: https://claude.ai/code/session_01FnY4WzhrnmSEByMntmqsVF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two RustSec advisories published on 2026-10-20 make
cargo-denyfail on every PR (for example #2458):rustls-webpki0.103.15 can accept certificate paths through distrusted emSign intermediates, whose private keys are now public.webpki-root-certs1.0.9 still bundlesemSign ECC Root CA - G3.Change
cargo update -p rustls-webpki -p webpki-root-certsmovesrustls-webpkito 0.103.16 andwebpki-root-certsto 1.0.10. OnlyCargo.lockchanges, and no other package moves.Verification
just denyreportsadvisories ok, bans ok, licenses ok, sources ok.