8000 fix(deps): hotfix 0.7.1 with the emSign advisory bumps from #2466 by norrietaylor · Pull Request #2471 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(deps): hotfix 0.7.1 with the emSign advisory bumps from #2466 - #2471

Merged
norrietaylor merged 2 commits into
release/0.7.0from
fix/hotfix-0.7.1
Oct 21, 2026
Merged

norrietaylor merged 2 commits into
release/0.7.0from
fix/hotfix-0.7.1

Conversation

@norrietaylor
@norrietaylor norrietaylor commented Oct 20, 2026 •
Copy link
Copy Markdown
Member

Summary

Emergency hotfix for 0.7.0. It cherry-picks #2466 onto release/0.7.0 and cuts it as 0.7.1.

  • RUSTSEC-2026-0382: rustls-webpki 0.103.15 → 0.103.16. The old version can accept certificate paths through the distrusted emSign intermediates.
  • RUSTSEC-2026-0383: webpki-root-certs 1.0.9 → 1.0.10. The old version bundles emSign ECC Root CA - G3.

release/0.7.0 is v0.7.0 plus #2220 (the promote.yml draft-release fix).

Commits:

  1. cherry-pick -x of c0ac8c5 (fix(deps): bump rustls-webpki and webpki-root-certs past the emSign advisories #2466). Only Cargo.lock changes. One hunk of fix(deps): bump rustls-webpki and webpki-root-certs past the emSign advisories #2466 doesn't apply to 0.7.0 and is left out: it changes the getrandom version that tempfile depends on, which exists only in main's lockfile. The two advisory bumps are byte-identical to fix(deps): bump rustls-webpki and webpki-root-certs past the emSign advisories #2466.
  2. package.version 0.7.0 → 0.7.1. Version 0.7.0 is already staged and can't be reused. cargo update -w changes only the workspace crate entries in Cargo.lock.

Merge with "Create a merge commit" or "Rebase and merge", not squash. Keeping the cherry-pick as its own commit lets git cherry match it to #2466 when the tag is merged back into main (release-pipeline.md step 7).

Testing

  • just check-version: package.version 0.7.1 satisfies the 3 commit(s) since v0.7.0 (patch bump, at least 0.7.1) and is greater than the newest tag v0.7.0
  • just deny: advisories ok, bans ok, licenses ok, sources ok
  • The full required lanes run on this PR.

Release steps after merge (docs/internal/release-pipeline.md)

gh workflow run release.yml --ref release/0.7.0 -f versioned=true -f dry_run=true
gh workflow run release.yml --ref release/0.7.0 -f versioned=true -f dry_run=false
gh workflow run promote.yml -f target=stable -f version=0.7.1 -f dry_run=true
gh workflow run promote.yml -f target=stable -f version=0.7.1   # second approver comments `approved`

Then merge v0.7.1 back into main with -s ours (step 7). #2220 isn't on main yet, so git cherry will list it. Land it on main first.

Checklist

  • Docs updated if behavior changed (no behavior change)
  • BREAKING CHANGE: footer present if this is a breaking change (not breaking)

🤖 Generated with Claude Code

https://claude.ai/code/session_01FnY4WzhrnmSEByMntmqsVF

@norrietaylor
norrietaylor requested a review from a team as a code owner October 20, 2026 23:54
@coderabbitai
coderabbitai Bot commented Oct 20, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 45d51f79-acaa-4ed1-b179-8876c9d2895c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@CLAassistant
CLAassistant commented Oct 20, 2026 •
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@norrietaylor
norrietaylor changed the base branch from release/0.7.1 to release/0.7.0 October 20, 2026 23:55
@minimal-foundry
minimal-foundry Bot commented Oct 20, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 1b2689176642.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 20, 2026
@norrietaylor norrietaylor reopened this Oct 21, 2026
…dvisories (#2466)

RUSTSEC-2026-0382 (rustls-webpki 0.103.15) and RUSTSEC-2026-0383 (webpki-root-certs
1.0.9), both published 2026-10-20, red cargo-deny on every PR. rustls-webpki 0.103.16 rejects
paths through the distrusted emSign intermediates, and webpki-root-certs 1.0.10 drops the emSign
ECC Root CA - G3. Lockfile-only change.

(cherry picked from commit c0ac8c5)
Hotfix release carrying the rustls-webpki and webpki-root-certs bumps
from #2466 (RUSTSEC-2026-0382, RUSTSEC-2026-0383) onto 0.7.0.

Claude-Session: https://claude.ai/code/session_01FnY4WzhrnmSEByMntmqsVF
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

8000

@norrietaylor
norrietaylor merged commit 0ca3bf4 into release/0.7.0 Oct 21, 2026
28 of 29 checks passed
@norrietaylor
norrietaylor deleted the fix/hotfix-0.7.1 branch October 21, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0