8000 docs(vale): accept the spec-hash and supply-chain terms by bryan-minimal · Pull Request #2018 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

docs(vale): accept the spec-hash and supply-chain terms - #2018

Merged
norrietaylor merged 1 commit into
mainfrom
docs/vale-spec-hash-vocab
Oct 17, 2026
Merged

docs(vale): accept the spec-hash and supply-chain terms#2018
norrietaylor merged 1 commit into
mainfrom
docs/vale-spec-hash-vocab

Conversation

@bryan-minimal
@bryan-minimal bryan-minimal commented Oct 6, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Member

Summary

Adds 13 words to the Vale vocabulary (styles/config/vocabularies/Minimal/accept.txt): biconditional, codec, codecs, encodable, injective, injectivity, keyspace, pkgs, preimage, preimages, Sigstore, varint, varints. Spec 20 (spec-hash epoch 1, #1305) uses them as defined terms, and Vale.Spelling flags each one. Inserted in the file's existing order.

Testing

  • Vale 3.24 with this repo's .vale.ini on docs/specs/20-spec-spec-hash-epoch1/20-spec-spec-hash-epoch1.md (docs(specs): spec-hash epoch 1, an injective, machine-checked BuildSpec encoding #1305's head plus this change): no spelling alerts on any of the 13 words; the remaining spelling alerts are test identifiers.
  • just lint-prose with no arguments fails on main before and after this change, on docs/specs/TEMPLATE.md's frontmatter (<feature name> is not valid YAML). That is separate from this change.

Checklist

  • Docs updated if behavior changed
  • BREAKING CHANGE: footer present if this is a breaking change

Summary by CodeRabbit

  • Improvements
    • Added vocabulary entries for additional technical terms, including “biconditional,” “injective,” and “Sigstore.”

@bryan-minimal
docs(vale): accept the spec-hash and supply-chain terms
aa77148 
Spec 20 (spec-hash epoch 1) uses these words as defined terms: codec,
injective, injectivity, keyspace, preimage, biconditional, encodable,
varint, Sigstore and pkgs. Vale's spelling rule flags each of them.
@bryan-minimal
bryan-minimal requested a review from a team as a code owner October 6, 2026 16:29
@coderabbitai
coderabbitai Bot commented Oct 6, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 86811337-eac7-4d03-9013-42ffcc1ac0a6
📥 Commits

Reviewing files that changed from the base of the PR and between b2646a3 and aa77148.

📒 Files selected for processing (1)
  • styles/config/vocabularies/Minimal/accept.txt

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

📝 Walkthrough

Walkthrough

The Minimal vocabulary list adds 13 entries: biconditional, codec-related terms, encodable, injectivity-related terms, keyspace, preimage-related terms, pkgs, Sigstore, and varint-related terms.

Changes

Minimal vocabulary additions

Layer / File(s) Summary
Add accepted vocabulary entries
styles/config/vocabularies/Minimal/accept.txt		 The accepted vocabulary list adds 13 entries. Existing entries remain present.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: 0chroma

Merge Risk: ⚪ Minimal · up to aa771

This change adds accepted terms for Spec 20; no concrete user-facing or operational risk is identified, so it is mergeable subject to normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding spec-hash and supply-chain terms to Vale’s accepted vocabulary.
Description check ✅ Passed The description includes the required Summary, Testing, and Checklist sections. It explains the vocabulary changes, reports relevant test results, and completes the applicable checklist item.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the word list with care,
New terms hop in and settle there.
Codec and varint join the row,
While Sigstore finds a place to grow.
The rabbit rests beside the page.

Comment @coderabbitai help to get the list of available commands.

@minimal-foundry
minimal-foundry Bot commented Oct 6, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Approved: no findings at aa77148e6fe2.

Nothing to do.

Clobber: none: git log on the file shows only this commit and the original Vale-linting commit (#1352); no earlier fix is reverted. Not checked: running Vale itself (would need the vale binary, which is out of scope); the placement and vocabulary claims are verified by structure instead. The change is good and this is an approval.

minimal-foundry[bot]
minimal-foundry Bot approved these changes Oct 6, 2026
View reviewed changes
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 6, 2026
@norrietaylor
norrietaylor merged commit 647e902 into main Oct 17, 2026
34 checks passed
@norrietaylor
norrietaylor deleted the docs/vale-spec-hash-vocab branch October 17, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@minimal-foundry minimal-foundry[bot] minimal-foundry[bot] approved these changes

Assignees

No one assigned

Labels

review:approved minimal-review approved the current head

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryan-minimal @norrietaylor
0