Repository navigation
fix(release): leave unstable alone on versioned builds - #1712
Conversation
record-smoked moved unstable to every smoked build, versioned ones included. A versioned build can now come from a release branch behind main, so staging it would roll unstable users back to an older commit until the next nightly. unstable follows main: only sha-keyed builds advance it, and a staged release reaches a channel only through the promotion. The runbook's step 5 installs a staged release through a private pointer instead.
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 26 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Comment |
|
Approved: 1 finding, none above this repo's threshold at Nothing to do. Clobber: none: |
| # `unstable` advance, and only for a sha-keyed build: a channel never | ||
| # points at bytes that have not passed the smoke, and a versioned | ||
| # build never moves `unstable` (it follows main; a staged release | ||
| # reaches a channel only through promote). A dry run stages nothing, so `needs` alone already |
There was a problem hiding this comment.
NIT · style · confidence 0.55 · in record-smoked
The rewritten record-smoked comment block is wrapped at ~77 chars everywhere except this line, which is 101 chars: 'A dry run stages nothing, so needs alone already' is a leftover of the original two-line wrap that was not re-wrapped when four lines were added above it. Re-wrap to match the rest of the block.
What the reviewer checked
release.yml:1429 # reaches a channel only through promote). A dry run stages nothing, so
needsalone already
Hand this to an agent
Act on a code-review finding.
File: .github/workflows/release.yml
Lines: 1429-1429
Category: style
Severity: nit (reviewer confidence 0.55)
Finding:
The rewritten `record-smoked` comment block is wrapped at ~77 chars everywhere except this line, which is 101 chars: 'A dry run stages nothing, so `needs` alone already' is a leftover of the original two-line wrap that was not re-wrapped when four lines were added above it. Re-wrap to match the rest of the block.
First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.
👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.
Why
record-smokedmovedunstableto every smoked build, versioned ones included. Versioned builds now come fromrelease/*branches, which can be behindmain. Staging one rolledunstableusers back to an older commit until the next nightly moved it forward again.This implements decision 4 of the release-branch proposal: staged binaries are not pointed to by
unstable.Change
release.yml: the "Point unstable channel at this release" step runs only whenassert-versionoutputs an emptyrelease_version, which covers sha-keyed nightly and plain builds. The smoke record is still written for every build, so a versioned build can still be promoted.docs/internal/release-pipeline.md):unstable.scripts/set-channel.sh --channel rc ...) instead ofunstable.record-smokedreference says the same.Notes
release/0.6.0'srelease.yml, so this change does not reach it. That run still movesunstableto 0.6.0, and the next nightly moves it back tomain..github/workflows/is CODEOWNER-gated; this needs CODEOWNER review.Testing
actionlint .github/workflows/release.yml: clean.