8000 Add a spanner emulator to the unit tests action by janzak-dev · Pull Request #6 · google/xmc · GitHub
[go: up one dir, main page]

Skip to content

Add a spanner emulator to the unit tests action - #6

Merged
janzak-dev merged 9 commits into
feature/unit_tests_actionfrom
feature/unit_tests_action_emu
Jun 5, 2026
Merged

janzak-dev merged 9 commits into
feature/unit_tests_actionfrom
feature/unit_tests_action_emu

Conversation

@janzak-dev
Copy link
Copy Markdown
Collaborator

By adding the spanner emulator we've made another batch of tests pass https://github.com/google/xmc/actions/runs/26889220902/job/79310101694

@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 3, 2026 13:57 — with GitHub Actions Inactive
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 3, 2026 13:57 — with GitHub Actions Inactive
@janzak-dev
janzak-dev requested a review from AntonTyb June 3, 2026 14:01
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action_emu branch from 35e4cfd to ee276b6 Compare June 3, 2026 14:05
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 3, 2026 14:05 — with GitHub Actions Inactive
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 3, 2026 14:05 — with GitHub Actions Inactive
@janzak-dev janzak-dev mentioned this pull request Jun 3, 2026
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action branch from 3a37054 to b499e6f Compare June 5, 2026 09:00
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action_emu branch from ee276b6 to 7893e37 Compare June 5, 2026 10:56
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 5, 2026 10:56 — with GitHub Actions Inactive
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action_emu branch from 7893e37 to 439dc1b Compare June 5, 2026 11:05
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 5, 2026 11:05 — with GitHub Actions Inactive
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action_emu branch from 439dc1b to 201b9d8 Compare June 5, 2026 11:19
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 5, 2026 11:19 — with GitHub Actions Inactive
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action_emu branch from 201b9d8 to 6a15eb3 Compare June 5, 2026 11:43
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 5, 2026 11:43 — with GitHub Actions Inactive
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action_emu branch from 6a15eb3 to 187b84e Compare June 5, 2026 12:00
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 5, 2026 12:00 — with GitHub Actions Inactive
@janzak-dev
janzak-dev force-pushed the feature/unit_tests_action branch from f59a136 to ad3d25f Compare June 5, 2026 12:46
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 5, 2026 12:49 — with GitHub Actions Inactive
@janzak-dev
janzak-dev merged commit 18ec1ee into feature/unit_tests_action Jun 5, 2026
1 of 2 checks passed
@janzak-dev
janzak-dev deleted the feature/unit_tests_action_emu branch June 5, 2026 12:55
@janzak-dev
janzak-dev restored the feature/unit_tests_action_emu branch June 5, 2026 12:56
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 8, 2026 08:17 — with GitHub Actions Inactive
janzak-dev added a commit that referenced this pull request Jun 9, 2026
* Github actions - tests - unit test first attempt

* Github actions - tests setup trigger on branch push

* Restrict the unit tests that are currently being run

* Github actions - tests setup trigger on branch push

* attempt at making tests fast again

Change-Id: I8256c64d6866a8c85314bdb7005f902823df2d16

* Make the action run on a branch push (to test it)

* Adding a spanner emulator to the configuration

* Trying to make more tests pass

---------

Co-authored-by: atyburcy <atyburcy@google.com>
janzak-dev added a commit that referenced this pull request Jun 9, 2026
* Add a spanner emulator to the unit tests action (#6)

* Github actions - tests - unit test first attempt

* Github actions - tests setup trigger on branch push

* Restrict the unit tests that are currently being run

* Github actions - tests setup trigger on branch push

* attempt at making tests fast again

Change-Id: I8256c64d6866a8c85314bdb7005f902823df2d16

* Make the action run on a branch push (to test it)

* Adding a spanner emulator to the configuration

* Trying to make more tests pass

---------

Co-authored-by: atyburcy <atyburcy@google.com>

* Add a missed typo

* Fix another typo

* Fix another typo

* Fix other things

* Fix migration tests

* Fix another test

* Adding spanner to BAZEL files

* Change some bazel files around

* Shard the tests so they can run in parallell

* Bring back parser scanner typo

* Fix spanner tests

* Clean up unnecessary whitespace and formatting changes

* Address code review comments from VLukiantsev

- Eliminate brittle magic string database lookups in migrations tests by using strongly-typed getDB selector callbacks.

- Export and reuse RandomSuffix helper from emulator package across all Spanner test drivers.

* Proactive code review cleanups

- Scrub missed duplicate randomSuffix helper from spannerdriver_test.go.

- Remove unused google/rpc/status.proto import from operations.proto.

* Another round of adjustments

* Add a unit tests for the new function

---------

Co-authored-by: atyburcy <atyburcy@google.com>

This branch was previously deployed

1 inactive deployment
janzak-dev-test — 84c1ed3d Deployed Jun 8, 2026 by janzak-dev via Run Unit Tests #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0