Repository navigation
feat(ui): align experiment details page layout and metadata split card - #957
Merged
Merged
Conversation
Align the experiment details page layout, add the 1px solid #dadce0 vertical divider between Metadata and Notes, and style URL buttons and card paddings. TAG=agy CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd
There was a problem hiding this comment.
Code Review
This pull request updates the styling of the experiment page in experiment_page.scss, adjusting layouts, margins, paddings, and font properties. The review feedback highlights several instances of hardcoded hex colors for text, borders, and interactive elements, and suggests replacing them with Material Design CSS custom properties to ensure proper support for dark mode and theme customization.
Comment link: #957 (comment) TAG=agy CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd
liutj-tech
marked this pull request as ready for review
September 22, 2026 21:56
liutj-tech
requested review from
AntonTyb
and removed request for
andrzejfudro
September 22, 2026 21:56
AntonTyb
enabled auto-merge
September 23, 2026 07:17
AntonTyb
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that
7F7D
reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the Experiment Details page layout (
24px 32pxpadding), adds the1px solid #dadce0vertical divider between Metadata and Notes in.experiment-summary-container, and styles URL buttons (1px solid #dadce0,6pxradius,#1a73e8).(Part 6 of 8 in the scoped UI Style Alignment series corresponding to Area #6 of the Style Inconsistency Table.)
Visual Comparison (Before vs. After)
Component-Level Diff (Area #6)
📸 Full-Page Context Screenshot (Production vs. Prototype)
Motivation & Context
Brings Area #6 of
cmd/ui/into visual alignment with the Google Cloud / Material 3 prototype specification while keeping this Pull Request focused on a single cohesive component area (< 45lines of diff).Key Changes
cmd/ui/app/experiment_page/experiment_page.scss: Set:hostfull-width layout (24px 32pxpadding,20pxgap),h1(20px,400weight), addborder-right: 1px solid #dadce0(padding-right: 28px) to.experiment-summary-metadata, and style.url-buttonandmat-card-title/mat-card-content.Assumptions
"XManager"brand title/logo and fixed200pxnon-expandable left sidenav was explicitly requested by the user — expandable drawer behavior and brand header text changes are deferred to a future change — zero impact on current routes or functionality.Verification & Testing
./tools/analyze_diff_size.py --base-ref origin/main...(well below400-line threshold)npm run format:check && npm run lint(Prettier & ESLint passed cleanly)npm run build(Angular production bundle compiled cleanly)npm test -- --watch=false --browsers=ChromeHeadlessNoSandbox(616 of 616 SUCCESS)Related Issues / Bugs
N/A
TAG=agy
CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd