8000 Unblock a part of unit tests by adding a spanner emulator, plus some minor tweaks by janzak-dev · Pull Request #8 · google/xmc · GitHub
[go: up one dir, main page]

Skip to content

Unblock a part of unit tests by adding a spanner emulator, plus some minor tweaks - #8

Closed
janzak-dev wants to merge 5 commits into
testfrom
feature/unit_tests_action
Closed

janzak-dev wants to merge 5 commits into
testfrom
feature/unit_tests_action

Conversation

@janzak-dev
@janzak-dev janzak-dev commented Jun 5, 2026 •
Copy link
Copy Markdown
Collaborator

A successful run is here https://github.com/google/xmc/actions/runs/27017409793.

This PR contains previously merged branch #6 which made sure that spanner emulator works properly in the github actions environment.

janzak-dev and others added 5 commits June 5, 2026 14:54
* Github actions - tests - unit test first attempt

* Github actions - tests setup trigger on branch push

* Restrict the unit tests that are currently being run

* Github actions - tests setup trigger on branch push

* attempt at making tests fast again

Change-Id: I8256c64d6866a8c85314bdb7005f902823df2d16

* Make the action run on a branch push (to test it)

* Adding a spanner emulator to the configuration

* Trying to make more tests pass

---------

Co-authored-by: atyburcy <atyburcy@google.com>
@janzak-dev
janzak-dev temporarily deployed to janzak-dev-test June 5, 2026 13:54 — with GitHub Actions Inactive
@janzak-dev janzak-dev closed this Jun 5, 2026
VLukiantsev added a commit that referenced this pull request Aug 12, 2026
…f-diff scope) confirmation gate

Addressed user feedback from trajectory 32e2238a-ae33-46a0-93f4-46c494ef20ac:
- Prevent misleading Phase 4 questions that claim to post #1 through #8 when items outside the PR diff patch cannot be posted inline via GitHub's API.
- Require explicit partitioning of findings in Phase 3 & Phase 4:
  * Group A (Postable Inline PR Diff Patch Comments)
  * Group B (Out-of-Diff Scope Observations on unchanged lines)
- Require explicit confirmation for Group A inline posting AND separate explicit prompt for including any critical Group B out-of-diff items as an overall PR summary comment (default: omit from PR, keep in session checklist artifact).

TAG=agy
CONV=6714a663-6b5e-40db-b553-a4cc85359e91

This branch was previously deployed

1 inactive deployment
janzak-dev-test — 7b9d54e7 Deployed Jun 5, 2026 by janzak-dev via Run Unit Tests #146
6312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0