Repository navigation
Unblock a part of unit tests by adding a spanner emulator, plus some minor tweaks - #8
Closed
janzak-dev wants to merge 5 commits into
Closed
janzak-dev wants to merge 5 commits into
janzak-dev wants to merge 5 commits into
Conversation
* Github actions - tests - unit test first attempt * Github actions - tests setup trigger on branch push * Restrict the unit tests that are currently being run * Github actions - tests setup trigger on branch push * attempt at making tests fast again Change-Id: I8256c64d6866a8c85314bdb7005f902823df2d16 * Make the action run on a branch push (to test it) * Adding a spanner emulator to the configuration * Trying to make more tests pass --------- Co-authored-by: atyburcy <atyburcy@google.com>
janzak-dev
temporarily deployed
to
janzak-dev-test
June 5, 2026 13:54 — with
GitHub Actions
Inactive
VLukiantsev
added a commit
that referenced
this pull request
Aug 12, 2026
…f-diff scope) confirmation gate Addressed user feedback from trajectory 32e2238a-ae33-46a0-93f4-46c494ef20ac: - Prevent misleading Phase 4 questions that claim to post #1 through #8 when items outside the PR diff patch cannot be posted inline via GitHub's API. - Require explicit partitioning of findings in Phase 3 & Phase 4: * Group A (Postable Inline PR Diff Patch Comments) * Group B (Out-of-Diff Scope Observations on unchanged lines) - Require explicit confirmation for Group A inline posting AND separate explicit prompt for including any critical Group B out-of-diff items as an overall PR summary comment (default: omit from PR, keep in session checklist artifact). TAG=agy CONV=6714a663-6b5e-40db-b553-a4cc85359e91
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful run is here https://github.com/google/xmc/actions/runs/27017409793.
This PR contains previously merged branch #6 which made sure that spanner emulator works properly in the github actions environment.