8000 Harden Go tool integration edge cases by dajiaohuang · Pull Request #451 · dominikh/go-mode.el · GitHub
[go: up one dir, main page]

Skip to content
1 < 10000 link crossorigin="anonymous" rel="modulepreload" href="https://github.githubassets.com/assets/app-install-banner-partial-c0721fe14e256ecc.js" fetchpriority="low" />

Harden Go tool integration edge cases - #451

Closed
dajiaohuang wants to merge 1 commit into
dominikh:masterfrom
dajiaohuang:harden-go-tool-integrations
Closed

dajiaohuang wants to merge 1 commit into
dominikh:masterfrom
dajiaohuang:harden-go-tool-integrations

Conversation

@dajiaohuang
@dajiaohuang dajiaohuang commented Oct 1, 2026 •
Copy link
Copy Markdown

This change fixes several code-path defects found while reviewing Go tool integrations:

  • Run godoc as a process with separate arguments so query text is not interpreted by a shell.
  • Parse guru and coverage positions from the final numeric fields, preserving colons in Windows drive paths.
  • Preserve complete guru error output and ignore non-location diagnostics in the compilation filter.
  • Leave an import list unchanged when the requested package is already imported.
  • Remove an unintended message side effect from modified-buffer byte counting.

Add focused ERT coverage for these cases.

Validated with Emacs 30.2: all 40 ERT tests pass.

@dajiaohuang
Copy link
Copy Markdown
Author

Withdrawing this mixed-scope audit PR: its independent Go tool, path parsing, import, and message-side-effect changes need separate issue-level review. I am keeping the focused #449 and #450 fixes in their own PRs.

@dajiaohuang dajiaohuang closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0