8000 Select Go files correctly before rename by dajiaohuang · Pull Request #450 · dominikh/go-mode.el · GitHub
[go: up one dir, main page]

Skip to content

Select Go files correctly before rename - #450

Closed
dajiaohuang wants to merge 1 commit into
dominikh:masterfrom
dajiaohuang:fix-go-rename-buffer-selection
Closed

dajiaohuang wants to merge 1 commit into
dominikh:masterfrom
dajiaohuang:fix-go-rename-buffer-selection

Conversation

@dajiaohuang
@dajiaohuang dajiaohuang commented Oct 1, 2026 •
Copy link
Copy Markdown

Select Go source buffers with the extension returned by file-name-extension (go, without a leading dot) before invoking gorename. Add coverage for Go files, non-Go files, and buffers without a file name. Validated with Emacs 30.2: focused ERT passes.

Closes #452.

@dajiaohuang
Copy link
Copy Markdown
Author

Closing this PR after the maintainer's note on #452 that go-rename is slated for removal. The maintainer has closed #452, so this fix no longer applies to the planned code direction.

@dajiaohuang dajiaohuang closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save other Go buffers before invoking go-rename

1 participant

0