Repository navigation
feat(timeline): say who gave each reaction, on hover - #651
Merged
Merged
Conversation
Each reaction now carries `who`: up to five of the others who gave it, by name, earliest first. Hovering a chip on the timeline reads "You, Sam and 3 others". The API, MCP react_to_activity and the page carry it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ln25ykE6uBDqx21WBU94SX
21 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: a reaction on the timeline showed only how many gave it and whether you did. Nobody could see who.
After: hovering a reaction chip reads "You, Sam and 3 others": you first, then up to five of the others by name, earliest first, then how many more. A closed line of several items does the same over its summed chips. Each reaction in the API (
GET /api/v1/activities,POST /activities/{id}/react) and MCPreact_to_activitycarrieswho, the same names.How:
event_reactions._tallykeeps the order people reacted in (byat, then account) and names the first five others withevents_content.actors, in one extra query per page. The page'sreactedBywrites the hover line;sumReactionsmerges names across a line's items.Motivation and Context
A refine-later item from the reactions and comments step (#570) of the activity stream design (thread above): "Who gave each reaction, on hover". Follows #643 and #646.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.changelog.d/(timeline-who-reacted.md).Done questions (AGENTS.md)
whoon every reaction in the API and MCPreact_to_activityandtimeline.atwas already on every reaction row.test_timeline_social.py(test_a_reaction_names_who_else_gave_it_earliest_first_up_to_five, andwhoin the existing shapes); jesttimeline-social-model.test.ts(a reaction's hover says who gave it…, names merged across a line) andtimeline-ui.test.tsx(the hover on a line and on a chip); OpenAPI client regenerated withmake openapi; docs timeline.md, requirements.md, changelog.d.events_content.actorsfor names, the existing chips and theirtitle; no new machinery.Local CI (
ci/local-ci.sh) on this head: running; CI on the PR decides the merge.Generated by Claude Code