Repository navigation
feat(timeline): edit your comments and resolve threads from the timeline - #654
Merged
Merged
Conversation
Edit on your own comment opens its text in place (Enter saves, Escape
cancels). Resolve the thread and Reopen the thread sit on a thread's first
comment for those who may, and a resolved thread says who resolved it.
Uses the existing PATCH /activities/{id}/comments/{cid}.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ln25ykE6uBDqx21WBU94SX
21 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: on the timeline you could comment, reply and delete, but fixing a typo in your comment or resolving a thread meant going to the asset's page (and an activity that isn't an asset had no page to do it on).
After: Edit on your own comment opens its text in place: Enter saves, Escape leaves it as it was, and it then says "edited". Resolve the thread on a thread's first comment (for whoever started it or an editor of the namespace) marks it "Resolved by Sam", dimmed in place, and Reopen the thread takes that back. The agent's own answers have no Edit.
How: the page's comment hook gains
update, which calls the existingPATCH /api/v1/activities/{id}/comments/{cid}withtextorresolved; the thread reusesresolvedByfrom the asset page's comments model and the timeline's own composer, now with a starting text. No server change.Motivation and Context
A refine-later item from the reactions and comments step (#570) of the activity stream design (thread above): "editing and resolving comments from the timeline (the API has both)". Follows #651.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.changelog.d/(timeline-comment-edit.md).Done questions (AGENTS.md)
PATCH /api/v1/activities/{id}/comments/{cid}agents already had; the page catches up.timeline-ui.test.tsx(your comment is edited in place, and a thread you can resolve is resolved and reopened from the timeline: Enter saves, Escape leaves, resolve then reopen); docs timeline.md, requirements.md, changelog.d.resolvedBy, the timeline's composer; no new machinery.Local CI (
ci/local-ci.sh) on this head: running; CI on the PR decides the merge.Generated by Claude Code