Repository navigation
feat(timeline): open one item by its address, and link comments, reactions and approvals to it - #646
Merged
Merged
Conversation
…tions and approvals to it /timeline?item=<id> opens that item above the timeline with its details, marks, reactions, comments and actions, and a way back. A comment on an item, a reaction and an approval's why now link there instead of to the timeline as a whole. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ln25ykE6uBDqx21WBU94SX
21 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: nothing linked to one timeline item. A comment on an item, a reaction and an approval's "because" pointed at the timeline as a whole (or a word search on the summary), and a person had to find the item again by hand.
After:
/timeline?item=<id>opens that item above the timeline, already expanded, with its details, marks, reactions, comments, what it caused and its actions, and Back to the timeline under it; the rest of the timeline still lists below. A comment on an item, a reaction (reaction.addedgainsobject.url) and an approval's "because" now link there. One you can't see, or that isn't there, says "No such item". That is also the link an agent can give a person to an item it read withtimeline.How: the page reads
itemfrom the address beside the filters (it is not a filter, so changing filters drops it), loads the item with the existingGET /api/v1/activities/{id}and renders it with the sameTimelineRowas any line. On the server, the comment activity'surl, the reaction activity's newurlandapprovals._why(when the activity has no page of its own) point at it.Motivation and Context
A refine-later item from the reactions and comments step (#570) of the activity stream design (thread above): "A
comment.addedon an activity links to the timeline, not yet to the item itself." Follows #635, #637, #642 and #643.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.changelog.d/(timeline-open-item.md).Done questions (AGENTS.md)
GET /api/v1/activities/{id}and MCPtimeline.url.timeline-ui.test.tsx(the address can name one item, opened above the timeline, with a way back: the item loaded and opened, the back link, the timeline still below, the missing one);test_timeline_social.py(a comment on an item links to it); the reaction sample validates intest_events_content.py; docs timeline.md, requirements.md, changelog.d.urlon the object; no new dependency.TimelineRow, the page's marks, reactions, comments and mute hooks,GET /activities/{id}; no new machinery.Local CI (
ci/local-ci.sh) on this head: running; CI on the PR decides the merge.Generated by Claude Code