Repository navigation
Record two pages the sweep could not see: OLM producer, spoiler-tagged review - #681
Merged
Merged
Conversation
irfan-dahir
added a commit
that referenced
this pull request
Nov 11, 2026
The witness count drops to 18 once the recordings in #681 land, the Source-selector check covered both seasonal pages (92/92 and 420/421, not 420/421 overall), and the deprecate-or-derive question was settled in #680. The stale 38-field line in the audit questions now points at the triage instead of asking again.
OLM (producer 28) has "Available At" links and no "Resources" section, which is the shape getExternalLinks() returned [] for before jikan#672. The variant pins the fix against a real page, not only a synthetic crawler.
No recorded user-reviews page carried a spoiler tag, so UserAnimeReview::isSpoiler could never be true. Noya_xoxo has one; the variant pins it, and the field leaves the witness report.
The other producer variants carry their page number; this one page is the first, so the suffix is p1.
irfan-dahir
force-pushed
the
test/variant-producer-one-section
branch
from
November 12, 2026 13:18
d58c757 to
fc62d47
Compare
irfan-dahir
added a commit
that referenced
this pull request
Nov 12, 2026
The witness count drops to 18 once the recordings in #681 land, the Source-selector check covered both seasonal pages (92/92 and 420/421, not 420/421 overall), and the deprecate-or-derive question was settled in #680. The stale 38-field line in the audit questions now points at the triage instead of asking again.
irfan-dahir
added a commit
that referenced
this pull request
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two corpus variants — no production code, no changelog. Both were chosen from the field-witness triage, and both change what the sweep can prove.
producer-28-p1(OLM)getExternalLinks()answered with[]. Until now the fix was pinned only by a synthetic test that deletes a section from the Pierrot page.user-reviews-noya-xoxoUserAnimeReview::isSpoilerwas nevertrue. This page has one; the snapshot carriesisSpoiler: true.Both recorded live on 2026-11-11 via
php scripts/record_variants.php --live --> (GET, 3.5s apart). The OLM id carries the page suffix (-p1) to matchproducer-1-p1/-p2.Effect on the witness report: 19 → 18 fields.
isSpoileris filled now; the producer variant pins #672 against live markup instead of a synthetic crawler.Verification
composer quality:staticclean.variants.jsononly.Not recorded: a user list with rewatch flags set. Four public lists (~1,200 items) all carry
is_rewatching0 or""; finding one needs a known user rather than a search, so it stays a coverage gap.