8000 Plan: record what the parser-correctness sweep proved by irfan-dahir · Pull Request #678 · jikan-me/jikan · GitHub
[go: up one dir, main page]

Skip to content

Plan: record what the parser-correctness sweep proved - #678

Merged
irfan-dahir merged 3 commits into
masterfrom
docs/plan-sweep-findings
Nov 12, 2026
Merged

irfan-dahir merged 3 commits into
masterfrom
docs/plan-sweep-findings

Conversation

@irfan-dahir
Copy link
Copy Markdown
Collaborator

Documentation only. PLAN.md still described the backlog as it stood before the sweep, in ways that would send the next person down dead ends.

What changed

  • The two "Bugs the corpus found, NOT fixed yet (owner decision)" are fixed — verified today: genre page 1 reports hasNextPage=true, lastVisiblePage=20 (manga too), and Miyazaki's publishedManga returns 14 entries.
  • 41 fields remain never filled → 19, and all 19 are triaged.
  • New Parser-correctness sweep (2026-11-11) section: what the two signals are, the two batches in review (Parser-correctness sweep, batch 1: streaming attribution link, empty background, search synopsis #676/fixtures#21, Parser-correctness sweep, batch 2: a card with an empty Source property is null #677/fixtures#22), invariant debt 34 → 10, and the verdict on each witness group:
    • explicitGenres — MAL removed the sidebar row (40 recorded detail pages, including an R+ title)
    • episode filler/recap — not on the single-episode page at all
    • user-list studios/licensors/season*/magazines/addedToList — null/false upstream on two users, one checked live today
    • five hasNextPage flags — those recordings genuinely have no next page
    • isSpoiler — no spoiler-tagged review on that user's page; anime reviews tag and parse fine
  • Records the one fragile spot found: getSource() selects the second property by position, so a new property inserted before "Source" would return a wrong value silently.
  • Leaves the deprecate-or-derive decision open, with the two options named.

No code, no changelog (nothing consumer-visible). composer quality green at 1059 tests.

Two bugs the plan listed as deferred are fixed (genre pagination,
Miyazaki's published manga), the witness count is 19 rather than 41, and
all 19 are upstream absence or recording coverage rather than parser bugs.
Adds the sweep section with the invariant debt (34 -> 10), the two batches
in review, and the open deprecate-or-derive decision.
The witness count drops to 18 once the recordings in #681 land, the
Source-selector check covered both seasonal pages (92/92 and 420/421, not
420/421 overall), and the deprecate-or-derive question was settled in
#680. The stale 38-field line in the audit questions now points at the
triage instead of asking again.
fixtures#21/#22/#23 and jikan#676/#677/#680/#681 merged today, so the
section no longer describes work in flight and the witness count is 18
rather than 19.
@irfan-dahir
irfan-dahir force-pushed the docs/plan-sweep-findings branch from 1745b77 to 363abfb Compare November 12, 2026 13:19
@irfan-dahir
irfan-dahir merged commit 8be4640 into master Nov 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0