You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build: bump the pkgs locked_commit so the sandbox's rust is the pinned 1.99.1 - #3250
The agent runtime's verify box, and every min session and task on this repository, gets its rust from the gominimal/pkgs commit in [upstream]. At the current locked_commit (fe10f54c, 2026-10-27), that rust is 1.99.0. rust-toolchain.toml has pinned 1.99.1 since #2645, and CI honours that pin through rustup, so the box and CI compiled with different rustc versions. The runtime's coder runs on #3243 (job 3aaed600 and revise round e702db3b) recorded "the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml".
Change
.minimal/minimal.toml: locked_commit moves from fe10f54c to 981dbe7a ("Update rust to 1.99.1", gominimal/pkgs#1107), three commits later on pkgs main. The whole range:
virtio-kernel and minvmd-rootfs do not depend on any of these. libkrun builds with rust, so its hash changes. It resolves from the remote cache at the new pin; I checked aarch64 locally.
Proof
Locally, on aarch64, at the new pin:
A task with packages = ["base", "coreutils", "bash", "rust", "gcc", "cargo-nextest"] printed rustc 1.99.1 (58cf8f9c3 2026-10-13), cargo 1.99.1 and cargo-nextest 0.9.145, and it resolved in 19 s.
I ran the agent runtime's injected runtime-implement-verify (agent-verify's body, with the runtime's rustc probe) in min task run. It printed __RUSTC_VERSION__ rustc 1.99.1 (58cf8f9c3 2026-10-13).
Companion
The 101 on #3243's verify was a separate bug: cargo nextest was missing from the box. The runtime read only the legacy [session] table that #3125 moved to [defaults.session]. That is fixed in gominimal/agent-runtime#471. This PR is what makes the box's rustc match the pin.
Summary by CodeRabbit
Chores
Updated the tracked upstream revision. No user-facing changes are noted.
…d 1.99.1
Moves the pkgs locked_commit from fe10f54c to 981dbe7a, "Update rust to
1.99.1" (pkgs#1107), three commits later on 2026-10-27. rust-toolchain.toml
has pinned 1.99.1 since #2645, but the rust package at fe10f54c is 1.99.0,
so every min session and task, including the agent runtime's verify box,
compiled with a rustc the repository does not pin. The rest of the range
is python 3.14.9 -> 3.14.10 (pkgs#1108) and biome 2.6.2 -> 2.6.3
(pkgs#1118).
No actionable comments were generated in the recent review.
Walkthrough
The upstream locked_commit value in .minimal/minimal.toml changed from fe10f54c021665a5432e64f75988a0a3f926e791 to 981dbe7a6f43a704c559b3a244c24f0f3dcfc645.
Changes: Package-set pin
Layer / File(s)
Summary
Update locked commit .minimal/minimal.toml
The configured upstream locked_commit changed to 981dbe7a6f43a704c559b3a244c24f0f3dcfc645.
gominimal/minimal#2670: Advances the same locked_commit pin to the value used before this change.
gominimal/minimal#2637: Advances the same locked_commit pin to the earlier value in the update sequence.
Suggested reviewers:agent-137, bryan-minimal
Merge Risk: Minimal · up to 6ed8d
The package-set pin updates Rust and related tools. No merge-blocking risk is established.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly describes the lockfile update and its purpose: aligning the sandbox Rust version with the repository’s 1.99.1 pin.
Description check
The description explains the change, its purpose, related work, and reported validation. It uses different headings from the template and omits the Checklist section, but it is otherwise detailed and …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the change, its purpose, related work, and reported validation. It uses different headings from the template and omits the Checklist section, but it is otherwise detailed and substantially covers the required summary and testing information.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the pinned hash, Then marks the changed commit with care. One value moves; the rest stays still, A neat new line is waiting there. The rabbit hops away at last.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 845c9cbe-b897-4529-b6c4-ce217d04093d
Commits
Reviewing files that changed from the base of the PR and between cc57cd0 and 6ed8d69.
Files selected for processing: 1
.minimal/minimal.toml
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
One line, and it says what it does: locked_commit moves fe10f54c to 981dbe7a. I checked the range on pkgs: exactly the three commits the description lists (rust 1.99.1, python 3.14.10, biome 2.6.3), nothing else between them, so the box's rust now matches rust-toolchain.toml's pin and CI's rustup, which is the whole point. The proof is the right one (the runtime's own rustc probe printing 1.99.1 in a min task run), and the companion note on cargo nextest keeps the two causes of the #3243 verify failure apart.
Lab reading at 6ed8d69, with the new pin: the full CI mirror on Linux (workspace nextest, the native daemon e2e, clippy, doctests) passes at this tree, and the baseline (install sanity and a session's packages from the pinned registry) holds against the current release on Ubuntu 24.04, Fedora and Debian 12. Nothing regressed on the lab side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The agent runtime's verify box, and every min session and task on this repository, gets its
rustfrom the gominimal/pkgs commit in[upstream]. At the currentlocked_commit(fe10f54c, 2026-10-27), thatrustis 1.99.0.rust-toolchain.tomlhas pinned 1.99.1 since #2645, and CI honours that pin through rustup, so the box and CI compiled with different rustc versions. The runtime's coder runs on #3243 (job3aaed600and revise rounde702db3b) recorded "the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml".Change
.minimal/minimal.toml:locked_commitmoves from fe10f54c to 981dbe7a ("Update rust to 1.99.1", gominimal/pkgs#1107), three commits later on pkgs main. The whole range:virtio-kernelandminvmd-rootfsdo not depend on any of these.libkrunbuilds withrust, so its hash changes. It resolves from the remote cache at the new pin; I checked aarch64 locally.Proof
Locally, on aarch64, at the new pin:
packages = ["base", "coreutils", "bash", "rust", "gcc", "cargo-nextest"]printedrustc 1.99.1 (58cf8f9c3 2026-10-13),cargo 1.99.1andcargo-nextest 0.9.145, and it resolved in 19 s.runtime-implement-verify(agent-verify's body, with the runtime's rustc probe) inmin task run. It printed__RUSTC_VERSION__ rustc 1.99.1 (58cf8f9c3 2026-10-13).Companion
The 101 on #3243's verify was a separate bug:
cargo nextestwas missing from the box. The runtime read only the legacy[session]table that #3125 moved to[defaults.session]. That is fixed in gominimal/agent-runtime#471. This PR is what makes the box's rustc match the pin.Summary by CodeRabbit