Repository navigation
build(toolchain): bump the pinned Rust from 1.99.0 to 1.99.1 - #2645
Conversation
Stable moved to 1.99.1 on 2026-10-13. The MSRV floor is unchanged, `cargo fmt --check` and `cargo clippy --workspace --all-targets -D warnings` are clean on it with no code change, and the two workflow comments that name the pin follow it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update toolchain pin and references rust-toolchain.toml, .github/workflows/nightly-tests.yml |
The pinned Rust toolchain version changes to 1.99.1. The beta-canary and Miri comments also refer to 1.99.1. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related issues
gominimal/inbox#1165— This issue identifiesrust-toolchain.tomlas the maintenance path for the Rust toolchain pin.
Possibly related PRs
- gominimal/minimal#2339 — This PR changed the repository pin to Rust 1.99.0 and updated related workflow comments.
- gominimal/minimal#2494 — This PR updated the repository from Rust 1.97.0 to 1.99.0; this PR advances the pin to 1.99.1.
Merge Risk: 
62446
-
The toolchain pin and workflow references are aligned, with no workflow behavior changes.
Pre-merge checks: 
-
Check name Status Explanation Title check The title follows Conventional Commit format (build(toolchain): ...) and states the main change: the pinned Rust toolchain moves from 1.99.0 to 1.99.1. It is concise, specific, and matches the changes… Description check The description covers the Summary and Testing sections of the template. It explains the toolchain bump, the unchanged MSRV floor, the lack of code changes, and the matching workflow comment updates. … Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title follows Conventional Commit format (build(toolchain): ...) and states the main change: the pinned Rust toolchain moves from 1.99.0 to 1.99.1. It is concise, specific, and matches the changeset in rust-toolchain.toml and the two comments in nightly-tests.yml.
Full details: Description check
-
Explanation
The description covers the Summary and Testing sections of the template. It explains the toolchain bump, the unchanged MSRV floor, the lack of code changes, and the matching workflow comment updates. It also lists fmt, clippy, and workspace test runs on 1.99.1. The Checklist section is missing: the author did not mark whether docs were updated (they were, per the workflow comments) or whether a BREAKING CHANGE footer applies. The Testing section also gives no pasted command output, which the template asks for as evidence.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
CI annotation context is incomplete: annotation collection unavailable or limited
A rabbit checks the toolchain pin,
One point more, a tidy win.
The nightly notes now match the file,
Miri joins the same small change.
The rabbit hops through version land,
With 1.99.1 close at hand.
Comment @coderabbitai help to get the list of available commands.
|
Approved: no findings at Nothing to do. Clobber: none. |
Summary
Bumps the pinned toolchain (
rust-toolchain.toml) from 1.99.0 to 1.99.1, the current stable (2026-10-13). The MSRV floor is unchanged. No code change:cargo fmt --checkandcargo clippy --workspace --all-targets -- -D warningsare clean on 1.99.1 as they were on 1.99.0. The two workflow comments that name the pin (the beta canary and the miri override innightly-tests.yml) follow it, as #2494 did.Testing
fmt, clippy and the workspace tests through anvil's CI mirror on 1.99.1.
🤖 Generated with Claude Code
Summary by CodeRabbit