[go: up one dir, main page]
Page MenuHomePhabricator
People nliu

nliu (Nora Liu)
User

Projects

User Details

User Since
Aug 10 2026, 7:46 PM (9 w, 3 d)
Availability
Available
Review Queue
0

Recent Activity
View All

Yesterday

nliu added a comment to D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.

I removed the relazify guard in maybeRelazify as I initially thought constructors with inlined fields could be relazified and then recompiled without their field names. However, I've realized class constructors with fields can't be relazified so the guard never ran. The tests pass without it, and I also added a test for the delazify case

Thu, Oct 15, 6:36 PM · testing-approved
nliu updated the diff for D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Thu, Oct 15, 6:32 PM · testing-approved

Wed, Oct 14

nliu requested review of D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Wed, Oct 14, 8:40 PM · testing-approved
nliu added inline comments to D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Wed, Oct 14, 8:40 PM · testing-approved
nliu planned changes to D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Wed, Oct 14, 8:04 PM · testing-approved
nliu updated the diff for D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Wed, Oct 14, 8:04 PM · testing-approved
nliu added a comment to D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.

Addressed Yulia's comments for now, will address reviewhelper-bot's stale atom index next, since that is a larger change.

Wed, Oct 14, 3:47 AM · testing-approved
nliu planned changes to D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Wed, Oct 14, 3:46 AM · testing-approved
nliu requested review of D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Wed, Oct 14, 3:42 AM · testing-approved

Fri, Oct 9

nliu created D332616: Bug 2078425 - Inline class field initializers that just set 0 r?#spidermonkey-reviewers.
Fri, Oct 9, 10:41 PM · testing-approved

Thu, Sep 24

nliu updated the diff for D329034: Bug 2074585 - Skip CheckAliasedLexical check when reading .initializers. r?#spidermonkey-reviewers.
Thu, Sep 24, 8:24 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu accepted D326724: Bug 2072735 - Enable the SafeResolve jit-tests on all channels.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Thu, Sep 24, 8:10 PM · needs-testing-tag
nliu created D329034: Bug 2074585 - Skip CheckAliasedLexical check when reading .initializers. r?#spidermonkey-reviewers.
Thu, Sep 24, 7:56 PM · testing-exception-unchanged (Doesn't change behavior for users)

Mon, Sep 21

nliu updated the diff for D327400: Bug 1276097 - Add a bytecode sanity check r?#spidermonkey-reviewers.
Mon, Sep 21, 6:34 PM · testing-exception-unchanged (Doesn't change behavior for users)

Fri, Sep 18

nliu updated the diff for D327400: Bug 1276097 - Add a bytecode sanity check r?#spidermonkey-reviewers.
Fri, Sep 18, 4:14 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu created D327400: Bug 1276097 - Add a bytecode sanity check r?#spidermonkey-reviewers.
Fri, Sep 18, 4:06 PM · testing-exception-unchanged (Doesn't change behavior for users)

Sep 16 2026

nliu updated nliu.
Sep 16 2026, 2:12 PM
nliu removed a watcher for spidermonkey-reviewers: nliu.
Sep 16 2026, 2:11 PM
nliu added a watcher for spidermonkey-reviewers: nliu.
Sep 16 2026, 2:11 PM

Sep 10 2026

nliu added a comment to D324997: WIP: Bug 1454919 - Move BytecodeRange and BytecodeRangeWithPosition to vm/BytecodeIterator-inl.h.

Superseded by D325058 (duplicate created due to a moz-phab submit issue): https://phabricator.services.mozilla.com/D325058

Sep 10 2026, 4:06 PM
nliu abandoned D324997: WIP: Bug 1454919 - Move BytecodeRange and BytecodeRangeWithPosition to vm/BytecodeIterator-inl.h.
Sep 10 2026, 4:01 PM
nliu created D325058: Bug 1454919 - Move BytecodeRange and BytecodeRangeWithPosition to vm/BytecodeIterator-inl.h r=bthrall.
Sep 10 2026, 4:00 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu planned changes to D324997: WIP: Bug 1454919 - Move BytecodeRange and BytecodeRangeWithPosition to vm/BytecodeIterator-inl.h.
Sep 10 2026, 2:55 PM

Sep 1 2026

nliu updated the diff for D322740: Bug 1504900 - Add documentation comment explaining EitherParser's purpose r=arai.
Sep 1 2026, 8:54 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu created D322740: Bug 1504900 - Add documentation comment explaining EitherParser's purpose r=arai.
Sep 1 2026, 8:31 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu created D322697: Bug 1934274 - Remove ParserSharedBase into ParserBase r=bthrall.
Sep 1 2026, 6:22 PM · testing-exception-unchanged (Doesn't change behavior for users)

Aug 24 2026

nliu updated the diff for D320445: Bug 2062535 - Migrate to using printf_stderr in the GC r=bthrall.
Aug 24 2026, 8:22 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu updated the diff for D320445: Bug 2062535 - Migrate to using printf_stderr in the GC r=bthrall.
Aug 24 2026, 6:03 PM · testing-exception-unchanged (Doesn't change behavior for users)

Aug 21 2026

nliu updated the diff for D320445: Bug 2062535 - Migrate to using printf_stderr in the GC r=bthrall.
Aug 21 2026, 4:04 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu updated the diff for D320445: Bug 2062535 - Migrate to using printf_stderr in the GC r=bthrall.
Aug 21 2026, 3:56 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu created D320445: Bug 2062535 - Migrate to using printf_stderr in the GC r=bthrall.
Aug 21 2026, 2:28 PM · testing-exception-unchanged (Doesn't change behavior for users)

Aug 17 2026

nliu added a reviewer for D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall: devtools-reviewers.
Aug 17 2026, 5:43 PM · testing-approved
nliu requested review of D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall.
Aug 17 2026, 5:42 PM · testing-approved
nliu updated the diff for D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall.
Aug 17 2026, 5:25 PM · testing-approved
nliu removed a reviewer for D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall: devtools-reviewers.
Aug 17 2026, 5:06 PM · testing-approved
nliu updated the diff for D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall.
Aug 17 2026, 5:00 PM · testing-approved
nliu requested review of D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall.
Aug 17 2026, 4:39 PM · testing-approved
nliu added a reviewer for D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall: mgaudet.
Aug 17 2026, 4:25 PM · testing-approved

Aug 14 2026

nliu created D318786: Bug 2044163 - Remove Debugger.onNewPromise r=bthrall.
Aug 14 2026, 5:57 PM · testing-approved

Aug 10 2026

nliu added a comment to D317650: Bug 2062405 - Fix typo in emitWeapMapBarrierFastPath. r?tcampbell.

This is a typo fix. I ran ./mach jit-test --ion

Aug 10 2026, 8:51 PM · testing-exception-unchanged (Doesn't change behavior for users)
nliu created D317650: Bug 2062405 - Fix typo in emitWeapMapBarrierFastPath. r?tcampbell.
Aug 10 2026, 8:49 PM · testing-exception-unchanged (Doesn't change behavior for users)
Privacy · Cookies · Legal