WIP: Bug 1454919 - Move BytecodeRange and BytecodeRangeWithPosition to vm/BytecodeIterator-inl.h
AbandonedPublicDraft
Actions

Authored by nliu on Sep 10 2026, 2:55 PM.

Details

Reviewers: None
Bugzilla Bug ID: 1454919

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland
Branch: HEAD

Event Timeline

nliu planned changes to this revision.Sep 10 2026, 2:55 PM

nliu created this revision.

Herald added a project: secure-revision. · View Herald TranscriptSep 10 2026, 2:55 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Sep 10 2026, 2:57 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

(Reviewing Diff 1371990)

Summary

Intent

The goal of this change is to consolidate bytecode iteration utilities into a single, common header file. Specifically, the BytecodeRange and BytecodeRangeWithPosition classes (along with the SkipPrologueOps enum) were located in vm/BytecodeUtil-inl.h, but they logically belong with other bytecode iteration infrastructure in vm/BytecodeIterator-inl.h. This is part of a broader effort (Bug 1454919) to organize bytecode iterators and related gadgets into a common, dedicated header.

Solution

The BytecodeRange class, the SkipPrologueOps enum, and the BytecodeRangeWithPosition class are moved verbatim from vm/BytecodeUtil-inl.h to vm/BytecodeIterator-inl.h. The necessary #include directives for frontend/SourceNotes.h and js/ColumnNumber.h are also relocated to the new file to support the moved code's dependencies. The consuming file debugger/Script.cpp has its #include updated from vm/BytecodeUtil-inl.h to vm/BytecodeIterator-inl.h to reflect the new location of BytecodeRangeWithPosition. No functional changes are made to any of the moved classes or their logic—this is a pure code reorganization.