nbp (Nicolas B. Pierron)
User

Projects

spidermonkey-reviewers
Group

User Details

User Since: Sep 13 2018, 12:04 PM (422 w, 1 d)
Availability: Available
Review Queue: 2

Recent Activity
View All

Jun 9 2026

nbp accepted D305464: Bug 2045957 - Initialize BaselineFrame return value slot in OnLeaveBaselineFrame. r?#spidermonkey-reviewers!.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Jun 9 2026, 11:26 AM · testing-exception-other (Please leave a comment explaining why)

nbp abandoned D305511: WIP: Bug 1913924 part 12 - Use inlCallVM for CodeGenerator::visitOutOfLineICFallback..

Jun 9 2026, 10:41 AM

nbp abandoned D305501: WIP: Bug 1913924 part 2 - Convert most callVM to trampoline callVM in BaselineCacheIRCompiler.cpp..

Jun 9 2026, 10:41 AM

nbp planned changes to D305555: WIP: Bug 1913924 part 23 - inlineVMCall: Handle the lack of free registers in enterExitFrame..

Jun 9 2026, 10:20 AM

nbp planned changes to D305554: WIP: Bug 1913924 part 22 - Split pushRooted into pushRootedArg and pushRootedCode..

Jun 9 2026, 10:20 AM

nbp planned changes to D305553: WIP: Bug 1913924 part 21 - inlineVMCall handle failures on all platforms..

Jun 9 2026, 10:20 AM

nbp planned changes to D305552: WIP: Bug 1913924 part 20 - Add support for ensureOSISpace..

Jun 9 2026, 10:20 AM

nbp planned changes to D305551: WIP: Bug 1913924 part 19 - Convert remaining CodeGenerator VM calls to inlined versions..

Jun 9 2026, 10:20 AM

nbp planned changes to D305550: WIP: Bug 1913924 part 18 - Add AllocatableRegisterSet::takeWithDefault..

Jun 9 2026, 10:20 AM

nbp planned changes to D305549: WIP: Bug 1913924 part 17 - Inline InvokeFunction VM function calls..

Jun 9 2026, 10:19 AM

nbp planned changes to D305548: WIP: Bug 1913924 part 16 - Convert visitProxyGet to use inlCallVM..

Jun 9 2026, 10:19 AM

nbp planned changes to D305547: WIP: Bug 1913924 part 15 - Convert visitCreateThis callVM to inlCallVM..

Jun 9 2026, 10:19 AM

nbp planned changes to D305546: WIP: Bug 1913924 part 14 - Convert visitStringReplace callVM by inlCallVM..

Jun 9 2026, 10:19 AM

nbp planned changes to D305545: WIP: Bug 1913924 part 13 - Use inlCallVM for Ion RegExp out-of-line function calls..

Jun 9 2026, 10:19 AM

nbp planned changes to D305543: WIP: Bug 1913924 part 12 - Use inlCallVM for CodeGenerator::visitOutOfLineICFallback..

Jun 9 2026, 10:19 AM

nbp planned changes to D305542: WIP: Bug 1913924 part 11 - Add CodeGenerator::inlCallVM..

Jun 9 2026, 10:19 AM

nbp planned changes to D305541: WIP: Bug 1913924 part 10 - inlineVMCall: Add immGCPtr, TypedOrValueRegister and ConstantOrRegister types..

Jun 9 2026, 10:19 AM

nbp planned changes to D305540: WIP: Bug 1913924 part 9 - Add AnyRegister methods to AllocatableGeneralRegisterSet..

Jun 9 2026, 10:19 AM

nbp planned changes to D305539: WIP: Bug 1913924 part 8 - Add parameters for tuning inlined VM calls based on the caller..

Jun 9 2026, 10:19 AM

nbp planned changes to D305538: WIP: Bug 1913924 part 7 - Inline most BaselineICs calls to VMFunctions..

Jun 9 2026, 10:19 AM

nbp planned changes to D305537: WIP: Bug 1913924 part 6 - Add MacroAssembler::inlineVMCall..

Jun 9 2026, 10:18 AM

nbp planned changes to D305536: WIP: Bug 1913924 part 5 - Update the ExitFrameFooter to include an extra bit next to the VMFunctionId..

Jun 9 2026, 10:18 AM

nbp planned changes to D305535: WIP: Bug 1913924 part 4 - Expose GetVMFunctionTarget publicly..

Jun 9 2026, 10:18 AM

nbp planned changes to D305534: WIP: Bug 1913924 part 3 - Add Support for MoveOperand for immediate values..

Jun 9 2026, 10:18 AM

nbp planned changes to D305533: WIP: Bug 1913924 part 2 - Convert most callVM to trampoline callVM in BaselineCacheIRCompiler.cpp..

Jun 9 2026, 10:18 AM

nbp planned changes to D305532: WIP: Bug 1913924 part 1 - Add a wrapper around trampoline based call VM..

Jun 9 2026, 10:18 AM

nbp abandoned D305525: WIP: Bug 1913924 part 13 - Use inlCallVM for Ion RegExp out-of-line function calls..

Jun 9 2026, 10:10 AM

nbp abandoned D305524: WIP: Bug 1913924 part 12 - Use inlCallVM for CodeGenerator::visitOutOfLineICFallback..

Jun 9 2026, 10:10 AM

nbp abandoned D305523: WIP: Bug 1913924 part 11 - Add CodeGenerator::inlCallVM..

Jun 9 2026, 10:10 AM

nbp abandoned D305521: WIP: Bug 1913924 part 9 - Add AnyRegister methods to AllocatableGeneralRegisterSet..

Jun 9 2026, 10:10 AM

nbp abandoned D305522: WIP: Bug 1913924 part 10 - inlineVMCall: Add immGCPtr, TypedOrValueRegister and ConstantOrRegister types..

Jun 9 2026, 10:10 AM

nbp abandoned D305520: WIP: Bug 1913924 part 8 - Add parameters for tuning inlined VM calls based on the caller..

Jun 9 2026, 10:10 AM

nbp abandoned D305519: WIP: Bug 1913924 part 7 - Inline most BaselineICs calls to VMFunctions..

Jun 9 2026, 10:10 AM

nbp abandoned D305518: WIP: Bug 1913924 part 6 - Add MacroAssembler::inlineVMCall..

Jun 9 2026, 10:10 AM

nbp abandoned D305517: WIP: Bug 1913924 part 5 - Update the ExitFrameFooter to include an extra bit next to the VMFunctionId..

Jun 9 2026, 10:10 AM

nbp abandoned D305516: WIP: Bug 1913924 part 4 - Expose GetVMFunctionTarget publicly..

Jun 9 2026, 10:10 AM

nbp abandoned D305515: WIP: Bug 1913924 part 3 - Add Support for MoveOperand for immediate values..

Jun 9 2026, 10:09 AM

nbp abandoned D305514: WIP: Bug 1913924 part 2 - Convert most callVM to trampoline callVM in BaselineCacheIRCompiler.cpp..

Jun 9 2026, 10:09 AM

nbp abandoned D305513: WIP: Bug 1913924 part 1 - Add a wrapper around trampoline based call VM..

Jun 9 2026, 10:09 AM

nbp abandoned D305512: WIP: Bug 1913924 part 13 - Use inlCallVM for Ion RegExp out-of-line function calls..

Jun 9 2026, 10:09 AM

nbp abandoned D305510: WIP: Bug 1913924 part 11 - Add CodeGenerator::inlCallVM..

Jun 9 2026, 10:09 AM

nbp abandoned D305509: WIP: Bug 1913924 part 10 - inlineVMCall: Add immGCPtr, TypedOrValueRegister and ConstantOrRegister types..

Jun 9 2026, 10:09 AM

nbp abandoned D305508: WIP: Bug 1913924 part 9 - Add AnyRegister methods to AllocatableGeneralRegisterSet..

Jun 9 2026, 10:08 AM

nbp abandoned D305507: WIP: Bug 1913924 part 8 - Add parameters for tuning inlined VM calls based on the caller..

Jun 9 2026, 10:08 AM

nbp abandoned D305505: WIP: Bug 1913924 part 6 - Add MacroAssembler::inlineVMCall..

Jun 9 2026, 10:08 AM

nbp abandoned D305506: WIP: Bug 1913924 part 7 - Inline most BaselineICs calls to VMFunctions..

Jun 9 2026, 10:08 AM

nbp abandoned D305504: WIP: Bug 1913924 part 5 - Update the ExitFrameFooter to include an extra bit next to the VMFunctionId..

Jun 9 2026, 10:08 AM

nbp abandoned D305503: WIP: Bug 1913924 part 4 - Expose GetVMFunctionTarget publicly..

Jun 9 2026, 10:08 AM

nbp abandoned D305502: WIP: Bug 1913924 part 3 - Add Support for MoveOperand for immediate values..

Jun 9 2026, 10:08 AM

nbp abandoned D305500: WIP: Bug 1913924 part 1 - Add a wrapper around trampoline based call VM..

Jun 9 2026, 10:08 AM

nbp planned changes to D305525: WIP: Bug 1913924 part 13 - Use inlCallVM for Ion RegExp out-of-line function calls..

Jun 9 2026, 10:04 AM

nbp planned changes to D305524: WIP: Bug 1913924 part 12 - Use inlCallVM for CodeGenerator::visitOutOfLineICFallback..

Jun 9 2026, 10:04 AM

nbp planned changes to D305523: WIP: Bug 1913924 part 11 - Add CodeGenerator::inlCallVM..

Jun 9 2026, 10:04 AM

nbp planned changes to D305522: WIP: Bug 1913924 part 10 - inlineVMCall: Add immGCPtr, TypedOrValueRegister and ConstantOrRegister types..

Jun 9 2026, 10:04 AM

nbp planned changes to D305521: WIP: Bug 1913924 part 9 - Add AnyRegister methods to AllocatableGeneralRegisterSet..

Jun 9 2026, 10:04 AM

nbp planned changes to D305520: WIP: Bug 1913924 part 8 - Add parameters for tuning inlined VM calls based on the caller..

Jun 9 2026, 10:03 AM

nbp planned changes to D305519: WIP: Bug 1913924 part 7 - Inline most BaselineICs calls to VMFunctions..

Jun 9 2026, 10:03 AM

nbp planned changes to D305518: WIP: Bug 1913924 part 6 - Add MacroAssembler::inlineVMCall..

Jun 9 2026, 10:03 AM

nbp planned changes to D305517: WIP: Bug 1913924 part 5 - Update the ExitFrameFooter to include an extra bit next to the VMFunctionId..

Jun 9 2026, 10:03 AM

nbp planned changes to D305516: WIP: Bug 1913924 part 4 - Expose GetVMFunctionTarget publicly..

Jun 9 2026, 10:03 AM

nbp planned changes to D305515: WIP: Bug 1913924 part 3 - Add Support for MoveOperand for immediate values..

Jun 9 2026, 10:03 AM

nbp planned changes to D305514: WIP: Bug 1913924 part 2 - Convert most callVM to trampoline callVM in BaselineCacheIRCompiler.cpp..

Jun 9 2026, 10:03 AM

nbp planned changes to D305513: WIP: Bug 1913924 part 1 - Add a wrapper around trampoline based call VM..

Jun 9 2026, 10:03 AM

nbp planned changes to D305512: WIP: Bug 1913924 part 13 - Use inlCallVM for Ion RegExp out-of-line function calls..

Jun 9 2026, 10:01 AM

nbp planned changes to D305511: WIP: Bug 1913924 part 12 - Use inlCallVM for CodeGenerator::visitOutOfLineICFallback..

Jun 9 2026, 10:01 AM

nbp planned changes to D305510: WIP: Bug 1913924 part 11 - Add CodeGenerator::inlCallVM..

Jun 9 2026, 10:01 AM

nbp planned changes to D305509: WIP: Bug 1913924 part 10 - inlineVMCall: Add immGCPtr, TypedOrValueRegister and ConstantOrRegister types..

Jun 9 2026, 10:01 AM

nbp planned changes to D305508: WIP: Bug 1913924 part 9 - Add AnyRegister methods to AllocatableGeneralRegisterSet..

Jun 9 2026, 10:01 AM

nbp planned changes to D305507: WIP: Bug 1913924 part 8 - Add parameters for tuning inlined VM calls based on the caller..

Jun 9 2026, 10:01 AM

nbp planned changes to D305506: WIP: Bug 1913924 part 7 - Inline most BaselineICs calls to VMFunctions..

Jun 9 2026, 10:01 AM

nbp planned changes to D305505: WIP: Bug 1913924 part 6 - Add MacroAssembler::inlineVMCall..

Jun 9 2026, 10:01 AM

nbp planned changes to D305504: WIP: Bug 1913924 part 5 - Update the ExitFrameFooter to include an extra bit next to the VMFunctionId..

Jun 9 2026, 10:01 AM

nbp planned changes to D305503: WIP: Bug 1913924 part 4 - Expose GetVMFunctionTarget publicly..

Jun 9 2026, 10:00 AM

nbp planned changes to D305502: WIP: Bug 1913924 part 3 - Add Support for MoveOperand for immediate values..

Jun 9 2026, 10:00 AM

nbp planned changes to D305501: WIP: Bug 1913924 part 2 - Convert most callVM to trampoline callVM in BaselineCacheIRCompiler.cpp..

Jun 9 2026, 10:00 AM

nbp planned changes to D305500: WIP: Bug 1913924 part 1 - Add a wrapper around trampoline based call VM..

Jun 9 2026, 10:00 AM

Jun 8 2026

nbp created D305340: Bug 2044606 - Object.keys optimization should split resume points. r=jandem.

Jun 8 2026, 5:45 PM

nbp edited projects for D304933: Bug 1966606 - Updated register allocator to use new API and removed old one. r=emilio,nbp, added: testing-exception-unchanged (Doesn't change behavior for users); removed testing-approved.

Jun 8 2026, 10:13 AM · testing-exception-unchanged (Doesn't change behavior for users)

nbp accepted D304933: Bug 1966606 - Updated register allocator to use new API and removed old one. r=emilio,nbp.

This sounds good to me.
LiveBundle are not supposed to be owned by the PriorityQuere, and as such we should not expect any bad references after popping the highest queue item.

Jun 8 2026, 10:13 AM · testing-exception-unchanged (Doesn't change behavior for users)

Jun 3 2026

nbp accepted D304367: Bug 2044510: Pass already_AddRefed types by-value instead of by rvalue reference, in js/. r?#spidermonkey-reviewers.

Jun 3 2026, 12:02 PM · testing-exception-unchanged (Doesn't change behavior for users)

Jun 2 2026

nbp planned changes to D304025: WIP: Bug 2042605 - Add test case..

Jun 2 2026, 10:17 AM

Jun 1 2026

nbp accepted D303735: Bug 2029719 - Ignore --selfhosted-xdr-* options with --fuzzing-safe. r?nbp!.

Jun 1 2026, 12:28 PM · testing-exception-unchanged (Doesn't change behavior for users)

May 28 2026

nbp created D303150: Bug 2043309 - Handle coverage in interpreted code when resuming generators. r=bthrall.

May 28 2026, 5:32 PM · testing-approved

nbp updated the uplift request field for D303019: Bug 2042907 - Use the script loader's document in EvaluateScriptElements..

May 28 2026, 12:25 PM

nbp created D303019: Bug 2042907 - Use the script loader's document in EvaluateScriptElements..

May 28 2026, 12:24 PM

nbp accepted D302803: Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r?iain!.

I do not see the reason for changing the argument order in DumpBlockTableRows, and I do not really care to be honest.
Overall, this is change sounds good to me.

May 28 2026, 10:15 AM · testing-exception-unchanged (Doesn't change behavior for users)

May 27 2026

nbp created D302836: Bug 2042907 - Use the script loader's document in EvaluateScriptElements. r=emilio.

May 27 2026, 5:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

nbp added a comment to D301039: [do not land yet] Bug 2043865 - Add clang-plugin for listener calls r=#necko.

Is this only running scripts? Are scripts the only thing that can cause the references to be dropped?

May 27 2026, 10:26 AM · needs-testing-tag

nbp added inline comments to D302601: Bug 2036929 - Hold strong ref while calling nsIStreamListener methods r=#necko.

May 27 2026, 9:53 AM · testing-approved

May 22 2026

nbp abandoned D301860: Bug 1913924 part 22 - Split pushRooted into pushRootedArg and pushRootedCode. r=iain.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301859: Bug 1913924 part 21 - inlineVMCall handle failures on all platforms. r=iain.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301858: Bug 1913924 part 20 - Add support for ensureOSISpace. r=iain.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301857: Bug 1913924 part 19 - Convert remaining CodeGenerator VM calls to inlined versions. r=#spidermonkey-reviewers.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301855: Bug 1913924 part 17 - Inline InvokeFunction VM function calls. r=#spidermonkey-reviewers.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301856: Bug 1913924 part 18 - Add AllocatableRegisterSet::takeWithDefault. r=iain.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301854: Bug 1913924 part 16 - Convert visitProxyGet to use inlCallVM. r=#spidermonkey-reviewers.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301853: Bug 1913924 part 15 - Convert visitCreateThis callVM to inlCallVM. r=#spidermonkey-reviewers.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301861: Bug 1913924 part 14 - Convert visitStringReplace callVM by inlCallVM. r=#spidermonkey-reviewers.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301850: Bug 1913924 part 13 - Use inlCallVM for Ion RegExp out-of-line function calls. r=#spidermonkey-reviewers.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM

nbp abandoned D301849: Bug 1913924 part 12 - Use inlCallVM for CodeGenerator::visitOutOfLineICFallback. r=#spidermonkey-reviewers.

People are not interested in these changes until everything is working properly and we have performance numbers ready ahead of publication of the patches.
Maybe I will submit them again later with everything addressed …

May 22 2026, 9:27 AM