Details

Reviewers

nbp
mgaudet

Commits

rFIREFOXAUTOLAND4e31aad1a6d2: Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r=nbp,mgaudet

Bugzilla Bug ID

2036825

Summary

JIT spew is currently backed by a file output stream (such as stderr) so it's
possible to just call JitSpewPrinter() and write to it. When we start using
MOZ_LOG/JS_LOG this will no longer work because we want to log a single
message/line at a time with logPrint.

This patch replaces these uses (and uses of JitSpew{Start,Cont,Finish}) with an
AutoJitSpewMessage RAII class that buffers the spew and writes it in its destructor.
This lets us switch to MOZ_LOG/JS_LOG in the next patch.

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

jandem created this revision.May 27 2026, 3:54 PM

Herald added a project: secure-revision. · View Herald TranscriptMay 27 2026, 3:54 PM

jandem added a child revision: D302804: Bug 2036825 part 4 - Use JS_LOG as backend for JitSpew. r?iain!.May 27 2026, 3:54 PM

phab-bot published this revision for review.May 27 2026, 3:56 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: nbp. · View Herald TranscriptMay 27 2026, 3:56 PM

Herald added a subscriber: rhunt. · View Herald Transcript

jandem updated this revision to Diff 1284389.May 27 2026, 3:58 PM

Harbormaster completed remote builds in B975878: Diff 1284382.May 27 2026, 4:14 PM

Harbormaster completed remote builds in B975885: Diff 1284389.

Just a logging change.

I do not see the reason for changing the argument order in DumpBlockTableRows, and I do not really care to be honest.
Overall, this is change sounds good to me.

jandem updated this revision to Diff 1285294.May 28 2026, 11:22 AM

In D302803#10513831, @nbp wrote:

I do not see the reason for changing the argument order in DumpBlockTableRows, and I do not really care to be honest.

Oops yeah that was leftover from a refactoring for a different approach. I've reverted that change.

Harbormaster completed remote builds in B976590: Diff 1285294.May 28 2026, 11:52 AM

jandem edited reviewers, added: mgaudet; removed: iain.Jun 1 2026, 11:11 AM

mgaudet accepted this revision.Jun 1 2026, 5:50 PM

mgaudet added inline comments.

js/src/jit/shared/CodeGenerator-shared.cpp
323	Should you perhaps pass `msg` to this?

This revision is now accepted and ready to land.Jun 1 2026, 5:50 PM

jandem marked an inline comment as done.Jun 2 2026, 5:19 AM

jandem added inline comments.

js/src/jit/shared/CodeGenerator-shared.cpp
323	It's writing separate lines so not passing is okay. Actually I think this one could just be a plain `JitSpew(...)` call; it doesn't need `AutoJitSpewMessage`. The `JitSpewStart` call that was here before was unnecessary because there wasn't anything else on the same line.

jandem updated this revision to Diff 1289045.Jun 2 2026, 5:25 AM

jandem marked an inline comment as done.

jandem updated this revision to Diff 1289059.Jun 2 2026, 5:46 AM

I changed a few other places to use plain JitSpew for stand-alone lines. It reduces the scope of some AutoJitSpewMessages a bit.

Harbormaster completed remote builds in B979276: Diff 1289045.Jun 2 2026, 5:54 AM

Harbormaster completed remote builds in B979287: Diff 1289059.Jun 2 2026, 6:17 AM

Closed by commit rFIREFOXAUTOLAND4e31aad1a6d2: Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r=nbp,mgaudet (authored by jandem). · Explain WhyJun 2 2026, 6:37 AM

This revision was automatically updated to reflect the committed changes.

jandem added a commit: rFIREFOXAUTOLAND4e31aad1a6d2: Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r=nbp,mgaudet.

jandem mentioned this in rFIREFOXBETA4e31aad1a6d2: Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r=nbp,mgaudet.Jun 15 2026, 12:20 PM

jandem mentioned this in rFIREFOXRELEASE4e31aad1a6d2: Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r=nbp,mgaudet.Jul 15 2026, 8:29 PM

Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r?iain!
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1289088

js/src/jit/AliasAnalysis.cpp

js/src/jit/BacktrackingAllocator.cpp

js/src/jit/CodeGenerator.cpp

js/src/jit/EffectiveAddressAnalysis.cpp

js/src/jit/Ion.cpp

js/src/jit/JitSpewer.h

js/src/jit/JitSpewer.cpp

js/src/jit/JitcodeMap.cpp

js/src/jit/LIR.cpp

js/src/jit/Lowering.cpp

js/src/jit/RangeAnalysis.cpp

js/src/jit/RegisterAllocator.cpp

js/src/jit/Safepoints.cpp

js/src/jit/SimpleAllocator.cpp

js/src/jit/Snapshots.cpp

js/src/jit/StubFolding.cpp

js/src/jit/UnrollLoops.cpp

js/src/jit/WarpOracle.cpp

js/src/jit/arm/Simulator-arm.cpp

js/src/jit/shared/Assembler-shared.cpp

js/src/jit/shared/CodeGenerator-shared.cpp

js/src/jit/shared/IonAssemblerBufferWithConstantPools.h

js/src/wasm/WasmIonCompile.cpp

Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r?iain!ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1289088

js/src/jit/AliasAnalysis.cpp

js/src/jit/BacktrackingAllocator.cpp

js/src/jit/CodeGenerator.cpp

js/src/jit/EffectiveAddressAnalysis.cpp

js/src/jit/Ion.cpp

js/src/jit/JitSpewer.h

js/src/jit/JitSpewer.cpp

js/src/jit/JitcodeMap.cpp

js/src/jit/LIR.cpp

js/src/jit/Lowering.cpp

js/src/jit/RangeAnalysis.cpp

js/src/jit/RegisterAllocator.cpp

js/src/jit/Safepoints.cpp

js/src/jit/SimpleAllocator.cpp

js/src/jit/Snapshots.cpp

js/src/jit/StubFolding.cpp

js/src/jit/UnrollLoops.cpp

js/src/jit/WarpOracle.cpp

js/src/jit/arm/Simulator-arm.cpp

js/src/jit/shared/Assembler-shared.cpp

js/src/jit/shared/CodeGenerator-shared.cpp

js/src/jit/shared/IonAssemblerBufferWithConstantPools.h

js/src/wasm/WasmIonCompile.cpp

Bug 2036825 part 3 - Add and use AutoJitSpewMessage. r?iain!
ClosedPublic
Actions

Revision Contents
Changeset List