Paths

Table of Contentst

Differential D312007

Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including ModuleLoaderBase.h. r?#dom-worker-reviewers!
ClosedPublic
Actions

Authored by allstarschh on Jul 14 2026, 7:55 AM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Oct 13, 1:47 AM

	Unknown Object (File)
	Wed, Sep 30, 12:31 AM

	Unknown Object (File)
	Sep 5 2026, 8:33 AM

	Unknown Object (File)
	Aug 26 2026, 7:05 AM

	Unknown Object (File)
	Aug 23 2026, 1:48 PM

	Unknown Object (File)
	Aug 22 2026, 8:52 PM

	Unknown Object (File)
	Aug 17 2026, 12:38 AM

	Unknown Object (File)
	Aug 3 2026, 7:20 AM

View All 32 Files

Subscribers

anti-tracking-reviewers-rotation

Details

Reviewers

• tschuster
• bvandersloot
edenchuang
padenot

Group Reviewers

dom-worker-reviewers
media-playback-reviewers

Commits

rFIREFOXAUTOLANDdc14477eca78: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including…
rFIREFOXAUTOLANDc46250149aaa: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including…

Bugzilla Bug ID

Summary

ModuleLoaderBase.h is heavyweight and was pulled in transitively by ~50 headers
through WorkerPrivate.h, so editing it triggered a near-full rebuild.

WorkerPrivate.h: drop the unused #include "ScriptLoader.h".
WorkerScope.h: forward-declare JS::loader::ModuleLoaderBase and out-line InitModuleLoader into WorkerScope.cpp.
Add direct includes to files that were relying on the removed transitive include (some only exposed by non-unified builds).

Translation Unit Recompiled
$ rg -l --no-ignore --hidden --glob '*.o.pp' 'ModuleLoaderBase\.h' obj-x86_64-pc-linux-gnu | wc -l

Before this patch : 163
After this patch  : 49

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

allstarschh created this revision.Jul 14 2026, 7:55 AM

Herald added a project: secure-revision. · View Herald TranscriptJul 14 2026, 7:55 AM

Herald added a reviewer: necko-reviewers. · View Herald Transcript

allstarschh added a child revision: D312008: Bug 2054848 - Part 3: Stop dom/script and dom/workers ScriptLoader.h from including ModuleLoaderBase.h. r?#dom-worker-reviewers!,#dom-core-reviewers!.Jul 14 2026, 7:55 AM

phab-bot published this revision for review.Jul 14 2026, 7:56 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: • tschuster. · View Herald TranscriptJul 14 2026, 7:56 AM

Herald added a reviewer: media-playback-reviewers. · View Herald Transcript

Herald added a reviewer: anti-tracking-reviewers-rotation. · View Herald Transcript

Herald added subscribers: • tschuster, edgar, mayhemer. · View Herald Transcript

phab-bot added a reviewer: • bvandersloot.Jul 14 2026, 7:56 AM

phab-bot removed a reviewer: anti-tracking-reviewers-rotation.

phab-bot added a subscriber: anti-tracking-reviewers-rotation.

Harbormaster completed remote builds in B1003420: Diff 1321913.Jul 14 2026, 8:23 AM

r+ed for the worker part. Thank you.

allstarschh updated this revision to Diff 1322016.Jul 14 2026, 10:54 AM

allstarschh edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B1003476: Diff 1322016.Jul 14 2026, 11:19 AM

kershaw removed a reviewer: necko-reviewers.Jul 14 2026, 2:30 PM

r+ for dom/media

testing-exception-other: build only, no impact at run time.

mccr8 added a subscriber: mccr8.Jul 15 2026, 2:32 PM

mccr8 added inline comments.

dom/workers/WorkerScope.cpp
292	Would it be worth adding a comment that this is done out-of-line to prevent `ModuleLoaderBase.h` from being included everywhere? One of my gripes about this sort of include improvement work is that it is fragile.

allstarschh marked an inline comment as done.Jul 15 2026, 2:57 PM

allstarschh added inline comments.

dom/workers/WorkerScope.cpp
292	This is covered in D312254

mccr8 added inline comments.Jul 15 2026, 5:08 PM

dom/workers/WorkerScope.cpp
292	Excellent!

allstarschh updated this revision to Diff 1324393.Jul 16 2026, 8:37 PM

allstarschh marked an inline comment as done.

Harbormaster completed remote builds in B1005225: Diff 1324393.Jul 16 2026, 9:09 PM

allstarschh updated this revision to Diff 1324619.Jul 17 2026, 2:11 AM

Harbormaster completed remote builds in B1005375: Diff 1324619.Jul 17 2026, 2:40 AM

• bvandersloot accepted this revision.Jul 17 2026, 11:56 AM

This revision is now accepted and ready to land.Jul 17 2026, 11:56 AM

Closed by commit rFIREFOXAUTOLANDc46250149aaa: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including… (authored by allstarschh). · Explain WhyJul 19 2026, 1:45 AM

This revision was automatically updated to reflect the committed changes.

allstarschh added a commit: rFIREFOXAUTOLANDc46250149aaa: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including….

rperta reopened this revision.Jul 19 2026, 2:12 AM

This revision is now accepted and ready to land.Jul 19 2026, 2:12 AM

rperta added a reverting change: rFIREFOXAUTOLAND4acec8accc70: Revert "Bug 2054848 - Part 6: Add a lint forbidding new header #includes of….Jul 19 2026, 2:12 AM

allstarschh updated this revision to Diff 1325523.Jul 19 2026, 8:55 AM

Harbormaster completed remote builds in B1006087: Diff 1325523.Jul 19 2026, 9:27 AM

Closed by commit rFIREFOXAUTOLANDdc14477eca78: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including… (authored by allstarschh). · Explain WhyJul 19 2026, 9:32 AM

This revision was automatically updated to reflect the committed changes.

allstarschh added a commit: rFIREFOXAUTOLANDdc14477eca78: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including….

allstarschh mentioned this in rFIREFOXBETAc46250149aaa: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including….Jul 20 2026, 6:59 PM

allstarschh mentioned this in rFIREFOXBETAdc14477eca78: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including….

allstarschh mentioned this in rFIREFOXRELEASEc46250149aaa: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including….Aug 12 2026, 7:54 PM

allstarschh mentioned this in rFIREFOXRELEASEdc14477eca78: Bug 2054848 - Part 2: Stop WorkerPrivate.h and WorkerScope.h from including….

Revision Contents
Changeset List

Path

Size

accessible/

android/

DocAccessibleWrap.cpp

1 line

pdf/

PdfStructTreeBuilder.cpp

1 line

dom/

base/

EventSource.cpp

1 line

nsContentUtils.cpp

1 line

bindings/

BindingUtils.cpp

1 line

ipc/

WindowGlobalParent.cpp

1 line

media/

mediacontrol/

MediaStatusManager.cpp

1 line

permission/

PermissionStatusSink.cpp

1 line

security/

nsContentSecurityUtils.cpp

1 line

nsHTTPSOnlyUtils.cpp

1 line

workers/

WorkerPrivate.h

1 line

11 lines

WorkerScope.cpp

8 lines

netwerk/

base/

1 line

ipc/

DocumentLoadListener.cpp

1 line

toolkit/

components/

antitracking/

DynamicFpiNavigationHeuristic.cpp

1 line

Diff 1325530

accessible/android/DocAccessibleWrap.cpp

Loading...

accessible/pdf/PdfStructTreeBuilder.cpp

Loading...

dom/base/EventSource.cpp

Loading...

dom/base/nsContentUtils.cpp

Loading...

dom/bindings/BindingUtils.cpp

Loading...

dom/ipc/WindowGlobalParent.cpp

Loading...

dom/media/mediacontrol/MediaStatusManager.cpp

Loading...

dom/permission/PermissionStatusSink.cpp

Loading...

dom/security/nsContentSecurityUtils.cpp

Loading...

dom/security/nsHTTPSOnlyUtils.cpp

Loading...

dom/workers/WorkerPrivate.h

Loading...

dom/workers/WorkerScope.h

Loading...

dom/workers/WorkerScope.cpp

Loading...

netwerk/base/LoadInfo.cpp

Loading...

netwerk/ipc/DocumentLoadListener.cpp

Loading...

toolkit/components/antitracking/DynamicFpiNavigationHeuristic.cpp

Loading...