Repository navigation
Add the regions conformance group - #1288
Draft
justinhwang wants to merge 1 commit into
Draft
justinhwang wants to merge 1 commit into
justinhwang wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
justinhwang
force-pushed
the
conformance-4-regions
branch
from
November 5, 2026 18:50
11bdb48 to
7bdc2a1
Compare
|
Coverage is 99.758% — conformance-4-regions into conformance-3-hierarchy. No base build found for |
justinhwang
force-pushed
the
conformance-4-regions
branch
2 times, most recently
from
November 5, 2026 22:17
e90fa21 to
6048cca
Compare
Adds the record files and runner for polygonToCells, polygonToCellsExperimental in the four containment modes and cellsToLinkedMultiPolygon of the classic fill. Polygons are cell boundaries scaled by 0.8 and 1.2 about the center, with and without a hole, so that no cell vertex lies on a polygon edge, plus a fill at resolution 16 for the error case. The multipolygon is compared by structure and by points under the angular tolerance, each outer loop up to rotation and holes in any order. The curated file holds the polygon fixtures of the existing tests, the hemispheres and the CLI polygons. The files are the generator's output and are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
justinhwang
force-pushed
the
conformance-4-regions
branch
from
November 5, 2026 22:38
6048cca to
70d41cc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the record file and runner for the region functions.
Part of the conformance suite stack (#1292 → #1285 → #1286 → #1287 → #1288 → #1289 → #1290; #1292 is the macOS runner matrix fix the stack sits on so CI can pass); the specification is
dev-docs/conformance.md.Functions covered
polygonToCells,polygonToCellsExperimentalin the four containment modes,maxPolygonToCellsSize.cellsToLinkedMultiPolygonof the classic fill, compared by structure and by points under the angular tolerance: each outer loop up to rotation, holes in any order.Polygons are cell boundaries scaled by 0.8 and 1.2 about the center, with and without a hole, so that no cell vertex lies on a polygon edge (the
fullandoverlappingmodes are not defined on that knife edge), plus a fill at resolution 16 for the error case.Files
regions/polygons.jsonlregions/curated.jsonlThe curated file holds the polygon fixtures of the existing tests, the hemispheres and the CLI polygons. Runner:
testConformanceRegions.The committed files are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929.
🤖 Generated with Claude Code
Stack created with GitHub Stacks CLI • Give Feedback 💬