Repository navigation
Add the traversal, unsafe and local IJ conformance groups - #1286
justinhwang wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Tip 🎯 Customize your risk assessments
✅ Automatic approvals, with your rules
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
2327a3c to
41c518c
Compare
|
Coverage is 99.758% — conformance-2-traversal into conformance-1-inspection. No base build found for |
41c518c to
9d97b9c
Compare
Adds the record files and runners for grid traversal: gridRing, gridDisk and gridDiskDistances for k 1 to 3, gridDistance, gridPathCells and areNeighborCells against a target drawn from the 3-disk; gridDiskUnsafe, gridDiskDistancesUnsafe and gridRingUnsafe outcomes for every cell within one step of a pentagon's 4-disk; and cellToLocalIj with localIjToCell for near and far targets. The curated traversal and local IJ files hold the fixtures of the existing tests and the CLI examples. The files are the generator's output and are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
9d97b9c to
ed4a822
Compare
Adds the record files and runners for grid traversal.
Part of the conformance suite stack (#1292 → #1285 → #1286 → #1287 → #1288 → #1289 → #1290; #1292 is the macOS runner matrix fix the stack sits on so CI can pass); the specification is
dev-docs/conformance.md.Functions covered
gridRing,gridDisk,gridDiskDistancesfor k 1 to 3;gridDistance,gridPathCellsandareNeighborCellsagainst a target drawn from the 3-disk.gridDiskUnsafe,gridDiskDistancesUnsafe,gridRingUnsafe: the outcome (result orE_PENTAGON) for every cell within one step of a pentagon's 4-disk, checked against the safe functions.cellToLocalIjandlocalIjToCellfor near and far targets, including the error cases.Files
traversal/cells.jsonltraversal/curated.jsonlunsafe/cells.jsonllocalij/pairs.jsonllocalij/curated.jsonlThe curated files hold the fixtures of the existing tests and the CLI examples. Runners:
testConformanceTraversal,testConformanceUnsafe,testConformanceLocalIj.The committed files are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929.
🤖 Generated with Claude Code
Stack created with GitHub Stacks CLI • Give Feedback 💬