8000 fix(meta): handle unresolved imports in getComponentMeta function by sandros94 · Pull Request #215 · romhml/compodium · GitHub
[go: up one dir, main page]

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/plugins/meta/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ export function createChecker(dirs: ComponentsDir[], rootDir = process.cwd(), ts

const checker = {
...metaChecker,
getComponentMeta: (componentPath: string): CompodiumMeta => {
getComponentMeta: (componentPath: string): CompodiumMeta | undefined => {
// A component that is not on disk becomes an unresolved import inside the virtual meta entry
if (!existsSync(componentPath)) return undefined

const meta = getComponentMeta(metaChecker, componentPath)
return {
props: meta.props
Expand Down
32 changes: 32 additions & 0 deletions packages/vue/test/meta.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import { describe, expect, it } from 'vitest'

import { fileURLToPath } from 'node:url'
import { joinURL } from 'ufo'
import { dirname } from 'pathe'

import { createViteServer } from './utils'

const componentPath = (name: string) => fileURLToPath(joinURL(dirname(import.meta.url), './fixtures/basic/src/components', name))

describe('meta api', async () => {
const server = await createViteServer('./fixtures/basic')

it('describes a component it can resolve', async () => {
const resp = await server.get('/__compodium__/api/meta').query({ component: componentPath('BasicComponent.vue') })

expect(resp.status).toBe(200)
expect(resp.body.props.map((prop: { name: string }) => prop.name)).toContain('foo')
}, 30_000)

it('answers 404 for a component that does not exist', async () => {
const resp = await server.get('/__compodium__/api/meta').query({ component: componentPath('MissingComponent.vue') })

expect(resp.status).toBe(404)
})

it('answers 400 when no component is named', async () => {
const resp = await server.get('/__compodium__/api/meta')

expect(resp.status).toBe(400)
})
})
Loading
0