Repository navigation
fix(meta): handle unresolved imports in getComponentMeta function - #215
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed privately on Discord
The
!metabranch in the meta middleware could never fire —getComponentMetais typedCompodiumMetaand always returns an object literal, so a missing component came back 200 with empty props instead of 404, indistinguishable from a component that genuinely has none.Now guards on the file existing and returns
undefined, which makes the existing 404 branch work as intended. Added a small spec for the 200 / 404 / 400 cases.