Repository navigation
test: SIGKILL crash test checks committed data (#384, v2.x backport) - #485
Merged
Merged
Conversation
Backport of the v3 test. The child runs a seeded workload under five checkpoint modes and logs each transaction after execute returns; the reopened file must equal the model after the last logged transaction or the one in flight, through full-scan, AEVT, AVET, EAVT and :as-of queries, again after a second reopen and after a checkpoint plus reopen. The workload leaves out the v2.x known issues #371 (two values of one attribute in one transaction) and #435 (asserting a live triple again returns one row per assertion); v2 has no verify(). Refs #384 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Scheduled runs use this file from the default branch, so the branch under test comes from the cron string, as in bench.yml: main at 03:17 UTC, v3 at 15:17 UTC. Failure issues name the branch and the commit that was tested. Refs #384 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled diff
69C0
erently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #384
v2.x backport of #484. Same test, with two differences for the v2.x line:
v3). Re-assertion after a retract is still covered.verify(), so that check is left out.All other checks are the same: tx count
NorN + 1, full scan, AEVT, AVET, EAVT and:as-ofequal to the model, on the first reopen, a second reopen, and a reopen after a checkpoint. The five checkpoint modes are the same too.Verification
Found while backporting
Without the #435 restriction, v2.x returns duplicate rows, with no crash and no checkpoint involved:
Stored data is intact. #435 is closed (fixed on
v3), but it is not listed in the known-issues issue #421.Nightly
crash-kill.ymlnow alternates between branches, asbench.ymldoes:mainat 03:17 UTC andv3at 15:17 UTC. The branch comes from the cron string, because scheduled runs always use the default branch's copy of the file. Failure issues name the branch and the commit that was tested. Both PRs carry the same file, so the setup keeps working afterv3becomesmain.🤖 Generated with Claude Code
https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h