Repository navigation
test: SIGKILL crash test checks committed data (#384) - #484
Merged
Merged
Conversation
The child runs a seeded workload (multi-valued batches, batched retracts, re-assertions) under five checkpoint modes and logs each transaction after execute returns. After the kill, the reopened file must equal the model after the last logged transaction or the one in flight, through full-scan, AEVT, AVET, EAVT and :as-of queries, with verify clean; again after a second reopen and after a checkpoint plus reopen. Refs #384 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Scheduled runs use this file from the default branch, so the branch under test comes from the cron string, as in bench.yml: main at 03:17 UTC, v3 at 15:17 UTC. Failure issues name the branch and the commit that was tested. Refs #384 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #384
What
tests/crash_kill_test.rsused to check only that the file reopened and one AEVT query ran. It missed #370 (EAVT) and could not reach #371 (one fact per transaction). Now:executereturns.wal_checkpoint_threshold(2)), and every third withSyncMode::Normal.tx_countmust beNorN + 1, whereN + 1is a transaction that reached disk but not the log. The data must equal the model at that count through a full scan, AEVT per attribute, AVET per attribute and value, EAVT per entity and:as-ofsamples, andverify()must report no problems.MINIGRAF_CRASH_KILL_SEEDreplays it.Spec:
docs/superpowers/specs/2026-10-08-crash-kill-data-check-design.md. Plan:docs/superpowers/plans/2026-10-08-crash-kill-data-check.md.Verification
N + 1) and 462 did not, so both allowed outcomes are exercised.The nightly
crash-kill.yml(100 rounds per OS) runs the new test unchanged; only its comments changed.A v2.x backport (main) follows in a separate PR. It leaves out same-transaction multi-valued batches (#371, known v2.x issue) and
verify(), which v2 does not have.Nightly
crash-kill.ymlnow alternates between branches, asbench.ymldoes:mainat 03:17 UTC andv3at 15:17 UTC. The branch comes from the cron string, because scheduled runs always use the default branch's copy of the file. Failure issues name the branch and the commit that was tested. Both PRs carry the same file, so the setup keeps working afterv3becomesmain.🤖 Generated with Claude Code
https://claude.ai/code/session_012wXxZguv7PgKQjMMH4yJ5h