[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.4] Add more explaination for added mbstring functions #3929

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[PHP 8.4] Add more explaination for added mbstring functions #3929

merged 3 commits into from
Nov 13, 2024

Conversation

youkidearitai
Copy link
Contributor

@youkidearitai
[PHP 8.4] mb_[lr]?trim functions trimmed characters and some words mo…
df835ce 
…dified.

Add more explaination for mb_ucfirst and mb_lcfirst functions
@youkidearitai
Fix failed build
308cf71
@youkidearitai
Copy link
Contributor Author
  • mb_[lr]?trim functions trimmed add code points.
  • Explanation of mb_ucfirst and mb_lcfirst functions has been updated to reflect the actual situation.

refs #3922

Could anyone review?

@youkidearitai
Copy link
Contributor Author

(Sorry, I don't know who to mention) @Girgias
I would like merge this PR. Can I merge it?

Girgias
Girgias reviewed Nov 10, 2024
View reviewed changes
Copy link
Member
@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, just one question that I'm not exactly sure about.

reference/mbstring/functions/mb-ucfirst.xml Outdated Show resolved Hide resolved
@youkidearitai youkidearitai merged commit d0e23f4 into php:master Nov 13, 2024
2 checks passed
@youkidearitai youkidearitai deleted the php84_mbstring_functions branch November 13, 2024 01:41
@youkidearitai
Copy link
Contributor Author

Thanks for review!

@jdkfx jdkfx mentioned this pull request Nov 14, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

@ramsey ramsey ramsey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youkidearitai @ramsey @Girgias