Repository navigation
Add more translations to dashboard and introduce i18n test wrapper - #5082
Merged
Merged
Conversation
scottcarol
commented
Oct 14, 2020
alpeb
reviewed
Oct 14, 2020
alpeb
reviewed
Oct 14, 2020
Member
There was a problem hiding this comment.
Thanks @scottcarol !
Here's a list of things that I found haven't been translated yet:
Running Linkerd db709fd2 (git)at the bottom of the sidebar- In the Control Plane section:
- Title
Control Plane The service mesh was successfully installed!
- Title
- When looking at a pod:
LIVE CALLSandROUTE METRICSFROMandTO- In the dependency graph, when a pod is unmeshed it's titled with
Unmeshed - In the popups, the table headers
SourceandDestination
- Tap section:
Resource,To Resourcedropdown titles- The
Request Detailspopup contents haven't been translated
- Top section:
Resourcedropdown title
Top Routessection titleCommunitysection title
Contributor
Author
|
@alpeb Thanks for the review! I just pushed changes that should fill in the missing translations you listed in your comment. |
alpeb
reviewed
Oct 20, 2020
Member
There was a problem hiding this comment.
Thanks @scottcarol , I've added some more comments 🙂
| "columnTitleDeployment": "Deployment", | ||
| "columnTitleDestination": "Destino", | ||
| "columnTitleDirection": "Dirección", | ||
| "columnTitleFrom": "DE", |
| "columnTitleMethod": "Método", | ||
| "columnTitleName": "Nombre", | ||
| "columnTitleNamespace": "Namespace", | ||
| "columnTitleNoTraffic": "No Tráfico", |
| "columnTitleSource": "Fuente", | ||
| "columnTitleSuccessRate": "Tasa de éxito", | ||
| "columnTitleTap": "Tap", | ||
| "columnTitleTo": "Á", |
| "columnTitleSuccessRate": "Tasa de éxito", | ||
| "columnTitleTap": "Tap", | ||
| "columnTitleTo": "Á", | ||
| "columnTitleUnmeshed": "No en la malla de servicios", |
| "tableTitleLeafServices": "Servicios Hoja", | ||
| "tableTitleOutbound": "Salida", | ||
| "tableTitlePods": "Pods", | ||
| "tableTitleRequestDetails": "Pedir Detalles", |
Contributor
Author
|
@alpeb Thanks, just pushed changes addressing your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4866
Context: Although the majority of the dashboard text is already wrapped in
<Trans>translation components, there are still some forms and help text that need to be wrapped.This PR adds those translations and introduces an i18n wrapper into the front-end tests so that test files can have access to the translations if needed.
This PR should not change any UI when viewing in English.
Note: The front-end tests are currently only testing the language
enbut this can be expanded in the future to all existing languages we support.