Repository navigation
Add es translations and docs instructions to dashboard - #4866
Conversation
There was a problem hiding this comment.
Hi @scottcarol , for now I've reviewed the language file, and then I'll give a check to the translated dashboard and let you know how it goes.
| @@ -1,5 +1,103 @@ | |||
| { | |||
| "404Msg": "Página no encontrada.", | |||
| "Add {0} to the k8s.yml file<0/><1/>Then run {inject} to add it to the service mesh": "Agregue {0} a la k8s.yml file<0/><1/>Luego ejecuta {inject} para inyectarla en la malla de servicios", | |||
There was a problem hiding this comment.
Agrega {0} al archivo k8s.yml<0/><1/>Luego ejecuta {inject} para inyectarlo en la malla de servicios
|
Thanks so much @alpeb, I've pushed changes with your edits. |
|
Thanks @scottcarol , I've spotted this (Edges table title showing [Object object]) on some of the deployment views, that I couldn't reproduce in the edge: |
|
Thanks for the 👀 @alpeb, I didn't remember that the Edges table has two possible titles. Should be fixed now |
There was a problem hiding this comment.
🆒 this looks good to me 👍
Looking forward for the followup PR with the remaining translation spots 😉
Some integration test failed because of flakiness, so I retriggered it and it should be fine.
There was a problem hiding this comment.
@scottcarol this is a good foundation to getting the dashboard translated to multiple languages.
I couldn't reproduce the [object] issue in the edges display, so it looks like that is fixed.
I think it would be helpful to have a reference file that provides the strings that should be translated from. I see that the en/messages.json file could serve that purpose, so let's see how that goes for now.
Thanks for this! 🚢
This PR adds keys and es translations for most string literals on the Linkerd
dashboard using
js-lingui. Most translations are from @cynthia-sg's earlierwork. Thank you @cynthia-sg!
Nothing should change for en language dashboard users. To test in es, see
viewing instructions in #4803.
Keys are generally named for their UI element
tableTitle...,button...,menuItem...if present.This approach has the result of reducing the total number of strings in the
dashboard code because many are repeated from page to page.
NOTE There are a small amount of dynamic text values that are NOT included
in this PR, including strings formed with
friendlyTitle()inUtils.js, andsome strings in
ServiceMesh.Since those will require some refactoring instead of simply replacing the string
with
<Trans>, I left them out of this PR, and will split this out into aseparate PR.
Signed-off-by: Carol Scott carol@buoyant.io