[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected doc #2368

Merged
merged 1 commit into from
Jun 17, 2024
Merged

corrected doc #2368

merged 1 commit into from
Jun 17, 2024

Conversation

swastik959
Copy link
Contributor

Changes

  • correction the docs for build section

/kind documentation

Fixes #2183

Release Note

Docs

@swastik959
corrected doc
57a3651 
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@knative-prow knative-prow bot requested review from maximilien and nainaz June 15, 2024 14:06
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jun 15, 2024

Welcome @swastik959! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2024
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jun 15, 2024

Hi @swastik959. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

matzew
matzew approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member
@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thx for the PR

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, swastik959

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@knative-prow knative-prow bot merged commit 2ac73da into knative:main Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@maximilien maximilien Awaiting requested review from maximilien

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

builderImages is ignored
2 participants
@swastik959 @matzew