[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builderImages is ignored #2183

Closed
braunsonm opened this issue Feb 26, 2024 · 2 comments · Fixed by #2368
Closed

builderImages is ignored #2183

braunsonm opened this issue Feb 26, 2024 · 2 comments · Fixed by #2368
Labels
kind/documentation kind/good-first-issue Denotes an issue ready for a new contributor.

Comments

@braunsonm
Copy link
braunsonm commented Feb 26, 2024 •
edited
Loading

builderImages configuration in func.yaml is documented here: https://github.com/knative/func/blob/main/docs/reference/func_yaml.md#builderimages

However, no matter the value placed in this configuration, the builderImages.pack is ignored by both the func build and func deploy commands.

Reproduction

  1. Create any func project func create --language springboot myfunc
  2. Change func.yaml to contain
builderImages:
  pack: paketobuildpacks/builder-jammy-full:latest
  1. func build - notice it still uses ghcr.io/knative/builder-jammy-base:latest
@matejvasek
Copy link
Contributor

The doc seems to be outdated.
The builderImages option should be under build section.

build:
  builderImages:
    pack: paketobuildpacks/builder-jammy-full:latest

@braunsonm
Copy link
Author

I can confirm that works @matejvasek
I'll leave this issue open as the documentation needs to be updated.

@lkingland lkingland added the kind/good-first-issue Denotes an issue ready for a new contributor. label Mar 21, 2024
@lkingland lkingland moved this to 🔖 Next in Functions WG Roadmap Mar 21, 2024
@swastik959 swastik959 mentioned this issue Jun 15, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Next to ✅ Done in Functions WG Roadmap Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
Functions WG Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

corrected doc swastik959/func
3 participants
@matejvasek @braunsonm @lkingland