8000 The mark: blue pencil, underlined at rest by kiran-brahma · Pull Request #85 · kiran-brahma/writing-tool · GitHub
[go: up one dir, main page]

Skip to content

The mark: blue pencil, underlined at rest - #85

Merged
kiran-brahma merged 2 commits into
v1.3from
v1.3-64
Sep 26, 2026
Merged

kiran-brahma merged 2 commits into
v1.3from
v1.3-64

Conversation

@kiran-brahma
@kiran-brahma kiran-brahma commented Sep 26, 2026 •
Copy link
Copy Markdown
Owner

Part of #57. Closes #64.

Only src/index.css changes: the mark tokens in both schemes, and the .obelus-highlight* rules. Rebased on the latest v1.3; #63's .obelus-editor changes are untouched.

  • At rest, a Highlight has no fill, only a text-decoration underline in mark-line.
  • On hover, it fills with mark-hover.
  • The Current Finding's Highlight fills with current-mark and keeps its 1px outline. The rule is now .obelus-highlight.obelus-highlight-current and comes after the hover rule, so the current Highlight keeps its fill under the pointer.
  • Blue pencil. The mark is sky, a blue that leans towards cyan, at about 200° hue. It stays clear of the links, link and prose-link, which sit at about 222° in both schemes. A link is blue text; a mark is a blue line or fill under ink-coloured text. It also stays clear of warning (amber), failure (red), violation (rose), milestone (violet) and success/agreement (green). mark-wash, the colour of the Current Finding's Rail row, follows the same blue.
  • mark is the blue pencil itself: a colour that reads as text or a glyph, ready for Margin marks (Margin marks #65). No Highlight uses it as a fill. It is on the header table as a new v1.3 name, and the mark-wash line there now says blue pencil.
  • No box-shadow or border-radius on a Highlight. The WebKit budget comment is still accurate, and now also notes that at most two spans carry a fill.
token light dark
mark #0369a1 (sky-700) #38bdf8
mark-line #0284c7 (sky-600) #38bdf8
mark-hover #bae6fd (sky-200) #173a52
current-mark #7dd3fc (sky-300) #1e4f6e
current-mark-line #0369a1 (sky-700) #7dd3fc
mark-wash #e0f2fe (sky-100) #172a36

WCAG contrast:

pair light dark
ink on the hover fill 13.2:1 9.7:1
ink on the current fill 10.5:1 7.1:1
mark as text on paper 5.9:1 7.9:1
mark as text on ground 5.7:1 8.3:1
underline on paper 4.1:1 7.9:1

Acceptance criteria

  • At rest, Highlights are underlined, not filled. Verified in headless Chromium against pnpm dev, in both schemes (emulateMedia), at 1440, 1024 and 375px. The computed background at rest is rgba(0,0,0,0), with a sky underline.
  • The Current Finding's Highlight is filled and outlined; hovering any Highlight fills it. Verified the same way. The current Highlight, reached with Alt+↓, has the current-mark fill and a solid outline, and keeps both under the pointer. A Highlight at rest fills with mark-hover when hovered. Every state computes box-shadow none and border-radius 0px.
  • Marks are legible in both schemes, and no mark shares a colour with a warning or failure. Verified with the contrast and hue figures above.
  • Typing with about 490 Highlights in WebKit feels no slower than on the previous commit. Not verifiable here: WebKit is not installed, and there is no way to type by hand.
    • As a stand-in I measured in Chromium, not WebKit: time from keydown to the next frame, over 176 keystrokes, with 483 Highlights from the rule passes and the CPU throttled 4×.
    • Previous commit: mean 40.0–41.9 ms, p50 38.3–39.2 ms. This branch: mean 39.8–42.6 ms, p50 37.5–39.9 ms. No measurable difference.
    • With a Highlight hovered: 38.8–40.7 ms before, 38.7–38.8 ms after.
    • The change removes the background from every Highlight at rest and adds no shadow or radius.
    • A human still needs to check this in Safari.
  • Checked by eye in both schemes. Done on headless Chromium screenshots of rest, current and hover, light and dark, at 1440, 1024 and 375px, not in a real browser. The dark current fill is quiet; its outline carries most of the emphasis.

pnpm test (1090 passed), pnpm typecheck, pnpm run gates and pnpm build all pass. No affordance inserts model-derived text, there is no Dexie migration, the findings schema is unchanged, and there is no DOM test layer.

🤖 Generated with Claude Code

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 26, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-26T10:33:29.845143Z 42bd107 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

A Highlight is now an underline in an editor's blue pencil, with no fill
at rest. The Current Finding's Highlight is filled and keeps its outline,
and keeps that fill under the pointer; any other Highlight fills on hover.
The mark tokens and the Current Finding's Rail row move from amber to sky,
a cyan-leaning blue apart from the links' royal blue, in both schemes.
The unused `mark` fill token goes; the underline stays a text decoration
and no Highlight gains a shadow or a radius.

Part of #57. Closes #64.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
`mark` is one of the spec's colour names, and Margin marks need a named
blue-pencil colour for the obelus and its count. It returns in both
schemes as a colour legible as text: sky-700 in light (5.9:1 on paper,
5.7:1 on ground) and the dark underline's sky (7.9:1 on paper, 8.3:1 on
ground). No Highlight uses it as a fill; at rest a Highlight is still
only its underline.

Part of #57.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0