Repository navigation
The mark: blue pencil, underlined at rest - #85
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A Highlight is now an underline in an editor's blue pencil, with no fill at rest. The Current Finding's Highlight is filled and keeps its outline, and keeps that fill under the pointer; any other Highlight fills on hover. The mark tokens and the Current Finding's Rail row move from amber to sky, a cyan-leaning blue apart from the links' royal blue, in both schemes. The unused `mark` fill token goes; the underline stays a text decoration and no Highlight gains a shadow or a radius. Part of #57. Closes #64. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
`mark` is one of the spec's colour names, and Margin marks need a named blue-pencil colour for the obelus and its count. It returns in both schemes as a colour legible as text: sky-700 in light (5.9:1 on paper, 5.7:1 on ground) and the dark underline's sky (7.9:1 on paper, 8.3:1 on ground). No Highlight uses it as a fill; at rest a Highlight is still only its underline. Part of #57. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
kiran-brahma
force-pushed
the
v1.3-64
branch
from
September 26, 2026 10:33
42bd107 to
cb5dc64
Compare
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #57. Closes #64.
Only
src/index.csschanges: the mark tokens in both schemes, and the.obelus-highlight*rules. Rebased on the latestv1.3; #63's.obelus-editorchanges are untouched.text-decorationunderline inmark-line.mark-hover.current-markand keeps its 1px outline. The rule is now.obelus-highlight.obelus-highlight-currentand comes after the hover rule, so the current Highlight keeps its fill under the pointer.linkandprose-link, which sit at about 222° in both schemes. A link is blue text; a mark is a blue line or fill under ink-coloured text. It also stays clear of warning (amber), failure (red), violation (rose), milestone (violet) and success/agreement (green).mark-wash, the colour of the Current Finding's Rail row, follows the same blue.markis the blue pencil itself: a colour that reads as text or a glyph, ready for Margin marks (Margin marks #65). No Highlight uses it as a fill. It is on the header table as a new v1.3 name, and themark-washline there now says blue pencil.WCAG contrast:
markas text on papermarkas text on groundAcceptance criteria
pnpm dev, in both schemes (emulateMedia), at 1440, 1024 and 375px. The computed background at rest isrgba(0,0,0,0), with a sky underline.current-markfill and a solid outline, and keeps both under the pointer. A Highlight at rest fills withmark-hoverwhen hovered. Every state computes box-shadownoneand border-radius0px.pnpm test(1090 passed),pnpm typecheck,pnpm run gatesandpnpm buildall pass. No affordance inserts model-derived text, there is no Dexie migration, the findings schema is unchanged, and there is no DOM test layer.🤖 Generated with Claude Code