8000 The mark: blue pencil, underlined at rest · Issue #64 · kiran-brahma/writing-tool · GitHub
[go: up one dir, main page]

Skip to content

The mark: blue pencil, underlined at rest #64

Closed

Description

@kiran-brahma

Parent

#57 — Spec: Obelus v1.3, the page and the mark

What to build

The mark. The mark colour becomes an editor's blue pencil, in both schemes. A Highlight is an underline at rest; the Current Finding's Highlight is filled and keeps its outline; a hovered Highlight is filled. The underline stays a text decoration, and no Highlight gains a shadow or a radius — the WebKit budget recorded beside the Highlight styles holds.

Stories 207, 211–216.

Acceptance criteria

  • At rest, Highlights are underlined, not filled.
  • The Current Finding's Highlight is filled and outlined; hovering any Highlight fills it.
  • Marks are legible in both schemes, and no mark shares a colour with a warning or failure.
  • Typing in a Document with about 490 Highlights in WebKit feels no slower than on the previous commit (checked by hand, stated in the PR).
  • Checked by eye in both schemes.

Blocked by

Activity

  1. added 2 commits that reference this issue on Sep 26, 2026
    f07e1b4
    c4cd3d4
  2. kiran-brahma commented on Sep 26, 2026

    @kiran-brahma
    OwnerAuthor

    Done in #85 (merged into v1.3). The mark is a sky-blue pencil in both schemes, distinct from warning, failure, milestone and the link blues. Highlights are underlined at rest, filled on hover, and the Current Finding is filled and outlined (it keeps its own fill under the pointer). No box-shadow or radius; the WebKit budget comment holds. Ink on the filled mark: 13.2/10.5:1 light, 9.7/7.1:1 dark. mark is the blue pencil as text (5.9:1 light, 7.9:1 dark), ready for Margin marks.

    Needs a human: typing in Safari/WebKit with ~490 Highlights. Only a Chromium proxy was possible here (483 Highlights, 4× CPU throttle: 40–42 ms before vs 40–43 ms after). Also worth a look by eye: the dark Current Finding fill is quiet; its outline carries most of the emphasis.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentSpec is ready for an agent to implement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0