8000 Dark scheme and the Light | Dark | System choice · Issue #62 · kiran-brahma/writing-tool · GitHub
[go: up one dir, main page]

Skip to content

Dark scheme and the Light | Dark | System choice #62

Closed

Description

@kiran-brahma

Parent

#57 — Spec: Obelus v1.3, the page and the mark

What to build

The contract step, and the point dark mode goes live. The colour names gain dark values — a dark paper, not pure black. A Writer chooses Light | Dark | System in AI Settings; System is the default and follows the operating system as it changes, with no attribute set and so no flash on load. A Light or Dark choice sets one attribute on the root element. The choice is the colorScheme key in the existing settings store (no Dexie migration) and travels in a Backup. The browser theme-color follows the resolved scheme. A new agent gate fails the build on any raw palette colour class in UI source, so the refactor cannot regress.

Stories 201–206, 209–210.

Acceptance criteria

  • resolveColorScheme(setting, systemPrefersDark) is tested over the full table.
  • The colorScheme key saves, loads, and normalises an unknown value to System (tested like the existing settings keys).
  • With System, changing the OS scheme changes the app live, and reload shows no flash.
  • Light and Dark override the OS; the choice survives reload and Backup → Restore.
  • theme-color matches the scheme.
  • Story 187's contrast minimums hold in dark (checked on the Rail's muted text and disabled Pass names).
  • The agent gate rejects a raw palette class added to UI source, and passes on the tree.
  • Every screen checked by eye in both schemes at 1440px.

Blocked by

Activity

  1. kiran-brahma commented on Sep 26, 2026

    @kiran-brahma
    OwnerAuthor

    Done in #81 (merged into v1.3). Every colour name has a dark value (warm dark paper #1f1d1a, never pure black); Light | Dark | System in AI Settings, System by default with no attribute and no flash; colorScheme is a normalised settings key that survives Backup → Restore; two theme-color metas follow the scheme; resolveColorScheme tested over the full table; a new palette agent gate rejects raw palette classes. Dark contrast: Rail muted text ≥ 6.58:1, disabled Pass names 7.48:1.

    Left for a human: the no-flash check ran on the dev server, not a production build; the manifest's static theme_color is unchanged; a disabled ink-filled button is hard to read in both schemes (pre-existing).


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3EFC
    ready-for-agentSpec is ready for an agent to implement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0