Repository navigation
Move the Editor surface to colour names, with focus rings - #79
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The app shell and header, the Editor and its toolbar, the Callout, the Document menu, the first-run and Scratchpad notes, and the save, storage and import banners now use the colour names from index.css instead of palette classes. The banners take warning rather than amber, so a failure and a mark no longer share a colour. Every control in the surface shows a focus ring from the keyboard (story 209): the toolbar buttons, the notes' action and dismissal, the Document menu's Import and Export items, and the title field, whose ring is inset because the field runs edge to edge. Part of #57. Closes #59. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
A ring in the focus colour disappears against an ink fill, so the current destination in the header and an active toolbar button carry a ring offset, as the shared convention now says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
<
AB17
/div>
A save that failed and an import that failed are failures, not warnings, so their banners take failure-rule, failure-surface and failure. The storage notice stays a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
kiran-brahma
force-pushed
the
v1.3-59
branch
from
September 26, 2026 09:55
a6dca18 to
097ca21
Compare
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #57. Closes #59.
The app shell and header, the Editor and its toolbar, the Callout, the Document menu, the first-run and Scratchpad notes, and the save / storage / import banners now use the colour names from
src/index.css. Each palette class maps through the table in that file's header. No token was added or changed. Rebased on the latestv1.3, which includes #78.The spec's rule is blue pencil for marks, amber for warnings and red for failures. So the save-error and import-error banners take
border-failure-rule bg-failure-surface text-failure, and the storage notice stays a warning.text-failureonfailure-surfacehas a contrast of about 5.9:1, computed from the oklch tokens.Focus rings follow the shared convention (
focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-focus). The storage notice's Dismiss button keepsring-warning-focus. Ink-filled controls (the current header destination and an active toolbar button) addfocus-visible:ring-offset-2.Acceptance criteria
No raw palette colour class remains in the Editor surface. Verified by grep over
App.tsx,DocumentMenu.tsx,DocumentEditor.tsx,FindingCallout.tsxandmain.tsx.Banners use warning or failure, never mark. Verified:
warning-surface/warning-rule/warning, and its Dismiss button useswarning-rule-strong/ring-warning-focus.DocumentEditor,DocumentMenuandFindingCallouthave no other error text.Every button, input and link in the surface shows a visible focus ring from the keyboard. Verified in headless Chromium by tabbing through the surface and taking screenshots. The following controls had no ring before and now have one:
has-focus-visible:on the label that wraps the hidden file inputThe rings on ink-filled controls are offset and visible against the fill.
The surface looks unchanged apart from focus rings (checked by eye at 1440px). Verified against an
origin/v1.3build at 1440×900, at rest and with the Document menu open. A pixel diff finds differences of at most 1–2/255, only on anti-aliased text, fromindex.csstokens written as hex. The save and import banners now take the failure colours, as the spec requires. They only appear on an error, so they did not show in the screenshots taken at rest.Tests, typecheck and agent gates pass. Verified after the rebase:
pnpm test(1021 passed),pnpm typecheck,pnpm run gatesandpnpm build.Noticed, not changed
overflow-x-autoat 1440px, both here and onorigin/v1.3. This was already the case before this change and is outside this ticket..obelus-editor:focus { outline: none }.🤖 Generated with Claude Code