8000 Move the other screens to colour names, type scale and focus rings by kiran-brahma · Pull Request #78 · kiran-brahma/writing-tool · GitHub
[go: up one dir, main page]

Skip to content

Move the other screens to colour names, type scale and focus rings - #78

Merged
kiran-brahma merged 2 commits into
v1.3from
v1.3-61
Sep 26, 2026
Merged

kiran-brahma merged 2 commits into
v1.3from
v1.3-61

Conversation

@kiran-brahma
@kiran-brahma kiran-brahma commented Sep 26, 2026 •
Copy link
Copy Markdown
Owner

Part of #57. Closes #61.

Batch 3 of the colour refactor. It covers Library and Backup, Pass workbench, AI Settings and Connections, How this works, and Privacy. I made no layout changes and changed no tokens.

Colour: every palette class on these screens now uses a name from the table in src/index.css. Two entries depend on context: text on an ink fill is on-ink, and text on the warning fill (the "Replace library" button) is warning-surface.

Type scale: there are three steps: heading text-lg, body text-sm, detail text-xs. The only size changes:

  • The section headings in How this works and Privacy, and the title of a Library entry, go from text-base to text-lg.
  • The text-[11px] details in AI Settings and Connections go to text-xs.

Panel labels such as "Slots", "Backup" and "Model passes" stay at body size in semibold.

Focus: every control gets focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-focus. The controls inside a warning notice (Replace library, the two Dismiss buttons) use ring-warning-focus. There are no failure-coloured controls on these screens.

Two exceptions to that convention:

  • Dark-filled controls also get focus-visible:ring-offset-2. A ring flush against a dark fill can't be seen, so the offset puts a band of paper between them. This covers the ink buttons (New document, Back up library, New pass, Save), the active tag chip in the Library filter, and the warning-filled Replace library button. The supervisor agreed this amendment in review.
  • The three visually hidden file inputs (Restore from backup, Import document bundle, Import pass set) put their ring on the visible label, as has-focus-visible:ring-2 has-focus-visible:ring-focus, because a ring on an sr-only input can't be seen.

Acceptance criteria

  • No raw palette colour class remains on these screens. Checked by grep over the seven files. Not covered: RulePassesPanel. The Pass workbench renders it, but it lives in src/editor/, outside this batch's files, and is left to Move the Rail to colour names, with focus rings #60.
  • Headings, body and detail text use the same three-step scale. Checked: the only sizes left in these files are text-lg, text-sm and text-xs.
  • Every control shows a visible focus ring from the keyboard. Checked in headless Chromium by tabbing through each screen and reading each focused control's computed box-shadow.
    • Library had 13 stops, Pass workbench 33, AI Settings 40 and Privacy 8, all with a 2px ring. How this works has no controls.
    • After adding the offset, I tabbed to New document, Back up library, New pass and Save again. Each showed a 2px paper band then a 2px focus ring, and I confirmed it by eye in screenshots.
    • I didn't reach the active tag chip or Replace library by keyboard in this run; they appear only once a tag exists or a restore is pending. They carry the same classes.
  • Layouts unchanged (checked by eye at 1440px). Full-page screenshots compared against origin/v1.3 at 1440px, before and after. The Library, Pass workbench and the pass editor are the same size. How this works is 16px taller, Privacy 20px taller and AI Settings 10px shorter. These differences come only from the heading and detail size steps above; nothing moved or reflowed.
  • Tests, typecheck and agent gates pass. pnpm test (1021 passed), pnpm typecheck, pnpm run gates and pnpm build all pass.

The ticket n 8000 ames no pure function, so it adds no new tests. It adds no DOM test layer, no Dexie migration, no prompt change and no affordance that inserts model-derived text.

🤖 Generated with Claude Code

Library and Backup, Pass workbench, AI Settings and Connections, How this
works and Privacy now use the colour names from index.css instead of
palette classes, following its table (text on an ink fill is on-ink, text
on the warning fill is warning-surface).

Type on these screens sits on three steps: text-lg for headings, text-sm
for body, text-xs for detail. The section headings of How this works and
Privacy and a Library entry's title move up from text-base; the 11px
details in AI Settings and Connections move to text-xs.

Every control shows focus-visible:ring-2 ring-focus from the keyboard;
controls inside a warning notice use ring-warning-focus. The visually
hidden file inputs put the ring on their label with has-focus-visible.

Part of #57. Closes #61.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 26, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-26T09:52:33.385656Z cbc64ca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

A focus-coloured ring flush against an ink fill cannot be seen. The ink
buttons, the active tag chip and the warning-filled Replace library
button now add ring-offset-2, so a band of paper separates the ring
from the fill.

Part of #
8FC9
57. Refs #61.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0