Repository navigation
Move the other screens to colour names, type scale and focus rings - #78
Merged
Merged
Conversation
Library and Backup, Pass workbench, AI Settings and Connections, How this works and Privacy now use the colour names from index.css instead of palette classes, following its table (text on an ink fill is on-ink, text on the warning fill is warning-surface). Type on these screens sits on three steps: text-lg for headings, text-sm for body, text-xs for detail. The section headings of How this works and Privacy and a Library entry's title move up from text-base; the 11px details in AI Settings and Connections move to text-xs. Every control shows focus-visible:ring-2 ring-focus from the keyboard; controls inside a warning notice use ring-warning-focus. The visually hidden file inputs put the ring on their label with has-focus-visible. Part of #57. Closes #61. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A focus-coloured ring flush against an ink fill cannot be seen. The ink buttons, the active tag chip and the warning-filled Replace library button now add ring-offset-2, so a band of paper separates the ring from the fill. Part of # 8FC9 57. Refs #61. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #57. Closes #61.
Batch 3 of the colour refactor. It covers Library and Backup, Pass workbench, AI Settings and Connections, How this works, and Privacy. I made no layout changes and changed no tokens.
Colour: every palette class on these screens now uses a name from the table in
src/index.css. Two entries depend on context: text on an ink fill ison-ink, and text on the warning fill (the "Replace library" button) iswarning-surface.Type scale: there are three steps: heading
text-lg, bodytext-sm, detailtext-xs. The only size changes:text-basetotext-lg.text-[11px]details in AI Settings and Connections go totext-xs.Panel labels such as "Slots", "Backup" and "Model passes" stay at body size in semibold.
Focus: every control gets
focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-focus. The controls inside a warning notice (Replace library, the two Dismiss buttons) usering-warning-focus. There are no failure-coloured controls on these screens.Two exceptions to that convention:
focus-visible:ring-offset-2. A ring flush against a dark fill can't be seen, so the offset puts a band of paper between them. This covers the ink buttons (New document, Back up library, New pass, Save), the active tag chip in the Library filter, and the warning-filled Replace library button. The supervisor agreed this amendment in review.has-focus-visible:ring-2 has-focus-visible:ring-focus, because a ring on ansr-onlyinput can't be seen.Acceptance criteria
RulePassesPanel. The Pass workbench renders it, but it lives insrc/editor/, outside this batch's files, and is left to Move the Rail to colour names, with focus rings #60.text-lg,text-smandtext-xs.focusring, and I confirmed it by eye in screenshots.pnpm test(1021 passed),pnpm typecheck,pnpm run gatesandpnpm buildall pass.The ticket n 8000 ames no pure function, so it adds no new tests. It adds no DOM test layer, no Dexie migration, no prompt change and no affordance that inserts model-derived text.
🤖 Generated with Claude Code