Repository navigation
Pass URL without trailing slashes to admin client - #218
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix issues with the admin client in the test suite by removing trailing slashes from URLs before passing them to the Keycloak admin client, preventing request failures caused by duplicate slashes.
Key Changes
- Added logic to detect and remove trailing slashes from
AUTH_SERVER_URLbefore passing it to the admin client - Added
realmName: 'master'configuration to the admin client initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes keycloak#217 Signed-off-by: Jon Koops <jonkoops@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Great, thanks for the review @rmartinc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.<
305C
span class="js-validation-on-left-blob">Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the trailing slash from URLs passed into the admin client used by the test suite, this prevents issues where the trailing slash can be duplicated in the request, causing failures.
Closes #217