Repository navigation
Conversation
db748fb to
da1630f
Compare
|
Did a quick rebase to include #218 so we can see if the tests will pass. |
Thanks! Looks like Additionally I see the |
|
Fix the tests in 7fbc7fb |
|
@jonkoops just wanted to quickly follow up if I should continue in this direction? |
|
Sorry for the late reply, I got bogged down in some other stuff. I think this is going in the right direction, I will try to get a more detailed review in when I can. Currently, I need to fix #209 and #208 and do a release before landing new features. If you have any idea what might be causing those, help is appreciated. |
7fbc7fb to
2f34f6b
Compare
This reverts commit 29740bc.
9e5eb34 to
f977ef5
Compare
No worries, I had my own fair share of other priorities, so apologies for my late response as well. I rebased my changes on latest master and adjusted the tests to latest changes of explicitly navigating in tests, so that they pass locally My plan is to polish the PR this week and put it up for a proper review. Also will have a look at the issues you linked - not too confident that I can be of help there though. |
|
I am going ahead and close this PR, as we have decided to drop Cordova support entirely (see #272), so it makes no sense to introduce new testing infrastructure for it. I actually managed to get a functional integration test with Playwright and some vibe-coding (jonkoops@10712bb), but it became clear that may of the dependencies we use for Cordova have become abandoned, requiring extensive manual patching. |
Attempt to add cordova integration tests - following #27 (comment).
Mocks InAppBrowser plugin by providing a handle for registering event listeners. The urls for the InAppBrowser will be opened in a separate window, leaving the initial page active as it would be with a cordova app.
Next steps could be: