8000 Allow overriding of database properties by setting environment variab… by ioemat · Pull Request #9134 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Allow overriding of database properties by setting environment variab… - #9134

Closed
ioemat wants to merge 1 commit into
keycloak:mainfrom
bosch-io:fix/KEYCLOAK-9133-configuration-of-custom-jdc-properties
Closed

Allow overriding of database properties by setting environment variab…#9134
ioemat wants to merge 1 commit into
keycloak:mainfrom
bosch-io:fix/KEYCLOAK-9133-configuration-of-custom-jdc-properties

Conversation

@ioemat
@ioemat ioemat commented Dec 14, 2021
Copy link
Copy Markdown
Contributor

…les or system properties.

Closes #9133

@pedroigor
pedroigor commented Dec 15, 2021
Copy link
Copy Markdown
Contributor

@ioemat Can you please check if these changes are enough for you ? See https://github.com/pedroigor/keycloak/tree/issue-9133.

@pedroigor
pedroigor self-requested a review December 15, 2021 15:18
@pedroigor pedroigor closed this Dec 16, 2021
@pedroigor
pedroigor commented Dec 16, 2021
Copy link
Copy Markdown
Contributor

See #9199.

@ioemat
ioemat commented Dec 17, 2021
Copy link
Copy Markdown
Contributor Author

Sorry @pedroigor, I missed your comment yesterday, I will test with your branch and report back if it solves our issue.

@ioemat
ioemat commented Dec 17, 2021
Copy link
Copy Markdown
Contributor Author

@pedroigor your fix is working in our environment, thanks for this

@Ricardo-PSilva
Ricardo-PSilva commented Feb 15, 2022 •
edited
Loading
Copy link
Copy Markdown

@pedroigor your fix is working in our environment, thanks for this

Hello guys, I followed all the work done regarding the XA problem with Azure sql database(I have an almost similar scenario of a POC here), but it's not quite clear for me how can I setup the new parameters. I already have wrote them into keycloak.conf but in my case the problem still happens (it keeps using a SQLServerXADataSource). Could you please point me in right direction on how to configure these two new parameters?

@pedroigor
pedroigor commented Feb 16, 2022 •
edited
Loading
Copy link
Copy Markdown
Contributor

@Ricardo-PSilva You should run build first and then start. Can we move discussions to the issue below?

Also, see #10191 (comment). It should be related to your question.

@Ricardo-PSilva
Ricardo-PSilva commented Feb 16, 2022
Copy link
Copy Markdown

@Ricardo-PSilva You should run build first and then start. Can we move discussions to the issue below?

Also, see #10191 (comment). It should be related to your question.

Thanks @pedroigor ! I will comment on that discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor Awaiting requested review from pedroigor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configuration of custom JDBC driver is broken (leads to Azure SQL cannot be used as database)

3 participants

@ioemat @pedroigor @Ricardo-PSilva
0