8000 [fixes #9133] - Allow setting JDBC driver and transaction type by pedroigor · Pull Request #9199 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

[fixes #9133] - Allow setting JDBC driver and transaction type - #9199

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
pedroigor:issue-9133
Dec 21, 2021
Merged

[fixes #9133] - Allow setting JDBC driver and transaction type#9199
pedroigor merged 1 commit into
keycloak:mainfrom
pedroigor:issue-9133

Conversation

@pedroigor
@pedroigor pedroigor commented Dec 16, 2021 •
edited
Loading
Copy link
Copy Markdown
Contributor

Closes #9133

This was referenced Dec 16, 2021
Closed
Closed
DGuhr
DGuhr previously approved these changes Dec 17, 2021
View reviewed changes
@ioemat
ioemat commented Dec 17, 2021
Copy link
Copy Markdown
Contributor

I can confirm that this is fixes #9133 in our environment

@pedroigor pedroigor closed this Dec 17, 2021
@pedroigor pedroigor reopened this Dec 17, 2021
@pedroigor
pedroigor force-pushed the issue-9133 branch 5 times, most recently from 3ef6153 to 765bea4 Compare December 21, 2021 13:15
@pedroigor
pedroigor commented Dec 21, 2021
Copy link
Copy Markdown
Contributor Author

@ioemat I've changed the properties to kc.db.tx-type and kc.db.driver to follow the same format we are using in other properties

@pedroigor
pedroigor merged commit 4f568df into keycloak:main Dec 21, 2021
@pedroigor
pedroigor commented Dec 21, 2021
Copy link
Copy Markdown
Contributor Author

thanks @abstractj

@pedroigor
pedroigor deleted the issue-9133 branch December 21, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractj abstractj abstractj approved these changes
+1 more reviewer
@DGuhr DGuhr DGuhr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configuration of custom JDBC driver is broken (leads to Azure SQL cannot be used as database)

4 participants

@pedroigor @ioemat @abstractj @DGuhr
0