8000 KEYCLOAK-18562 JPA clients no-downtime store by vramik · Pull Request #8615 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

KEYCLOAK-18562 JPA clients no-downtime store - #8615

Merged
hmlnarik merged 1 commit into
keycloak:mainfrom
vramik:wip-JpaClientMapStorage
Dec 15, 2021
Merged

hmlnarik merged 1 commit into
keycloak:mainfrom
vramik:wip-JpaClientMapStorage

Conversation

@vramik
@vramik vramik commented Oct 20, 2021
Copy link
Copy Markdown
Contributor

No description provided.

@vramik
vramik force-pushed the wip-JpaClientMapStorage branch from 70ee3f3 to ce02939 Compare October 26, 2021 05:57
@hmlnarik hmlnarik self-assigned this Oct 26, 2021
@hmlnarik hmlnarik added the area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching label Oct 26, 2021
@vramik
vramik force-pushed the wip-JpaClientMapStorage branch 2 times, most recently from 45fb34c to 68c1958 Compare November 1, 2021 08:11
@vramik
vramik force-pushed the wip-JpaClientMapStorage branch 7 times, most recently from 1585be4 to 3dac44e Compare November 10, 2021 10:44
@vramik
vramik force-pushed the wip-JpaClientMapStorage branch 4 times, most recently from 0eb87ae to 9b339fb Compare November 27, 2021 16:49
@vramik
vramik marked this pull request as ready for review November 29, 2021 10:59
@vramik
vramik requested review from hmlnarik and sguilhen November 29, 2021 10:59
@hmlnarik hmlnarik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @vramik!
Could you please check the questions inline?
Also please move the org.keycloak.models.map.jpa package to org.keycloak.models.map.storage.jpa to be consistent with chm and Hot Rod (fixed in latest main)

@vramik
vramik force-pushed the wip-JpaClientMapStorage branch 3 times, most recently from 4791e32 to be06f18 Compare December 6, 2021 18:40
@vramik
vramik requested a review from hmlnarik December 7, 2021 09:05
@vramik
vramik force-pushed the wip-JpaClientMapStorage branch from be06f18 to 0704769 Compare December 7, 2021 09:27
@hmlnarik hmlnarik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vramik, looks very good! Could you please check few remaining inline comments?

@vramik
vramik force-pushed the wip-JpaClientMapStorage branch 2 times, most recently from 1e7e1b9 to e84c1b8 Compare December 14, 2021 09:56
@vramik
vramik requested review from hmlnarik and sguilhen December 14, 2021 10:03
sguilhen
sguilhen previously approved these changes Dec 14, 2021
…18712 KEYCLOAK-18711 JPA clients no-downtime store
@vramik
vramik force-pushed the wip-JpaClientMapStorage branch from 71d37ab to e687899 Compare December 15, 2021 10:56
@hmlnarik hmlnarik left a comment •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< B64B input type="hidden" name="_method" value="put" autocomplete="off" />

Thank you @vramik. Great job!

@hmlnarik
hmlnarik merged commit c6312e3 into keycloak:main Dec 15, 2021
@vramik vramik mentioned this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0