8000 KEYCLOAK-19726 Fix return types of ModelCriteriaBuilder methods by hmlnarik · Pull Request #8694 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

KEYCLOAK-19726 Fix return types of ModelCriteriaBuilder methods - #8694

Merged
hmlnarik merged 1 commit into
keycloak:mainfrom
hmlnarik:KEYCLOAK-19726-mcb-return-types
Nov 5, 2021
Merged

hmlnarik merged 1 commit into
keycloak:mainfrom
hmlnarik:KEYCLOAK-19726-mcb-return-types

Conversation

@hmlnarik
@hmlnarik hmlnarik commented Nov 3, 2021 •
Copy link
Copy Markdown
Contributor

Affects #8571 and #8615

@hmlnarik hmlnarik added the area/storage Storage layer — JPA entities, databa 10000 se schemas, Liquibase migrations, caching label Nov 3, 2021
@hmlnarik
hmlnarik requested review from mhajas and vramik November 3, 2021 20:29
@hmlnarik hmlnarik self-assigned this Nov 3, 2021
@hmlnarik
hmlnarik force-pushed the KEYCLOAK-19726-mcb-return-types branch from e14f78e to 32fad4d Compare November 4, 2021 07:46
vramik
vramik previously approved these changes Nov 4, 2021
@vramik vramik left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @hmlnarik

@mhajas mhajas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @hmlnarik. I added few comments, could you please have a look.

@hmlnarik
hmlnarik force-pushed the KEYCLOAK-19726-mcb-return-types branch 2 times, most recently from 77ee647 to a23844b Compare November 4, 2021 19:33
@hmlnarik
hmlnarik requested a review from mhajas November 4, 2021 20:30
@hmlnarik
hmlnarik force-pushed the KEYCLOAK-19726-mcb-return-types branch from a23844b to a7ca35f Compare November 5, 2021 12:47
@mhajas mhajas left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @hmlnarik. Approving.

@hmlnarik
hmlnarik merged commit 58d403c into keycloak:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0